Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/#review60748 --- This review has been submitted with commit 49ea0513c4325ea8bd

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/ --- (Updated June 23, 2014, 6:28 a.m.) Status -- This change has been ma

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-20 Thread Vishesh Handa
> On June 20, 2014, 11:17 a.m., Vishesh Handa wrote: > > I approve. > > > > The only problem I have is with the documentation, but we can improve that > > in another patch. > > Martin Gräßlin wrote: > well let's improve directly. What do you think is missing with these new > methods or is

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-20 Thread Martin Gräßlin
> On June 20, 2014, 1:17 p.m., Vishesh Handa wrote: > > I approve. > > > > The only problem I have is with the documentation, but we can improve that > > in another patch. well let's improve directly. What do you think is missing with these new methods or is that more a general comment? - M

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/#review60588 --- Ship it! I approve. The only problem I have is with the docu

Review Request 118844: Introduce convenient methods to set active and default shortcut

2014-06-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/ --- Review request for KDE Frameworks and Vishesh Handa. Repository: kglobala