Re: Review Request 120185: Look for kdesu in the correct location

2015-02-09 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Feb. 9, 2015, 5:41 p.m.) Status -- This change has been mar

Re: Review Request 120185: Look for kdesu in the correct location

2015-02-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review75682 --- Ship it! libexec/kf5 sounds sensible to me. I'd say, barring

Re: Review Request 120185: Look for kdesu in the correct location

2015-01-29 Thread Marco Martin
> On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote: > > any updates on that? > > > > here the patch works correctly after i make kdesu to be installed under > > CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR > > > > I would push this asap, since kdesu in Plasma 5 is

Re: Review Request 120185: Look for kdesu in the correct location

2015-01-29 Thread Marco Martin
> On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote: > > any updates on that? > > > > here the patch works correctly after i make kdesu to be installed under > > CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR > > > > I would push this asap, since kdesu in Plasma 5 is

Re: Review Request 120185: Look for kdesu in the correct location

2015-01-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review74983 --- any updates on that? here the patch works correctly after i m

Re: Review Request 120185: Look for kdesu in the correct location

2014-10-04 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Oct. 4, 2014, 3:32 p.m.) Review request for KDE Frameworks and D

Re: Review Request 120185: Look for kdesu in the correct location

2014-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review67887 --- libexec/kf5 is necessary for it to be co-installable with KDE

Re: Review Request 120185: Look for kdesu in the correct location

2014-09-25 Thread Maarten De Meyer
> On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: > > this approach is probably better than > > https://git.reviewboard.kde.org/r/120040/ > > Maarten De Meyer wrote: > I think we'll need both. We still need to rename the kdesu binary, no? > > Marco Martin wrote: > if it goes in libe

Re: Review Request 120185: Look for kdesu in the correct location

2014-09-16 Thread Marco Martin
> On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: > > this approach is probably better than > > https://git.reviewboard.kde.org/r/120040/ > > Maarten De Meyer wrote: > I think we'll need both. We still need to rename the kdesu binary, no? if it goes in libexec yes, otherwise if it goes

Re: Review Request 120185: Look for kdesu in the correct location

2014-09-16 Thread Maarten De Meyer
> On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: > > this approach is probably better than > > https://git.reviewboard.kde.org/r/120040/ I think we'll need both. We still need to rename the kdesu binary, no? - Maarten --- This is a

Re: Review Request 120185: Look for kdesu in the correct location

2014-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 --- this approach is probably better than https://git.reviewboard.

Review Request 120185: Look for kdesu in the correct location

2014-09-13 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- Review request for KDE Frameworks and David Faure. Bugs: 338755 https