---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated April 15, 2015, 8:24 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review78995
---
Ship it!
Ship It!
- Jeremy Whiting
On April 15, 2015,
On April 15, 2015, 8:39 p.m., Jeremy Whiting wrote:
Ship It!
As KMoreTools is going to be part of KNewStuff it should be using
KNEWSTUFF_EXPORT not KSERVICE_EXPORT.
The install dir now looks like this:
http://wstaw.org/m/2015/04/15/plasma-desktopVd2099.png I wonder if this ok to
have a
On April 15, 2015, 2:39 p.m., Jeremy Whiting wrote:
Ship It!
Gregor Mi wrote:
As KMoreTools is going to be part of KNewStuff it should be using
KNEWSTUFF_EXPORT not KSERVICE_EXPORT.
The install dir now looks like this:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated April 15, 2015, 9:11 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated April 15, 2015, 9:21 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review78941
---
As KMoreTools is going to be part of KNewStuff it should be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated April 12, 2015, 11:54 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated April 12, 2015, 11:17 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated April 2, 2015, 4:48 p.m.)
Review request for KDE Frameworks and
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 394
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line394
Do we need the kmt-prefix? Why not just
KMoreToolsService * service();
Gregor Mi wrote:
I am not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 22, 2015, 12:37 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 22, 2015, 7:41 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77511
---
src/kmoretools/kmoretools.cpp
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 36
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line36
Proper doxygen would look like this: The first sentence is always the
brief documentation.
Currently,
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 394
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line394
Do we need the kmt-prefix? Why not just
KMoreToolsService * service();
I am not completely that happy
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 287
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line287
@return, never @returns.
Further, can you be mor verbose?
@return Returns the tools
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 412
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line412
Qt API never returns a this pointer when settings some properties.
While not explicitely stated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
---
I don't think that the patch in it's current form is ok to
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 412
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line412
Qt API never returns a this pointer when settings some properties.
While not explicitely stated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 15, 2015, 5:07 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 15, 2015, 5:18 p.m.)
Review request for KDE Frameworks
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 287
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line287
@return, never @returns.
Further, can you be mor verbose?
@return Returns the tools
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
Review request for KDE Frameworks, Emmanuel Pescosta and Jeremy Whiting.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 11, 2015, 11:06 p.m.)
Review request for KDE Frameworks,
25 matches
Mail list logo
