Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- (Updated abr. 29, 2015, 11:23 p.m.) Status -- This change has been d

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > > > > > Just tested the patch myself on sonnet. > > > > The test indeed breaks if sonnet is not instal

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On abr. 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > > > > > Just tested the patch myself on sonnet. > > > > The test indeed breaks if sonnet is not install

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > > > > > I think there should be an argument that could be passed to disable > > this (NO_TESTS?). Not all

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > > > > > I think there should be an argument that could be passed to disable > > this (NO_TESTS?). Not all

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > > > > > Just tested the patch myself on sonnet. > > > > The test indeed breaks if sonnet is not instal

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79460 --- modules/ECMGeneratePriFile.cmake (line 179)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On abr. 24, 2015, 3:36 p.m., Alex Merry wrote: > > modules/ECMGeneratePriFile.cmake, lines 178-180 > > > > > > I think there should be an argument that could be passed to disable > > this (NO_TESTS?). Not all

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79458 --- modules/ECMGeneratePriFile.cmake (lines 177 - 179)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On abr. 24, 2015, 3:21 p.m., Kevin Funk wrote: > > Hm, this could cause problems in the case where you generate multiple .pri > > files which depend on each other within one project. Problem .pri files are > > not yet installed, thus the QT modules are not yet available. > > > > I suggest tr

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- (Updated abr. 24, 2015, 3:26 p.m.) Review request for Extra Cmake Modules

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79454 --- Hm, this could cause problems in the case where you generate m

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79452 --- Ship it! modules/ECMGeneratePriFile.cmake (line 174)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79451 --- Cool stuff! :) Maybe you can add some documentation explainin

Review Request 123491: Add a test that checks the modules we're depending on exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk. Re