---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated June 10, 2015, 4:41 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80755
---
Ship it!
...in 10 days
Great work on all this.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 21, 2015, 10:52 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80695
---
Ship it!
Awesome. I love the test!
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 21, 2015, 4:02 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80669
---
src/quickaddons/quickviewsharedengine.h (line 41)
On May 20, 2015, 5:24 p.m., Vishesh Handa wrote:
src/quickaddons/quickviewsharedengine.h, line 41
https://git.reviewboard.kde.org/r/123735/diff/8/?file=370104#file370104line41
It would be awesome if we could have some tests for this class.
Maybe we can just try and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80630
---
src/kdeclarative/qmlobjectsharedengine.cpp (line 41)
On May 19, 2015, 3:04 p.m., Vishesh Handa wrote:
src/kdeclarative/qmlobjectsharedengine.cpp, line 60
https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60
I'm probably missing some parts of the picture. Could you please
explain why this needs to be static?
On May 19, 2015, 3:04 p.m., Vishesh Handa wrote:
src/kdeclarative/qmlobjectsharedengine.cpp, line 60
https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60
I'm probably missing some parts of the picture. Could you please
explain why this needs to be static?
On May 19, 2015, 3:04 p.m., Vishesh Handa wrote:
src/kdeclarative/qmlobjectsharedengine.cpp, line 60
https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60
I'm probably missing some parts of the picture. Could you please
explain why this needs to be static?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 18, 2015, 7:09 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 18, 2015, 7:02 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80600
---
src/quickaddons/quickviewsharedengine.cpp (lines 35 - 39)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 18, 2015, 8 p.m.)
Review request for KDE Frameworks and
On May 12, 2015, 5:45 p.m., Mark Gaiser wrote:
src/kdeclarative/qmlobjectsharedengine.h, line 57
https://git.reviewboard.kde.org/r/123735/diff/5/?file=368396#file368396line57
std::unique_ptr... ...
then you can also forget about the delete in the destructor.
buh, fine
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 13, 2015, 5:37 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 12, 2015, 4:10 p.m.)
Review request for KDE Frameworks and
On May 12, 2015, 3:52 p.m., David Edmundson wrote:
src/kdeclarative/qmlobjectsharedengine.cpp, line 62
https://git.reviewboard.kde.org/r/123735/diff/2/?file=368373#file368373line62
this needs to be initialised.
line 65
QQmlEngine *QmlObjectSharedEnginePrivate::s_engine = 0;
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 12, 2015, 4:05 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80252
---
src/kdeclarative/qmlobjectsharedengine.h (line 57)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80241
---
Can you make the diff against the branch root instead of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 12, 2015, 3:35 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80244
---
src/kdeclarative/qmlobject.cpp (line 176)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80249
---
src/kdeclarative/qmlobject.h (line 81)
26 matches
Mail list logo