Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/ --- (Updated June 24, 2015, 8:13 p.m.) Status -- This change has been ma

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-24 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81718 --- Ship it! Ok, looks good to me. Minor nitpick below :) autot

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-24 Thread Mark Gaiser
On jun 23, 2015, 12:26 p.m., David Faure wrote: > > Regarding the style. AStyle time i think ;) > > There is lots of function( arg ) instead of function(arg). ?besides that, > > some places could use more line breaks for readability (marked above). > > > > Some API questions. > > setSourceColum

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/ --- (Updated June 23, 2015, 9:33 p.m.) Review request for KDE Frameworks. C

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread David Faure
> On June 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 92 > > > > > > can you make a smart pointer of this one? I prefer std::unique_ptr<...> > > but the Qt versions are ob

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread Mark Gaiser
> On jun 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 71 > > > > > > add line break > > David Faure wrote: > Where, between methods? I like the current grouping ;) My

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread David Faure
On June 23, 2015, 12:26 p.m., David Faure wrote: > > Regarding the style. AStyle time i think ;) > > There is lots of function( arg ) instead of function(arg). ?besides that, > > some places could use more line breaks for readability (marked above). > > > > Some API questions. > > setSourceColu

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread David Faure
> On June 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 71 > > > > > > add line break Where, between methods? I like the current grouping ;) > On June 23, 2015, 12:26 p.m.

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81702 --- autotests/krearrangecolumnsproxymodeltest.cpp (line 180)

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81703 --- Ship it! Ship It! - Jeremy Whiting On June 23, 2015, 5:33

Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

2015-06-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/ --- Review request for KDE Frameworks. Repository: kitemmodels Description