Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- (Updated Aug. 10, 2015, 6:13 a.m.) Status -- This change has been ma

Re: Review Request 124542: CMake fixes for Windows build

> On Ago. 8, 2015, 4:40 p.m., Kevin Funk wrote: > > @Luigi: Bump? > > Luigi Toscano wrote: > I was waiting for D?vis' answer, but given that 5.13 is out, there is > enough time to fix it before 5.14. So let's go, and thanks. > > Luigi Toscano wrote: > Just please remember to use a more

Re: Review Request 124542: CMake fixes for Windows build

> On Aug. 8, 2015, 5:40 p.m., Kevin Funk wrote: > > @Luigi: Bump? > > Luigi Toscano wrote: > I was waiting for D?vis' answer, but given that 5.13 is out, there is > enough time to fix it before 5.14. So let's go, and thanks. > > Luigi Toscano wrote: > Just please remember to use a more

Re: Review Request 124542: CMake fixes for Windows build

> On Ago. 8, 2015, 4:40 p.m., Kevin Funk wrote: > > @Luigi: Bump? > > Luigi Toscano wrote: > I was waiting for D?vis' answer, but given that 5.13 is out, there is > enough time to fix it before 5.14. So let's go, and thanks. Just please remember to use a more descriptive commit message tha

Re: Review Request 124542: CMake fixes for Windows build

> On Ago. 8, 2015, 4:40 p.m., Kevin Funk wrote: > > @Luigi: Bump? I was waiting for D?vis' answer, but given that 5.13 is out, there is enough time to fix it before 5.14. So let's go, and thanks. - Luigi --- This is an automatically ge

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83576 --- Ship it! Inviala! - Luigi Toscano On Ago. 6, 2015, 8:37 a.

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83574 --- @Luigi: Bump? - Kevin Funk On Aug. 6, 2015, 6:37 a.m., Kevi

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- (Updated Aug. 6, 2015, 6:37 a.m.) Review request for Documentation, KDE F

Re: Review Request 124542: CMake fixes for Windows build

On Ago. 1, 2015, 11:35 p.m., Kevin Funk wrote: > > Looking back at the review which introduced the escaping, namely > > https://git.reviewboard.kde.org/r/120648/ , I escaped the comma as well in > > the first review. I don't remember why I removed them. Apart from that > > usage, comma are inv

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83349 --- Kevin, when you update the patch, and after the ship it (which

Re: Review Request 124542: CMake fixes for Windows build

On Aug. 2, 2015, 12:35 a.m., Kevin Funk wrote: > > Looking back at the review which introduced the escaping, namely > > https://git.reviewboard.kde.org/r/120648/ , I escaped the comma as well in > > the first review. I don't remember why I removed them. Apart from that > > usage, comma are inv

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83305 --- cmake/uriencode.cmake (line 37)

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- (Updated Aug. 1, 2015, 9:40 a.m.) Review request for Documentation, KDE F

Re: Review Request 124542: CMake fixes for Windows build

> On Lug. 31, 2015, 7:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extrem

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 5:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extrem

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- (Updated July 31, 2015, 5:33 p.m.) Review request for Documentation, KDE

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 5:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extrem

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 5:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extrem

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 8:18 a.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > no-op? > > Kevin Funk wrote: > Not a no-op, this code is written into cmake_install which is used for > the 'inst

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 5:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extrem

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83249 --- src/CMakeLists.txt (line 20)

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 10:18 a.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > no-op? > > Kevin Funk wrote: > Not a no-op, this code is written into cmake_install which is used for > the 'ins

Re: Review Request 124542: CMake fixes for Windows build

> On July 31, 2015, 8:18 a.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > > > > > no-op? Not a no-op, this code is written into cmake_install which is used for the 'install' target. If I don't add t

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83214 --- This is not ideal indeed, because URIs usually contain a real

Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos