Re: Review Request 125616: Make doctools + wallet optional

2015-10-18 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 18, 2015, 12:30 p.m.) Status -- This change has been m

Re: Review Request 125616: Make doctools + wallet optional

2015-10-18 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 18, 2015, 12:30 p.m.) Review request for KDE Frameworks, Al

Re: Review Request 125616: Make doctools + wallet optional

2015-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review87014 --- Ship it! src/kpasswdserver/kpasswdserver.cpp (line 814)

Re: Review Request 125616: Make doctools + wallet optional

2015-10-18 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 18, 2015, 10:43 a.m.) Review request for KDE Frameworks, Al

Re: Review Request 125616: Make doctools + wallet optional

2015-10-18 Thread Christoph Cullmann
> On Oct. 18, 2015, 9:49 a.m., David Faure wrote: > > src/kpasswdserver/CMakeLists.txt, line 9 > > > > > > I think it would make more sense to have ifdef HAVE_KWALLET in > > kpasswdserver.cpp, because kpasswdserve

Re: Review Request 125616: Make doctools + wallet optional

2015-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review87004 --- src/kpasswdserver/CMakeLists.txt (line 9)

Re: Review Request 125616: Make doctools + wallet optional

2015-10-17 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. > > Christoph Cullmann wrot

Re: Review Request 125616: Make doctools + wallet optional

2015-10-13 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. > > Christoph Cullmann wrot

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. Done - Christoph --

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 13, 2015, 6:32 a.m.) Review request for KDE Frameworks and

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary Yes, that is true, will update the patch tomorrow. - Christoph

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review86763 --- People should known what they are missing when building withou

Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc