Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-03 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87946 --- Ship it! Ship It! - Ivan Čukić On Nov. 1, 2015, 1:33

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/ --- (Updated Nov. 3, 2015, 7:12 p.m.) Status -- This change has been

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-02 Thread Martin Gräßlin
> On Nov. 1, 2015, 11:35 p.m., David Edmundson wrote: > > I've made https://git.reviewboard.kde.org/r/125915/ back referencing my comment to that review: I think trying to change KWindowSystem to not use desktopWidget doesn't solve the problem. KWindowSystem is a QWidget based framework. Thus

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-02 Thread Martin Gräßlin
> On Nov. 1, 2015, 12:49 p.m., Ivan Čukić wrote: > > So, we went a full circle back to QApplication :) > > > > What assert are you hitting on unity? > > Albert Astals Cid wrote: > KWindowSystem uses QApplication::desktopWidget which you can't if you're > not a QApplication > What assert

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-01 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87792 --- So, we went a full circle back to QApplication :) What

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87825 --- I've made https://git.reviewboard.kde.org/r/125915/ - David

Review Request 125905: Make kactivitymanagerd a QApplication

2015-10-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/ --- Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić.