Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Dec. 23, 2015, 3:58 p.m.) Status -- This change has been ma

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89992 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 15, 2015, 1

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89750 --- Hey, when my patch will be reviewed? - Artur Puzio On Gru 1

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Gru 15, 2015, 12:45 po południu) Review request for KDE Framewor

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89538 --- src/kuitmarkup.h (line 193)

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Gru 14, 2015, 8:10 po południu, Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals.

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Gru 15, 2015, 12:34 po południu) Review request for KDE Framewor

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 8:10 p.m., Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals. > >

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Gru 14, 2015, 8:10 po południu, Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals.

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 7:10 p.m., Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals. > >

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89492 --- src/klocalizedstring.cpp (line 389)

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Gru 14, 2015, 7:46 po południu) Status -- This change has b

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89488 --- I ran the tests locally and I can confirm that clazy warnings

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 7:38 p.m., Aleix Pol Gonzalez wrote: > > I ran the tests locally and I can confirm that clazy warnings are gone and > > all tests still pass. +1, waiting for maintainer approval. - Aleix --- This is an automatically

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Dec. 14, 2015, 7:37 p.m.) Review request for KDE Frameworks and