Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review102430 --- See bug 37 for a regression. Not sure if it is fixable.

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/ --- (Updated Dec. 29, 2016, 5:31 p.m.) Status -- This change has been

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review101640 --- Fix it, then Ship it! Looks good (will need a call from

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100674 --- Note that this check won't happen in apps based on

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Nov. 1, 2016, 1:35 a.m., Aleix Pol Gonzalez wrote: > > How about putting it in QDebug? > > Message boxes could make us all miserable. > > Albert Astals Cid wrote: > Making us miserable is the point, that way you'll fix it, a qdebug is > something noone will even see. (Note this should

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100525 --- +1, after some thinking and discussion. Would it make

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Nov. 1, 2016, 2:35 a.m., Aleix Pol Gonzalez wrote: > > src/kxmlguiwindow.cpp, line 313 > > > > > > How come this is the _only_ exception? > > Albert Astals Cid wrote: > Because it's the only case where

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Nov. 1, 2016, 1:35 a.m., Aleix Pol Gonzalez wrote: > > How about putting it in QDebug? > > Message boxes could make us all miserable. > > Albert Astals Cid wrote: > Making us miserable is the point, that way you'll fix it, a qdebug is > something noone will even see. (Note this should

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Nov. 1, 2016, 2:35 a.m., Aleix Pol Gonzalez wrote: > > How about putting it in QDebug? > > Message boxes could make us all miserable. > > Albert Astals Cid wrote: > Making us miserable is the point, that way you'll fix it, a qdebug is > something noone will even see. (Note this should

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > src/kxmlguiwindow.cpp, line 327 > > > > > > I think it would be better if this were not blocking (i.e. creating the > > QMessageBox manually and

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100456 --- How about putting it in QDebug? Message boxes could make us

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > src/kxmlguiwindow.cpp, line 327 > > > > > > I think it would be better if this were not blocking (i.e. creating the > > QMessageBox manually and

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for KDE Frameworks,

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > +1, fixes the Gwenview case. I get a warning with Dolphin, but it looks > > unrelated: http://i.imgur.com/ZF454gn.png No, that's actually a problem with my code being too strict, dolphin alternates the enabledness of the actions that

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100448 --- +1, fixes the Gwenview case. I get a warning with Dolphin,

Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/ --- Review request for KDE Frameworks, David Faure and Elvis Angelaccio.