Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/ --- (Updated Nov. 9, 2016, 10:36 p.m.) Status -- This change has been ma

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100729 --- Doesn't help me on Fedora 24 though (yes, I know this is abo

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100717 --- Ship it! Ship It! - Jonathan Riddell On Nov. 7, 2016,

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Jonathan Riddell
> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote: > > On my system (ubuntu 16.04 base) this is achieved by > > ${KDE_INSTALL_FULL_LIBDIR}/utempter > > What's changed in 16.10 that alters this? > > Albert Astals Cid wrote: > That only works under the bogus assumption that one will i

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Albert Astals Cid
> On Nov. 8, 2016, 11:57 a.m., Anthony Fieroni wrote: > > cmake/FindUTEMPTER.cmake, line 43 > > > > > > I think we shouldn't search in fixed path i.e. /usr/... > > ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCH

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Albert Astals Cid
> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote: > > On my system (ubuntu 16.04 base) this is achieved by > > ${KDE_INSTALL_FULL_LIBDIR}/utempter > > What's changed in 16.10 that alters this? That only works under the bogus assumption that one will install KDE (what does "installing

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100712 --- cmake/FindUTEMPTER.cmake (line 43)

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100710 --- On my system (ubuntu 16.04 base) this is achieved by ${

Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/ --- Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter. Repos