Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-19 Thread David Faure
> On Dec. 10, 2016, 4:36 a.m., Anthony Fieroni wrote: > > filenamesearch/kio_filenamesearch.cpp, line 113 > > > > > > Or we must keep KIO::UDSEntry::UDS_URL in new patch ? > > Anthony Fieroni wrote: >

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-18 Thread Anthony Fieroni
> On Дек. 10, 2016, 6:36 преди обяд, Anthony Fieroni wrote: > > filenamesearch/kio_filenamesearch.cpp, line 113 > > > > > > Or we must keep KIO::UDSEntry::UDS_URL in new patch ? David, any suggestion? Am i on

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-09 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101351 --- filenamesearch/kio_filenamesearch.cpp (line 113)

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-09 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101350 --- David, this patch has many disadvantages: 1. Search view

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101305 --- I just saw "When is fixed new kio-extras realease is needed

Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-05 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/ --- Review request for KDE Frameworks, Anthony Fieroni, David Faure, and

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-04 Thread David Faure
> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101273 --- Sure, ship the RAM-usage fix, even if we still need to

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-04 Thread Anthony Fieroni
> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-30 Thread Anthony Fieroni
> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-26 Thread David Faure
> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-25 Thread Anthony Fieroni
> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-25 Thread David Faure
> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-24 Thread Anthony Fieroni
> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread David Faure
> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread Anthony Fieroni
> On Nov. 21, 2016, 10:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread Emmanuel Pescosta
> On Nov. 21, 2016, 9:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread David Faure
> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread Anthony Fieroni
> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101007 --- filenamesearch/kded/filenamesearchmodule.cpp (line 84)

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-21 Thread Anthony Fieroni
> On Nov. 15, 2016, 6:40 p.m., David Faure wrote: > > This fix makes sense to me (well, I suggested it) ;) > > > > As to why it doesn't work, that requires more info about how filenamesearch > > URLs are actually being used. Is this documented somewhere, or does it > > require testing and

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-16 Thread Anthony Fieroni
> On Ноев. 15, 2016, 6:40 след обяд, David Faure wrote: > > This fix makes sense to me (well, I suggested it) ;) > > > > As to why it doesn't work, that requires more info about how filenamesearch > > URLs are actually being used. Is this documented somewhere, or does it > > require testing

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-16 Thread Anthony Fieroni
> On Ноев. 15, 2016, 6:40 след обяд, David Faure wrote: > > This fix makes sense to me (well, I suggested it) ;) > > > > As to why it doesn't work, that requires more info about how filenamesearch > > URLs are actually being used. Is this documented somewhere, or does it > > require testing

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review100862 --- This fix makes sense to me (well, I suggested it) ;) As to

Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-13 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/ --- Review request for KDE Frameworks and David Faure. Repository: