Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-16 Thread David Faure
> On Dec. 16, 2016, 2:55 a.m., Stephen Kelly wrote: > > Thanks for working on this! > > > > I noticed that I could remove the change in beginRemoveRows without any > > unit test failing. > > > > Please add this test on top of your patch: > > > > diff --git a/autotests/kselectionproxymodeltes

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/ --- (Updated Dec. 16, 2016, 9:23 a.m.) Status -- This change has been ma

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101464 --- Ship it! Thanks for working on this! I noticed that I co

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101463 --- Ship it! Ship It! - Stephen Kelly On Dec. 15, 2016, 11

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101460 --- +1 looks good. - Aleix Pol Gonzalez On Dec. 16, 2016, 12:

Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmod