Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread Simone Gaiarin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/ --- (Updated July 15, 2017, 12:53 p.m.) Status -- This change has been m

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread Christoph Feck
> On July 15, 2017, 9:31 a.m., Simone Gaiarin wrote: > > Inviala! > > Luigi Toscano wrote: > You can't "ship it" you own review. "Ship it" is marked by other > reviewers who thinks that this should go in. > Do you mean to say that you don't have a developer account and someone > else s

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread David Faure
> On July 15, 2017, 7:31 a.m., Simone Gaiarin wrote: > > Inviala! > > Luigi Toscano wrote: > You can't "ship it" you own review. "Ship it" is marked by other > reviewers who thinks that this should go in. > Do you mean to say that you don't have a developer account and someone > else s

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread Simone Gaiarin
> On Lug. 15, 2017, 7:31 a.m., Simone Gaiarin wrote: > > Inviala! > > Luigi Toscano wrote: > You can't "ship it" you own review. "Ship it" is marked by other > reviewers who thinks that this should go in. > Do you mean to say that you don't have a developer account and someone > else s

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread Luigi Toscano
> On Lug. 15, 2017, 9:31 a.m., Simone Gaiarin wrote: > > Inviala! You can't "ship it" you own review. "Ship it" is marked by other reviewers who thinks that this should go in. Do you mean to say that you don't have a developer account and someone else should push this? - Luigi

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread Simone Gaiarin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/#review103453 --- Ship it! Inviala! - Simone Gaiarin On Lug. 12, 2017, 6

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-15 Thread Simone Gaiarin
> On Lug. 14, 2017, 8:24 p.m., David Faure wrote: > > Enlarging the dialog when showing a child widget can sometimes be done by > > activating the toplevel layout, but with a listview above I'm not sure it > > would work. > > Anyway, I like how it behaves with your patch, I find it quite nice

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/#review103451 --- Ship it! Enlarging the dialog when showing a child widget

Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

2017-07-12 Thread Simone Gaiarin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/ --- Review request for KDE Frameworks. Bugs: 359233 https://bugs.kde.org/