Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2016-10-21 Thread Albert Astals Cid
org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konquer

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, w

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
4, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread David Faure
Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
> On July 15, 2014, 6:27 a.m., Kevin Ottens wrote: > > Note that as mentioned in the "Web Shortcuts KCM" thread, I'm very much not > > in favor of such a code move. kde-frameworks-devel ended up discussing this extensively and in the end things seemed to settle

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
ly, visit: > https://git.reviewboard.kde.org/r/119280/ > --- > > (Updated July 14, 2014, 8:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, t

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Jonathan Riddell
> > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > --- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konqueror, to the KIO framework, where the URI Filters framework it &g

Re: Web Shortcuts KCM

2014-08-11 Thread Eike Hein
On 08/11/2014 09:45 AM, David Faure wrote: In any case you could ask the contributors for relicensing, before you spend a lot of time rewriting it (you "can", but it's such a waste - and a risk for regressions / missing features) I'll try to track them down. Maybe Riddell can help me actu

Re: Web Shortcuts KCM

2014-08-11 Thread David Faure
On Wednesday 06 August 2014 08:58:07 Eike Hein wrote: > On 08/04/2014 10:09 AM, David Faure wrote: > > So yep, that's not going away any time soon ;) > > Alright, so that leaves the licensing problem, right? Do I > need to rewrite the KCM? Can I even? Do we contact Yves > Arrouye for relicensing?

Re: Web Shortcuts KCM

2014-08-05 Thread Eike Hein
On 08/04/2014 10:09 AM, David Faure wrote: So yep, that's not going away any time soon ;) Alright, so that leaves the licensing problem, right? Do I need to rewrite the KCM? Can I even? Do we contact Yves Arrouye for relicensing? Cheers, Eike ___

Re: Web Shortcuts KCM

2014-08-04 Thread David Faure
On Saturday 02 August 2014 12:48:43 Kevin Ottens wrote: > On Saturday 02 August 2014 11:50:17 David Faure wrote: > > Then let's go more "bare bones" in frameworks that can't afford the > > KConfigWidgets dependency, but let's provide the more convenient and more > > usable "out of the box" solution

Re: Web Shortcuts KCM

2014-08-02 Thread Kevin Ottens
On Saturday 02 August 2014 11:50:17 David Faure wrote: > Then let's go more "bare bones" in frameworks that can't afford the > KConfigWidgets dependency, but let's provide the more convenient and more > usable "out of the box" solution in frameworks that can provide it, such as > KIO? Well, if you

Re: Web Shortcuts KCM

2014-08-02 Thread David Faure
On Wednesday 16 July 2014 21:12:25 Kevin Krammer wrote: > On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlyi

Re: Web Shortcuts KCM

2014-08-02 Thread David Faure
On Friday 18 July 2014 00:37:02 Kevin Ottens wrote: > On Thursday 17 July 2014 10:37:45 David Faure wrote: > > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > > (

Re: Web Shortcuts KCM

2014-07-27 Thread Eike Hein
Can you two give me a decision on this? Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Web Shortcuts KCM

2014-07-17 Thread Kevin Ottens
On Friday 18 July 2014 00:37:02 Kevin Ottens wrote: > On Thursday 17 July 2014 10:37:45 David Faure wrote: > > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > > (

Re: Web Shortcuts KCM

2014-07-17 Thread Kevin Ottens
On Thursday 17 July 2014 10:37:45 David Faure wrote: > On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > > (ie at most a > > > > > > > > widget would be enough for the a

Re: Web Shortcuts KCM

2014-07-17 Thread David Faure
On Wednesday 16 July 2014 22:05:21 Kevin Ottens wrote: > On Wednesday 16 July 2014 10:33:43 David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlying

Re: Web Shortcuts KCM

2014-07-16 Thread Eike Hein
On 07/16/2014 10:08 PM, Kevin Ottens wrote: My opinion is that for the time being it should be shipped by the workspace. Once the widget I mentioned in that thread would be available then the KCM could be ported to use it, and Konversation would be able to use said widget directly. I'd like t

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Ottens
On Tuesday 15 July 2014 16:59:29 Eike Hein wrote: > On 07/15/2014 03:16 PM, Kevin Ottens wrote: > > Well, for a single entry menu, really? :-) > > Yeah, I do care about every single menu entry not being broken, no > matter where users use my app :). Sorry, I was unclear there. I meant having to d

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Ottens
On Wednesday 16 July 2014 10:33:43 David Faure wrote: > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > (ie at most a > > > > widget would be enough for the app related settings, we should talk to the > > underlying platform for the other ones). > > I don't want users to have to configu

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Ottens
On Wednesday 16 July 2014 21:12:25 Kevin Krammer wrote: > On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: > > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > > (ie at most a > > > > > > widget would be enough for the app related settings, we should talk to > > > the > > > underlyi

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Krammer
On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: > On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > > (ie at most a > > > > widget would be enough for the app related settings, we should talk to the > > underlying platform for the other ones). > > I don't want users to have to config

Re: Web Shortcuts KCM

2014-07-16 Thread David Faure
On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: > (ie at most a > widget would be enough for the app related settings, we should talk to the > underlying platform for the other ones). I don't want users to have to configure their search engines in 10 KDE apps one after the other by hand.

Re: Web Shortcuts KCM

2014-07-15 Thread Eike Hein
On 07/15/2014 03:16 PM, Kevin Ottens wrote: Well, for a single entry menu, really? :-) Yeah, I do care about every single menu entry not being broken, no matter where users use my app :). Of course admittedly the situ- ation in KDE 4 wasn't good either since it actually meant a runtime dep on

Re: Web Shortcuts KCM

2014-07-15 Thread Kevin Ottens
On Tuesday 15 July 2014 14:59:43 Eike Hein wrote: > On 07/15/2014 10:24 AM, Kevin Ottens wrote: > > Which applications? I experience that mostly in krunner and the browsers. > > As a user I don't think I get to type those anywhere else. > > It's not just typing. Konversation, Okular and Konsole le

Re: Web Shortcuts KCM

2014-07-15 Thread Eike Hein
On 07/15/2014 10:24 AM, Kevin Ottens wrote: Which applications? I experience that mostly in krunner and the browsers. As a user I don't think I get to type those anywhere else. It's not just typing. Konversation, Okular and Konsole let you select text, right-click it and search it using one o

Re: Web Shortcuts KCM

2014-07-15 Thread Kevin Ottens
Hello, On Tuesday 15 July 2014 10:01:50 David Faure wrote: > On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: > > Honestly to me it looks like a wrong move. A better move would be to have > > the framework (e.g. KIO) read the settings from the platform for its > > settings (e.g. proxies). >

Re: Web Shortcuts KCM

2014-07-15 Thread David Faure
On Tuesday 15 July 2014 08:15:46 Kevin Ottens wrote: > Honestly to me it looks like a wrong move. A better move would be to have > the framework (e.g. KIO) read the settings from the platform for its > settings (e.g. proxies). OK about proxies, but web shortcuts is a KIO-specific thing, you won't

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review62372 --- Note that as mentioned in the "Web Shortcuts KCM" t

Re: Web Shortcuts KCM

2014-07-14 Thread Kevin Ottens
On Monday 14 July 2014 13:15:32 John Layt wrote: > Over on the Windows list we've been discussing about KCM's for > configuring common services/frameworks like this when running apps > under non-Plasma desktops, including Gnome, Windows, Mac, etc. > General gist is that we don't want to have system

Re: Web Shortcuts KCM

2014-07-14 Thread Kevin Ottens
Hello, On Monday 14 July 2014 12:46:15 David Faure wrote: > On Monday 14 July 2014 12:34:44 Eike Hein wrote: > > I'd like to port the ebrowsing KCM and move it to > > plasma-desktop or -workspace, since it has plenty > > of users outside of Konq (e.g. Konvi, Konsole and > > Okular, the first two o

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Martin Gräßlin
org/r/119280/ > --- > > (Updated July 14, 2014, 10:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as > Konquer

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Eike Hein
David Faure. Changes --- Sorry for the spam :/. This update also gets rid of the nebulous "enhanced browsing" in the kcmshell5 title for the KCM. Repository: kio Description --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror,

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Eike Hein
David Faure. Changes --- Clarify rename implications. Repository: kio Description (updated) --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Eike Hein
David Faure. Changes --- Added note on categorization. Repository: kio Description (updated) --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-07-14 Thread Eike Hein
David Faure. Changes --- Oops, used wrong group. Repository: kio Description --- As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than

Re: Web Shortcuts KCM

2014-07-14 Thread John Layt
On 14 July 2014 11:46, David Faure wrote: > On Monday 14 July 2014 12:34:44 Eike Hein wrote: >> Hi David, >> >> I'd like to port the ebrowsing KCM and move it to >> plasma-desktop or -workspace, since it has plenty >> of users outside of Konq (e.g. Konvi, Konsole and >> Okular, the first two of wh

Re: Web Shortcuts KCM

2014-07-14 Thread Eike Hein
On 07/14/2014 12:46 PM, David Faure wrote: Given that the kurifilter plugins themselves are in KIO for this same reason, maybe the ebrowsing and the kio (cookies,proxies,useragent) KCMs should go into KIO as well? Sorry, I missed this because it got filtered into k-f-d due to the CC :). I ha

Re: Web Shortcuts KCM

2014-07-14 Thread David Faure
On Monday 14 July 2014 12:34:44 Eike Hein wrote: > Hi David, > > I'd like to port the ebrowsing KCM and move it to > plasma-desktop or -workspace, since it has plenty > of users outside of Konq (e.g. Konvi, Konsole and > Okular, the first two of which have ports now). > > Thoughts? The whole spl