D7708: Use runtime install prefix instead of compile time install prefix.

habacker abandoned this revision. habacker added a comment. duplicate of https://phabricator.kde.org/D7706 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano, bcooksley Cc: #frameworks

D9383: Use correct service executable path for installing kwalletd dbus service on Win32

habacker updated this revision to Diff 24054. habacker added a comment. - use service file template also for Windows REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9383?vs=24040=24054 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9383

D7706: Use runtime install prefix instead of compile time install prefix.

habacker marked an inline comment as done. habacker added inline comments. INLINE COMMENTS > dfaure wrote in kinit_win.cpp:205 > That's the Qt install prefix. I guess it matches your KF5 install prefix for > this patch to work, but it doesn't seem like a universal solution. > > Maybe this can

D9384: Use runtime install prefix instead of compile time install prefix.

habacker abandoned this revision. habacker added a comment. duplicate of https://phabricator.kde.org/D7708 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks

D9387: Add cross compile support for kconfig_compiler and kconf_update.

habacker added a comment. > -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ Can you point me to a working example for related cmake files specifing host tools ? Is KF5_HOST_TOOLING support implemented for all required host tools, which are ( from

Re: Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

/klauncher.cpp c02bd90c4bb65ceb451c9349b637ae9161a3b76a Diff: https://git.reviewboard.kde.org/r/130209/diff/1/ Testing --- Thanks, Ralf Habacker

Re: Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

n automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130209/#review103691 --- On Sept. 6, 2017, 2:07 nachm., Ralf Habacker wrote: > > --- > This is an

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker added a comment. In https://phabricator.kde.org/D9404#181209, @dfaure wrote: > So the if() is needed, yes, > the AFTER isn't enough? I tried that and it does not help - AFTER|BEFORE affects only the order of directories added with include_directories > I

D9381: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml

This revision was automatically updated to reflect the committed changes. Closed by commit R311:32745503b519: Use cmake variable kwallet_xml for specifing org.kde.KWallet.xml (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9381?vs=24036=24135#toc REPOSITORY R311

D9386: Mingw32 compile fix

habacker edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D9386: Mingw32 compile fix

habacker added a comment. In https://phabricator.kde.org/D9386#181227, @dfaure wrote: > If this wasn't kdelibs4support, I'd insist for sharing the implementation rather than duplicating it. Would be nice to share, but networking.cpp is only be used on non win32 platform, so how

D9383: Use correct service executable path for installing kwalletd dbus service on Win32

This revision was automatically updated to reflect the committed changes. Closed by commit R311:74ce261240ae: Use correct service executable path for installing kwalletd dbus service on… (authored by habacker). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D9386: Mingw32 compile fix

habacker closed this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9386 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:382459

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:382460

D9425: Fix 'Exec line in kioexecd service file must not have any path prefix on Windows'

habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388062

D9429: Remove unused and duplicated file

habacker created this revision. habacker added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This file is a duplicate of the same file one directory level above and is not used by the build

D9426: Fix 'Exec line in kssld service file must not have any path prefix on Windows'

habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388063

D9427: Fix 'Exec line in kpasswdserver service file must not have any path prefix on Windows'

habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388060

D9428: Fix 'Exec line in kcookiejar service file must not have any path prefix on Windows'

habacker created this revision. habacker added reviewers: dfaure, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This commit uses a similar approach as https://phabricator.kde.org/D9383 BUG:388059

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker updated this revision to Diff 24158. habacker added a comment. - removed unrelated AFTER parameter REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9404?vs=24090=24158 BRANCH arcpatch-D9404 REVISION DETAIL

D9386: Mingw32 compile fix

habacker added a comment. In https://phabricator.kde.org/D9386#181297, @dfaure wrote: > That's trivial, isn't it? Rename networking.cpp to networking_unix.cpp, and move to networking.cpp the methods that are platform-independent. Any idea how to share the line

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

habacker added a comment. In https://phabricator.kde.org/D9423#181442, @kfunk wrote: > And I agree. There shouldn't be a need to use two different input files. That's the whole point of `configure_file(...)`: the interpolation of values happens *inside* the input files. This

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

habacker added a comment. In https://phabricator.kde.org/D5175#181288, @bcooksley wrote: > I still question how these installs conflict - as all the scenarios where they could conflict should already be taken into account: > > 1. Linux distros, FreeBSD, etc have no co-installability

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fixes also similar error with msvc in case openssl development header has been installed into the same location as KDEWin. TEST

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker added reviewers: dfaure, ltoscano, bcooksley. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9404 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D9383: Use correct service executable path for installing kwalletd dbus service on Win32

habacker created this revision. habacker added reviewers: dfaure, ltoscano, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On Windows service executables are installed in the same directory as normal

D9386: Mingw32 compile fix

habacker created this revision. habacker added reviewers: dfaure, ltoscano, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add missing method Solid::NetworkingPrivate::serviceOwnerChanged(). TEST PLAN

D7706: Use runtime install prefix instead of compile time install prefix.

habacker added reviewers: ltoscano, bcooksley. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7706 To: habacker, dfaure, ltoscano, bcooksley Cc: dfaure, #frameworks

D9387: Add cross compile support for kconfig_compiler and kconf_update.

habacker created this revision. habacker added reviewers: dfaure, ltoscano, bcooksley. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Cross compiling client packages which require kconfig_compiler or kconf_update

D7708: Use runtime install prefix instead of compile time install prefix.

habacker added a reviewer: bcooksley. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano, bcooksley Cc: #frameworks

D7708: Use runtime install prefix instead of compile time install prefix.

habacker added a reviewer: ltoscano. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano Cc: #frameworks

D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'.

habacker added reviewers: ltoscano, bcooksley. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5175 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

habacker added reviewers: ltoscano, bcooksley. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5173 To: habacker, dfaure, ltoscano, bcooksley Cc: bcooksley, dfaure, aacid, #frameworks

D9384: Use runtime install prefix instead of compile time install prefix.

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D9384 AFFECTED FILES src/kdeinit/kinit_win.cpp To: habacker Cc:

D9384: Use runtime install prefix instead of compile time install prefix.

habacker edited the summary of this revision. habacker edited the test plan for this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks

D9384: Use runtime install prefix instead of compile time install prefix.

habacker added reviewers: ltoscano, bcooksley, dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

habacker marked an inline comment as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

habacker updated this revision to Diff 24168. habacker added a comment. - added note REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9424?vs=24148=24168 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9424 AFFECTED FILES

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

habacker added a comment. I stumbled over one issue case and did a quick search which locations are also affected by this issue type. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13406 To: habacker, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY On runtime KF5I18n_DIR points to the same path as CMAKE_CURRENT_LIST_DIR, but adds

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker updated this revision to Diff 35821. habacker added a comment. Fixed autotests REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13406?vs=35756=35821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13406 AFFECTED FILES

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker added a comment. In D13406#275375 , @cgiboudeaux wrote: > -1, this change would break the autotests. Hmmh, https://cmake.org/cmake/help/v3.0/variable/CMAKE_CURRENT_LIST_DIR.html mentions "... that As CMake processes the

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker added a comment. The macro file uses something like`set(_ki18n_uic_script ${CMAKE_CURRENT_LIST_DIR}/kf5i18nuic.cmake) ` for two variables, saying that the referenced files are located beside the macro file, but the remaining files are based surprisely on a complete different

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. TEST PLAN compiled on linux REPOSITORY R235 Attica BRANCH master REVISION DETAIL

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#284822 , @dfaure wrote: > On the other hand it means that when you add a new category, you get to recompile *everything* :-) I understand what you mean, what can be solved by an additional include file

D13733: Add provider auto test

habacker marked an inline comment as done. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D13733 To: habacker, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13733: Add provider auto test

habacker updated this revision to Diff 36693. habacker added a comment. - add documentation tp Provider::requestConfig() REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13733?vs=36668=36693 BRANCH master REVISION DETAIL

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

This revision was automatically updated to reflect the committed changes. habacker marked an inline comment as done. Closed by commit R249:3e44fb72a16d: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed… (authored by habacker). CHANGED PRIOR TO COMMIT

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker added a comment. issued fixed and submitted rebased patch, thanks for reviewing REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13406 To: habacker, ilic, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY The current build system used an incomplete

D13732: Add debug output for all network requests

habacker added a comment. In D13732#283984 , @bruns wrote: > Actually, it does. You have to enable logging explicitly for the per default excluded levels: > `org.kde.attica.debug=true` > >

D13732: Add debug output for all network requests

habacker added a comment. In D13732#283984 , @bruns wrote: > `org.kde.attica.debug=true` Just on question relating the category: Is there something comparable to KDebugDialog and kdebug.areas from KDE4 times

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. Having support for defining multiple debug categories has an additional issue as shown with the following example. As far as I can see there

D13732: Add debug output for all network requests

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Only get requests had a debug output TEST PLAN

D13733: Add provider auto test

habacker created this revision. habacker added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY The provider is checked by fetching the server

D13714: Fix broken url to API specification

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. TEST PLAN checked link in browser REPOSITORY R235 Attica BRANCH master REVISION DETAIL

D13714: Fix broken url to API specification

habacker added a reviewer: mlaurent. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D13714 To: habacker, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13714: Fix broken url to API specification

habacker updated this revision to Diff 36629. habacker added a comment. - fixed author REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13714?vs=36628=36629 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13714 AFFECTED FILES README.md

D13714: Fix broken url to API specification

This revision was automatically updated to reflect the committed changes. Closed by commit R235:864107a0184a: Fix broken url to API specification (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13714?vs=36629=36630 REVISION DETAIL

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. Sorry, copy and paste bug It is complicate to find the correct reviewer for a project, because by default reviews do not get any reviewer by default. .arcconfig located in a related git repo clone does not contain any hint. REPOSITORY R249 KI18n REVISION

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker removed a reviewer: leinir. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13743 To: habacker, apol, ilic, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13732: Add debug output for all network requests

habacker added a comment. Unfortunally changing to qCDebug will not show any debug messages in the provider test app. I can only see debug messages if I change in the top level CMakeLists.txt the line ecm_qt_declare_logging_category(attica_SRCS HEADER attica_debug.h IDENTIFIER

D13733: Add provider auto test

This revision was automatically updated to reflect the committed changes. Closed by commit R235:ebb9d8d9c1a9: Add provider auto test (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13733?vs=36693=36743 REVISION DETAIL

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#283757 , @ltoscano wrote: > Most of the projects are configured so that the reviews are automatic subscription to the relevant list. This means that the people involved with the project should already know

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

This revision was automatically updated to reflect the committed changes. Closed by commit R235:892865d441b4: Port remaining uses of qDebug() to qcDebug(ATTICA) (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13798?vs=36898=36967

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

This revision was automatically updated to reflect the committed changes. Closed by commit R271:76aba6882ae3: Add cmake function kdbusaddons_generate_dbus_service_file (authored by habacker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9480?vs=24564=24738#toc REPOSITORY R271

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. Rechecked after applying https://phabricator.kde.org/D9480 (with a minor cmake 3.5 fix, see https://phabricator.kde.org/R271:f316004e8a17360f667442abd6743644d9418216) without any issue, please accept. REVISION DETAIL https://phabricator.kde.org/D9482 To:

D9425: Fix 'Exec line in kioexecd service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9425 To: habacker, dfaure, bcooksley Cc: #frameworks

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker updated this revision to Diff 24739. habacker added a comment. - removed obsolate service template file REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9482?vs=24563=24739 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9482 AFFECTED

D9427: Fix 'Exec line in kpasswdserver service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9427 To: habacker, dfaure, bcooksley Cc: #frameworks

D9426: Fix 'Exec line in kssld service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9426 To: habacker, dfaure, bcooksley Cc: #frameworks

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks

D9428: Fix 'Exec line in kcookiejar service file must not have any path prefix on Windows'

habacker abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9428 To: habacker, dfaure, bcooksley Cc: #frameworks

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. I can update the patch with this path if you want. It came from the service template file Exec=@CMAKE_INSTALL_PREFIX@/bin/kded5 REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D9482 To: habacker, dfaure, kfunk Cc: #frameworks

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker updated this revision to Diff 24345. habacker added a comment. - use KDE_INSTALL_FULL_BINDIR instead of CMAKE_INSTALL_PREFIX REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9482?vs=24312=24345 BRANCH master REVISION DETAIL

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:105cdd8fb3c4: Use cmake function kdbusaddons_generate_dbus_service_file from kdbusaddons to… (authored by habacker). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker updated this revision to Diff 24890. habacker added a comment. - 5.42.0 is out, update version to 5.43.0 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9669?vs=24744=24890 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9669 AFFECTED

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. In https://phabricator.kde.org/D9669#187313, @habacker wrote: > - 5.42.0 is out, update version to 5.43.0 The patch update demonstrates a surprising phabricator behavior not updating commit messages - where should I report it ? REPOSITORY R241 KIO

D9429: Remove unused and duplicated file

habacker closed this revision. habacker added a comment. patch has been applied REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

This revision was automatically updated to reflect the committed changes. Closed by commit R297:21d5201ea81e: Use cmake function kdbusaddons_generate_dbus_service_file from kdbusaddons to… (authored by habacker). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

habacker updated this revision to Diff 25088. habacker added a comment. - fix generating slot access code REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9468?vs=24256=25088 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9468

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

habacker edited the summary of this revision. habacker edited the test plan for this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9468 To: habacker, dfaure Cc: #frameworks

D9760: Fix kded dbus name in solid-networking howto

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. habacker requested review of this revision. REPOSITORY R239 KDELibs4Support BRANCH master REVISION DETAIL https://phabricator.kde.org/D9760 AFFECTED

D9760: Fix kded dbus name in solid-networking howto

habacker updated this revision to Diff 25012. habacker added a comment. - fix reference to kded5 also in DESIGN REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9760?vs=25010=25012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9760

D9760: Fix kded dbus name in solid-networking howto

This revision was automatically updated to reflect the committed changes. Closed by commit R239:8ab28756d66c: Fix kded dbus name in solid-networking howto (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9760?vs=25012=25013

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. thanks for this pointer, see T7711 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. Add you as subscriber. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

habacker added a comment. see also https://phabricator.kde.org/D9831 REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9468 To: habacker, dfaure Cc: #frameworks

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

This revision was automatically updated to reflect the committed changes. Closed by commit R239:4b70fd9ae983: Fix mingw compile error src/kdeui/kapplication_win.cpp:212:22: error: kill… (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D8428: Fix cross-compiling with MinGW (MXE)

This revision was automatically updated to reflect the committed changes. Closed by commit R303:f14ae9d70886: Fix cross-compiling with MinGW (MXE) (authored by vpinon, committed by habacker). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8428?vs=21141=25748

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R239:1d1af3e51407: Refactor Solid::NetworkingPrivate to have a shared and platform specific… (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D9831: Add Windows notes for network related test applications

This revision was automatically updated to reflect the committed changes. Closed by commit R239:a874b6a67643: Add Windows notes for network related test applications (authored by habacker). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks.

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker retitled this revision from "Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'" to "Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file". habacker edited the summary of this revision. habacker

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

habacker updated this revision to Diff 25187. habacker added a comment. - Use cmake macro from kdbusaddons git repo - Set FIXED-IN version to 5.43.0 because it requires kdbusaddons version 5.43.0 REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. In https://phabricator.kde.org/D9424#181538, @apol wrote: > @kfunk, @vonreth Will craft applications also benefit from this? yes > Or is it solved in a different way there? no REPOSITORY R268 KGlobalAccel REVISION DETAIL

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R268:205b69533bb5: Use cmake function kdbusaddons_generate_dbus_service_file from kdbusaddons to… (authored by habacker).

D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

habacker added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9423 To: habacker, dfaure, bcooksley, kfunk Cc: apol, kfunk, broulik, #frameworks

D9482: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker updated this revision to Diff 24563. habacker added a comment. - remove trailing/bin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9482?vs=24345=24563 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9482 AFFECTED FILES src/CMakeLists.txt To: habacker,

<    1   2   3   4   >