Re: [Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

2015-01-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122128/#review74288 --- If it was only used to start the lock screen then yes it's no

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121386/#review74371 --- daemon/backends/upower/xrandrbrightness.cpp

[Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/ --- Review request for Solid and Kai Uwe Broulik. Bugs: 342597

Re: [Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

2015-01-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122130/#review74310 --- DBus API side all looks good to me - David Edmundson On

Re: [Kde-hardware-devel] Review Request 122128: Don't listen for Login1 Lock signal anymore

2015-01-19 Thread Kai Uwe Broulik
On Jan. 19, 2015, 8:40 vorm., Martin Gräßlin wrote: If it was only used to start the lock screen then yes it's no longer needed. That function is used nowhere else. - Kai Uwe --- This is an automatically generated e-mail. To reply,

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review74344 --- Hmm I don't see how the order could affect the outcome, but

Re: [Kde-hardware-devel] Review Request 122151: Invert the KJob::Exec check logic

2015-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122151/#review74346 --- Ship it! I don't see how this could make any difference but

Re: [Kde-hardware-devel] Review Request 122130: Expose inhibitions over dbus

2015-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122130/ --- (Updated Jan. 19, 2015, 6:41 p.m.) Status -- This change has been

Re: [Kde-hardware-devel] Review Request 121386: Port XRandrBacklight to XCB

2015-01-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121386/ --- (Updated Jan. 19, 2015, 9:30 nachm.) Review request for Solid and Martin