Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

> On April 7, 2015, 10:44 a.m., Àlex Fiestas wrote: > > daemon/backends/upower/ddchelper.cpp, line 29 > > > > > > Calling init in the constructor is dangeours since it is performing > > lots of complex operations

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review78612 --- Also, bunch of new code without tests which makes me sad, but

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review78611 --- src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp (

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262/#review78610 --- ddchelper is a good candidate to write a test for it, speciall

Re: [Kde-hardware-devel] Review Request 123262: ddccontrol support for PowerDevil

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123262/#review78609 --- daemon/backends/upower/ddchelper.cpp (line 29)