Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109792/#review53070 --- What's the status here? Please mark as shipped, discarded or u

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

Hi, To expand on the use case I have: I often let my laptop 'do things' (compile code, download stuff, do a 'yum update', wait for an answer of somebody via IM) where immediate attention isn't needed, but it needs to be somewhat monitored nevertheless (does the code still compile or did it abort

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On April 2, 2013, 2:58 p.m., Oliver Henshaw wrote: > > powerdevil/daemon/actions/bundled/dimdisplay.cpp, lines 53-62 > > > > > > Resolving bug #304696 is good, in my eyes. I'd like affirmation from > > Dario tho

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30994 --- Just a note that I think that dimming to an absolute brightness

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30993 --- Ship it! Thanks a lot, also for your patience with this. - Se

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On April 2, 2013, 2:58 p.m., Oliver Henshaw wrote: > > powerdevil/daemon/actions/bundled/dimdisplay.cpp, lines 53-62 > > > > > > Resolving bug #304696 is good, in my eyes. I'd like affirmation from > > Dario tho

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/ --- (Updated April 13, 2013, noon) Review request for kde-workspace, Solid, Da

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30981 --- This patch can go in with the dimRatio KConfig option removed.

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

On Saturday, April 13, 2013 12:37:56 Danny Baumann wrote: > > The config UI says "dim" not "alter brightness", so the behavior should > > simply be to lower the brightness to n% of the present value ("n" being > > little enough to spot the difference but not enough to turn it off) - > > and never b

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

On Samstag, 13. April 2013 12:37:56 CEST, Danny Baumann wrote: If 'dim' does not mean 'alter brightness' (to be lower), what else does it mean? ;) Implies degradation, subset of "alter brightness" but not equal. But your expectation of it is interesting I expect it to do something notable (

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

Hi, (I assume this is about the "dim after n minutes" feature, i only remotely tracked the thread) Yes, it is. The config UI says "dim" not "alter brightness", so the behavior should simply be to lower the brightness to n% of the present value ("n" being little enough to spot the difference

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/ --- (Updated April 13, 2013, 10:53 a.m.) Review request for kde-workspace, Sol

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

My 3¢ (I assume this is about the "dim after n minutes" feature, i only remotely tracked the thread) The config UI says "dim" not "alter brightness", so the behavior should simply be to lower the brightness to n% of the present value ("n" being little enough to spot the difference but not en

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

On Thursday, April 11, 2013 17:59:03 Danny Baumann wrote: > >> Having said that, my current plan is the following: > >> - Drop the UI option > >> - However, leave the configurability via kconfig intact. That way, users > >> who are not happy with the defaults do at least have a remote chance of >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

Hi, >> Having said that, my current plan is the following: - Drop the UI option - However, leave the configurability via kconfig intact. That way, users who are not happy with the defaults do at least have a remote chance of changing it without recompiling KDE (after they found it's configurable

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

On Thursday, April 11, 2013 15:11:54 Danny Baumann wrote: > Having said that, my current plan is the following: > - Drop the UI option > - However, leave the configurability via kconfig intact. That way, users who > are not happy with the defaults do at least have a remote chance of > changing it

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On April 2, 2013, 2:58 p.m., Oliver Henshaw wrote: > > powerdevil/daemon/actions/bundled/dimdisplay.cpp, lines 53-62 > > > > > > Resolving bug #304696 is good, in my eyes. I'd like affirmation from > > Dario tho

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On April 2, 2013, 2:58 p.m., Oliver Henshaw wrote: > > powerdevil/daemon/actions/bundled/dimdisplay.cpp, lines 53-62 > > > > > > Resolving bug #304696 is good, in my eyes. I'd like affirmation from > > Dario tho

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30295 --- Just to notify you I'm not dead, I've just had an unexpected tr

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On April 2, 2013, 2:58 p.m., Oliver Henshaw wrote: > > powerdevil/daemon/actions/bundled/dimdisplay.cpp, lines 53-62 > > > > > > Resolving bug #304696 is good, in my eyes. I'd like affirmation from > > Dario tho

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On April 2, 2013, 2:58 p.m., Oliver Henshaw wrote: > > powerdevil/daemon/actions/bundled/dimdisplay.cpp, lines 53-62 > > > > > > Resolving bug #304696 is good, in my eyes. I'd like affirmation from > > Dario tho

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30278 --- powerdevil/daemon/actions/bundled/dimdisplay.cpp

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/ --- (Updated April 2, 2013, 1:52 p.m.) Review request for kde-workspace, Solid

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? > > Danny Baumann wrote: >

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

> On March 31, 2013, 4:14 p.m., Àlex Fiestas wrote: > > To be honest I don't like adding yet another configuration option by > > default, a configuration option that apparently is needed only in some > > systems. > > > > There is no other alternative than this? Well, I don't see any. I tried

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/#review30173 --- To be honest I don't like adding yet another configuration opti

Re: [Kde-hardware-devel] Review Request 109792: Update 'dim display' algorithm.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109792/ --- (Updated March 31, 2013, 4:07 p.m.) Review request for kde-workspace and S