On Sun, 2021-03-07 at 20:14 +0100, Julia Lawall wrote:
>
> On Wed, 3 Mar 2021, Joe Perches wrote:
>
> > On Wed, 2021-03-03 at 10:41 +0100, Rasmus Villemoes wrote:
> > > On 02/03/2021 18.42, Joe Perches wrote:
> > > > Here is a possible opportunit
On Wed, 2021-03-03 at 10:41 +0100, Rasmus Villemoes wrote:
> On 02/03/2021 18.42, Joe Perches wrote:
> > Here is a possible opportunity to reduce data usage in the kernel.
> >
> > $ git grep -P -n '^static\s+(?!const|struct)(?:\w+\s+){1,3}\w+\s*\[\s*\]'
> > drivers/ |
On Tue, 2021-03-02 at 22:41 +0100, Julia Lawall wrote:
>
> On Tue, 2 Mar 2021, Joe Perches wrote:
>
> > Here is a possible opportunity to reduce data usage in the kernel.
>
> Does it actually reduce data usage?
Yes, at least for gcc. For instance:
$ gcc --version
gcc (Ub
Here is a possible opportunity to reduce data usage in the kernel.
$ git grep -P -n '^static\s+(?!const|struct)(?:\w+\s+){1,3}\w+\s*\[\s*\]'
drivers/ | \
grep -v __initdata | \
wc -l
3250
Meaning there are ~3000 declarations of arrays with what appears to be
file static const content that
( * removing mentors, I originally meant to send that to mentees )
On Fri, 2020-10-02 at 20:19 +0530, Bhaskar Chowdhury wrote:
> On 11:47 Thu 01 Oct 2020, Joe Perches wrote:
> > It's rather unnecessary for files to contain their
> > path/filename in source code comments.
> >
It's rather unnecessary for files to contain their
path/filename in source code comments.
Here's a trivial little script that can remove
embedded filenames in c90 style comments from files.
This requires git.
It does the following types of removals:
remove individual lines like /* filename */
On Sun, 2020-09-27 at 19:08 +0200, Julia Lawall wrote:
> I end up with 208 patches. I'm not sure that sending them all at once
> would be a good idea...
Last I looked the diffstat for comma -> semicolon was:
234 files changed, 509 insertions(+), 509 deletions(-)
So it would be nearly 1 patch
On Fri, 2020-09-25 at 19:06 +0200, Julia Lawall wrote:
> On Thu, 24 Sep 2020, Joe Perches wrote:
> > On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote:
> > > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote:
> > > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gl
On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote:
> On Thu, Sep 24 2020 at 13:33, Joe Perches wrote:
> > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote:
> > > On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote:
> > > > On Fri, 21 Aug 2020, Joe Perche
On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote:
> On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote:
> > On Fri, 21 Aug 2020, Joe Perches wrote:
> > > True enough for a general statement, though the coccinelle
> > > script Julia provided does not change a single
On Fri, 2020-08-21 at 23:35 -0400, Valdis Klētnieks wrote:
> On Fri, 21 Aug 2020 18:08:08 -0700, Joe Perches said:
> > (forwarding on to kernel-janitors/mentees and kernelnewbies)
> >
> > Just fyi for anyone that cares:
> >
> > A janitorial task for someone m
(forwarding on to kernel-janitors/mentees and kernelnewbies)
Just fyi for anyone that cares:
A janitorial task for someone might be to use Julia's coccinelle
script below to convert the existing instances of commas that
separate statements into semicolons.
On Wed, 2020-07-15 at 15:33 +0800, Ben Chuang wrote:
> The format string of the task descriptor should be "%016llx".
There are a lot of these:
$ git grep -P -n '\b0x\d+%'
arch/m68k/include/asm/mmu_context.h:166:pr_info("ksp load failed:
mm=0x%p ksp=0x08%lx\n", mm, mmuar);
On Sun, 2018-12-16 at 09:06 -1000, Joey Pabalinas wrote:
> I spent a lot of time trying to find an LKML archive in Maildir format
> that I could use for local searches with nutmuch or something, but all
> the links I was able to find were all dead.
You might instead use
.
Am cc'ing Joe Perches for that question. Joe - to get you up to speed,
checkpatch was run against drivers/staging/skein/skein_block.c, and it
flagged one definition of the macro R256, but not the other one, or the
two definitions each for R512 and R1024. Any idea why?
I believe the comment
Convert all the comments to spaces before testing for
single statement macros.
Reported-by: Valdis Kletnieks valdis.kletni...@vt.edu
Signed-off-by: Joe Perches j...@perches.com
---
It's interesting that the warning only popped on the one case where the
/* looping version */ is on a separate
http://kernelnewbies.org/CheckpatchTips
The block about Breaking function calls is dubious.
The majority of code today uses arguments aligned to parenthesis.
The suggested 1 tab is in fact very infrequently used.
CodingStyle has this as substantially to the right, not 1 tab.
btw: there's a
There's a useless + use that needs to be removed as perl 5.20
emits a Useless use of greediness modifier '+' message each
time it's hit.
Reported-by: Greg KH gre...@linuxfoundation.org
Signed-off-by: Joe Perches j...@perches.com
---
Resending, maybe Andrew's all-seeing eye blinked...
On Fri
On Fri, 2014-07-18 at 15:47 -0700, Joe Perches wrote:
On Fri, 2014-07-18 at 18:22 -0400, Theodore Ts'o wrote:
and get_maintainers.pl.
I think checkpatch
Umm, make that get_maintainer...
is pretty good about cc'ing mostly the
right folk by default
-by: Joe Perches j...@perches.com
---
scripts/reformat_with_checkpatch.sh | 141
1 file changed, 141 insertions(+)
create mode 100755 scripts/reformat_with_checkpatch.sh
diff --git a/scripts/reformat_with_checkpatch.sh
b/scripts/reformat_with_checkpatch.sh
new file
On Fri, 2014-07-11 at 18:43 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
[]
If I pick drivers/staging/lustre/include/linux/lnet/types.h, then I get:
staging: lnet
On Fri, 2014-07-11 at 18:34 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
This script is useful primarily for staging.
This reformats code to a more CodingStyle conforming
On Fri, 2014-07-11 at 18:39 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
]
drivers/staging/lustre/include/linux/lnet/api.h has no obvious style problems
and is ready
On Sat, 2014-07-12 at 01:18 -0700, Greg KH wrote:
On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
A simple script to run checkpatch --fix for various types of
of cleanups.
[]
I did the following:
$ scripts/reformat_with_checkpatch.sh drivers/base/bus.c
Ignore the first set
There's a useless + use that needs to be removed as perl 5.20
emits a Useless use of greediness modifier '+' message each
time it's hit.
Reported-by: Greg KH gre...@linuxfoundation.org
Signed-off-by: Joe Perches j...@perches.com
---
On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:
Ok
On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote:
Yes, the warnings are all due to line-length, but Joe, you shouldn't add
a patch that causes more checkpatch warnings than before :)
Yeah, that was intentional though.
This script does a series of relatively discrete changes.
Lindent would
On Sat, 2014-07-12 at 12:28 -0700, Greg KH wrote:
On Sat, Jul 12, 2014 at 11:29:37AM -0700, Joe Perches wrote:
On Sat, 2014-07-12 at 10:55 -0700, Greg KH wrote:
Yes, the warnings are all due to line-length, but Joe, you shouldn't add
a patch that causes more checkpatch warnings than
On Sun, 2014-06-08 at 11:44 -0700, anish singh wrote:
Joe can help you with that.
On Sun, Jun 8, 2014 at 7:29 AM, lx lxlenovos...@gmail.com wrote:
hi all:
I used the script of checkpatch.pl, but some error messages appeared.
##
28 matches
Mail list logo
