Re: develoment workflow: how to avoid duplicate work ?

2018-06-05 Thread Hugo Lefeuvre
> > It's not duplication, it's increment/decrement of a counter. > > > > Look for functions with 'get' and 'put' in their names. > > AFAICT counter is f_count in struct file, updated by fget and fput. Yes, this is the counter I was speaking about. But to me the only way to increment/decrement

Re: a Linux device driver

2018-06-05 Thread valdis . kletnieks
On Tue, 05 Jun 2018 13:51:54 -0700, Abu Rasheda said: > right now, I am in a mood to write a driver, not testing :) Can you, in a few sentences, explain why the Linux community wants a driver written by somebody who wanted to write a driver but didn't want to do the testing needed to ensure it

Re: a Linux device driver

2018-06-05 Thread Abu Rasheda
On Tue, Jun 5, 2018 at 1:51 AM, Ozgur Kara wrote: > > > 05.06.2018, 08:57, "valdis.kletni...@vt.edu" : > > On Mon, 04 Jun 2018 15:49:37 -0700, Abu Rasheda said: > > > >> Any recommendations what device driver is missing and open source > >> community could benefit from a new driver or enhance

Re: develoment workflow: how to avoid duplicate work ?

2018-06-05 Thread valdis . kletnieks
On Tue, 05 Jun 2018 10:20:16 -0400, Hugo Lefeuvre said: > Thanks. I think I'll have to read the source code to fully understand > what happens. Do you know what piece of code handles this reference > duplication ? It's not duplication, it's increment/decrement of a counter. Look for functions

Re: develoment workflow: how to avoid duplicate work ?

2018-06-05 Thread Hugo Lefeuvre
> > Do you mean that the ioctl/read/write call increments the reference > > count in this case ? It would mean that these syscalls aren't really > > using passed FD but instead create duplicates to make sure the open > > file description won't be freed during their execution, right ? > > One file

Re: a Linux device driver

2018-06-05 Thread Ozgur Kara
05.06.2018, 08:57, "valdis.kletni...@vt.edu" : > On Mon, 04 Jun 2018 15:49:37 -0700, Abu Rasheda said: > >>  Any recommendations what device driver is missing and open source >>  community could benefit from a new driver or enhance some existing driver? > > Short answer: One that you have the