Re: [Kicad-developers] TRACK/SEGVIA cleanup patch

On Fri, Apr 18, 2014 at 04:07:22PM -0400, Wayne Stambaugh wrote: 1) You have quite a bit of trailing white space after comments that have been broken into multiple lines and function parameter lists that are on multiple lines. Fscking vim behaviour, I forget all the time about it. 2) I would

[Kicad-developers] Style question: static vs dynamic cast

Just to know what is the preferred idiom in this place... Often a downcast is needed (example: TRACK - VIA) for obvious reasons; I've seen all of the three kind of casts in use around a) (VIA*)track b) static_castVIA*( track ) c) dynamic_castVIA*( track ) a) is the brutal classic C cast (more or

[Kicad-developers] [PATCH] Clang warning removal

Hi, Here is 2 patch to remove some Clang warnings. * a struct/class mismatched tags * /pcbnew/router/direction.h:293:19: warning: comparison of constant 8 with expression of type 'DIRECTION_45::Directions' is always false [-Wtautological-constant-out-of-range-compare]     if( m_dir= 8 )    

Re: [Kicad-developers] [PATCH] Clang warning removal

Date: Sat, 19 Apr 2014 17:44:25 +0200 From: l.marcanto...@logossrl.com On Sat, Apr 19, 2014 at 04:02:21PM +0200, Camille 019 wrote: * /pcbnew/router/direction.h:293:19: warning: comparison of constant 8 with expression of type 'DIRECTION_45::Directions' is always false