On Wed, Jun 29, 2016 at 03:46:05PM -0400, Wayne Stambaugh wrote:
> On 6/29/2016 3:18 PM, jp charras wrote:
> > Le 29/06/2016 à 11:28, Fabrizio Tappero a écrit :
> >> Hello JP,
> >> I noticed that in any of the documentation we talk about KiCad github
> >> Libs, how to install them and
> >> how to
Patch committed in product branch r6958. Thanks.
On 6/29/2016 2:56 PM, Simon Richter wrote:
> ---
> common/config_params.cpp | 10 ++---
> common/dialogs/wx_html_report_panel.cpp| 6 +--
> common/draw_panel_gal.cpp | 7 ++--
> comm
On 6/29/2016 3:18 PM, jp charras wrote:
> Le 29/06/2016 à 11:28, Fabrizio Tappero a écrit :
>> Hello JP,
>> I noticed that in any of the documentation we talk about KiCad github Libs,
>> how to install them and
>> how to update them. Maybe I should write a short paragraph in the KiCad main
>> man
Le 29/06/2016 à 11:28, Fabrizio Tappero a écrit :
> Hello JP,
> I noticed that in any of the documentation we talk about KiCad github Libs,
> how to install them and
> how to update them. Maybe I should write a short paragraph in the KiCad main
> manual?
>
> Regards
> Fabrizio
>
Hello Fabrizio
---
common/config_params.cpp | 10 ++---
common/dialogs/wx_html_report_panel.cpp| 6 +--
common/draw_panel_gal.cpp | 7 ++--
common/footprint_info.cpp | 2 +-
common/geometry/hetriang.cpp
Hi,
On 29.06.2016 20:08, Wayne Stambaugh wrote:
> This patch is failing against r6957. Here is the patch error:
Ah, that was still rebased on the state before the shared_ptr patch,
which removes another include.
Simon
signature.asc
Description: OpenPGP digital signature
_
On 6/28/2016 6:37 PM, Michael Steinberg wrote:
> Hello,
> I removed the "auto" usage, added @todo's and tried to comply with the
> coding style. If there's anything noncompliant left I'd appreciate a
> pointer!
This:
if( m_common_settings ) {
m_common_settings->Flush();
m_comm
This patch is failing against r6957. Here is the patch error:
patching file common/geometry/hetriang.cpp
Hunk #1 FAILED at 45.
1 out of 3 hunks FAILED -- saving rejects to file
common/geometry/hetriang.cpp.rej
The rest of the patch applies cleanly.
On 6/29/2016 1:39 PM, Simon Richter wrote:
>
On 6/29/2016 1:37 PM, Simon Richter wrote:
> Hi Wayne,
>
> On 29.06.2016 17:29, Wayne Stambaugh wrote:
>
>> This patch needs rebased as well. Please include the patch as an
>> attachment rather than inline. Bazaar doesn't play as nicely with
>> inline mail merges as git does.
>
> The "Rewrite
---
common/config_params.cpp | 10 ++---
common/dialogs/wx_html_report_panel.cpp| 6 +--
common/draw_panel_gal.cpp | 7 ++--
common/footprint_info.cpp | 2 +-
common/geometry/hetriang.cpp
These are a tiny bit more readable, and do not depend on all branches to
correctly advance the loop variable.
---
eeschema/sch_screen.cpp | 27 +++
1 file changed, 7 insertions(+), 20 deletions(-)
diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp
index 20a18b
Hi Wayne,
On 29.06.2016 17:29, Wayne Stambaugh wrote:
> This patch needs rebased as well. Please include the patch as an
> attachment rather than inline. Bazaar doesn't play as nicely with
> inline mail merges as git does.
The "Rewrite loop conditions" one, or the "BOOST_FOREACH" one? The
form
I really need to start reading my email more carefully.
On 6/29/2016 11:36 AM, Wayne Stambaugh wrote:
> Sorry about the confusion. This patch was an attachment but your rebase
^^ Simon's
> of replacing boost::shared_ptr with std::share
Sorry about the confusion. This patch was an attachment but your rebase
of replacing boost::shared_ptr with std::shared_ptr patch was not so I
just wanted to make sure your updated boost FOREACH patch was an attachment.
On 6/29/2016 11:34 AM, Chris Pavlina wrote:
> That is an attachment, I think
That is an attachment, I think you need a better mail client. ;)
On Wed, Jun 29, 2016 at 11:29:56AM -0400, Wayne Stambaugh wrote:
> Simon,
>
> This patch needs rebased as well. Please include the patch as an
> attachment rather than inline. Bazaar doesn't play as nicely with
> inline mail merge
Simon,
This patch needs rebased as well. Please include the patch as an
attachment rather than inline. Bazaar doesn't play as nicely with
inline mail merges as git does.
Thanks,
Wayne
On 6/21/2016 11:26 AM, Simon Richter wrote:
>
> These are a tiny bit more readable, and do not depend on all
Patch committed in product branch r6957. Thanks.
Wayne
On 6/29/2016 10:16 AM, Simon Richter wrote:
> This is a simple 1:1 replacement for all cases where shared_ptr is not used
> to point at an array (array handling is not in C++11).
> ---
> 3d-viewer/3d_mesh_model.h | 4 ++--
> c
Hi Wayne,
On 29.06.2016 15:57, Wayne Stambaugh wrote:
> I hate to ask you again but this patch no longer applies cleanly.
> Please rebase it and resubmit it when you get a chance.
No problem, that happens almost automatically with git. :)
Simon
signature.asc
Description: OpenPGP digital
This is a simple 1:1 replacement for all cases where shared_ptr is not used
to point at an array (array handling is not in C++11).
---
3d-viewer/3d_mesh_model.h | 4 ++--
common/gal/opengl/opengl_gal.cpp | 2 +-
common/geometry/hetriang.cpp | 34 +
On 6/29/2016 9:17 AM, Simon Richter wrote:
> Hi,
>
> On 29.06.2016 15:03, Wayne Stambaugh wrote:
>
>> Sounds like we need separate installation instructions for Debian and
>> it's derivatives and the PPA and some helpful notes about the differences.
>
> I'm going to poke Jean-Samuel and Georges
Difference in v2: Drop the ".cmake" suffix on the included files so they
are looked for on the full search path. That one only became apparent
after I removed the build dir and re-configured the project.
Simon
signature.asc
Description: OpenPGP digital signature
_
The FindSWIG.cmake shipped with CMake 3.0 does not yet look for the
"cmake3.0" binary, this was added shortly after the 3.0 release.
This file can be removed once the minimum CMake version is 3.1 or greater.
---
CMakeModules/FindSWIG.cmake | 96 +
1 fi
Simon,
I hate to ask you again but this patch no longer applies cleanly.
Please rebase it and resubmit it when you get a chance.
Thanks,
Wayne
On 6/27/2016 3:35 PM, Simon Richter wrote:
>
> This is a simple 1:1 replacement for all cases where shared_ptr is not used
> to point at an array (arra
The FindSWIG.cmake shipped with CMake 3.0 does not yet look for the
"cmake3.0" binary, this was added shortly after the 3.0 release.
This file can be removed once the minimum CMake version is 3.1 or greater.
---
CMakeModules/FindSWIG.cmake | 96 +
1 fi
Patch committed in product branch r6956. Thanks.
On 6/27/2016 3:35 PM, Simon Richter wrote:
> This is unnecessary -- explicitly specifying the regular copy ctor will
> inhibit any generated versions anyway.
___
Mailing list: https://launchpad.net/~kica
On 6/29/2016 7:46 AM, Maciej Sumiński wrote:
> On 06/28/2016 05:52 PM, Wayne Stambaugh wrote:
>> Orson,
>>
>> Since this mostly effects the new tool framework, I'll defer to your
>> judgement as to whether or not to commit this patch. I don't have a
>> strong opinion one way or the other since we
Hi,
On 29.06.2016 15:03, Wayne Stambaugh wrote:
> Sounds like we need separate installation instructions for Debian and
> it's derivatives and the PPA and some helpful notes about the differences.
I'm going to poke Jean-Samuel and Georges about this. It is a rather
annoying state of affairs. JS'
On 6/29/2016 7:28 AM, Simon Richter wrote:
> Hi,
>
> On 29.06.2016 11:26, Fabrizio Tappero wrote:
>
>> sudo apt-get install kicad
>
>> D
>> oing so kicad libs do not get installed and furthermore the version of
>> KiCad that you get will inevitably complain about libs not being installed
>> .
On 06/28/2016 05:52 PM, Wayne Stambaugh wrote:
> Orson,
>
> Since this mostly effects the new tool framework, I'll defer to your
> judgement as to whether or not to commit this patch. I don't have a
> strong opinion one way or the other since we will not be able to
> completely eliminate boost un
Hi,
On 29.06.2016 11:26, Fabrizio Tappero wrote:
> sudo apt-get install kicad
> D
> oing so kicad libs do not get installed and furthermore the version of
> KiCad that you get will inevitably complain about libs not being installed
> . S
> ome people have complained about it.
In Debian, you
Hello JP,
I noticed that in any of the documentation we talk about KiCad github Libs,
how to install them and how to update them. Maybe I should write a short
paragraph in the KiCad main manual?
Regards
Fabrizio
___
Mailing list: https://launchpad.net/~k
Hello Guys,
I am not completely sure about Windowz or OSX but currently, for Linux,
in the official KiCad website,
we are suggesting this
sudo apt-get install kicad
D
oing so kicad libs do not get installed and furthermore the version of
KiCad that you get will inevitably complain about libs
Le 29/06/2016 à 00:37, Michael Steinberg a écrit :
> Hello,
> I removed the "auto" usage, added @todo's and tried to comply with the coding
> style. If there's
> anything noncompliant left I'd appreciate a pointer!
>
> Michael
>
Michael,
I am thinking the change in your patch:
> +
> +// w
33 matches
Mail list logo
