Re: [Kicad-developers] "Save and Exit" problem?

2017-02-20 Thread Joseph Chen
On 02/20/2017 11:04 AM, Wayne Stambaugh wrote: I just tested this using commit 6fdccc18 which is quite a few commits ahead of a416f3a and I did not see this issue. I tested this issue again with the most recent version and still see "Save and Exist" fails to update the current cached library.

[Kicad-developers] [PATCH] Rearranged Part Editor Icon Positions

2017-02-20 Thread Joseph Chen
Attached is a patch for rearranging part editor icon positions. The changes were made to rearrange the positions of the first 5 icons in the part editor so that they are consistent with footprint editor. --Joe Chen >From c450e877e65a57a95733f0ff93f53fc281b8e999 Mon Sep 17 00:00:00 2001

Re: [Kicad-developers] [PATCH] Swapping Part Editor Icon Order to be consistent to Footprint Editor

2017-02-20 Thread Joseph Chen
Thanks for applying the patch, and will work on the rearranging the delete part. --Joe Chen On 02/20/2017 11:46 AM, Wayne Stambaugh wrote: I committed your patch. Thank you for you contribution to KiCad. If you don't mind, it might be worthwhile rearranging the delete and save current

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Adam Wolf
When i looked into this a while ago, that is actually what Apple strongly recommended/required. Adam Wolf On Feb 20, 2017 5:31 PM, "Wayne Stambaugh" wrote: > On 2/20/2017 6:27 PM, Nick Østergaard wrote: > > 2017-02-20 23:48 GMT+01:00 Bernhard Stegmaier

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

2017-02-20 Thread Nick Østergaard
I think you should just be able to add the branch Maciej linked earlier, and possibly do a pull -r on that. 2017-02-20 19:06 GMT+01:00 Wayne Stambaugh : > Please post the rebased patch. I like to take a look at it and test it. > > Thanks, > > Wayne > > On 2/20/2017 12:50

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Wayne Stambaugh
On 2/20/2017 6:27 PM, Nick Østergaard wrote: > 2017-02-20 23:48 GMT+01:00 Bernhard Stegmaier : >> Hi Wayne, >> >> if you really want to have this commited soon, I’d suggest to completely >> disable KICAD_SCRIPTING_MODULES stuff on macOS. >> >> I just had a look at the

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Wayne Stambaugh
On 2/20/2017 5:48 PM, Bernhard Stegmaier wrote: > Hi Wayne, > > if you really want to have this commited soon, I’d suggest to completely > disable KICAD_SCRIPTING_MODULES stuff on macOS. It is disabled by default so it would be up to our package devs to build with Python scripting disabled. Did

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Nick Østergaard
2017-02-20 23:48 GMT+01:00 Bernhard Stegmaier : > Hi Wayne, > > if you really want to have this commited soon, I’d suggest to completely > disable KICAD_SCRIPTING_MODULES stuff on macOS. > > I just had a look at the KICAD_SCRIPTING_MODULES stuff as it is now and I > think

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Bernhard Stegmaier
Hi Wayne, if you really want to have this commited soon, I’d suggest to completely disable KICAD_SCRIPTING_MODULES stuff on macOS. I just had a look at the KICAD_SCRIPTING_MODULES stuff as it is now and I think it is broken anyway (back then when I changed the bundle stuff I just took what

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Nick Østergaard
Did Dick have look at the log and patched patch that Simon replied with? Any comments on it or? Den 20/02/2017 19.32 skrev "Wayne Stambaugh" : > Simon, > > I'm going to commits Dick's original patch as soon as possible. I want > to know if you (or anyone else who can fix

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Simon Wells
Hi Wayne, I have already sent my concerns and what i am stuck on and have had no response so at this point i am unable to help sorry On 21 February 2017 at 07:28, Wayne Stambaugh wrote: > Simon, > > I'm going to commits Dick's original patch as soon as possible. I want >

Re: [Kicad-developers] diodes.lib

2017-02-20 Thread Wayne Stambaugh
Looks like it accidentally got committed in f1f69979 as part of the spice branch merge. On 2/20/2017 2:43 PM, Chris Pavlina wrote: > It looks like eeschema/diodes.lib was committed accidentally. Does > anyone know for sure if this is the case? > ___

[Kicad-developers] diodes.lib

2017-02-20 Thread Chris Pavlina
It looks like eeschema/diodes.lib was committed accidentally. Does anyone know for sure if this is the case? -- Chris ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] Patch to compile _pcbnew.kiface only once

2017-02-20 Thread Wayne Stambaugh
Simon, I'm going to commits Dick's original patch as soon as possible. I want to know if you (or anyone else who can fix the osx part of this) will be available to fix the osx part of this before I commit it to minimize the amount of time we have broken builds for osx. Thanks, Wayne On

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-02-20 Thread Jon Evans
This time with the patch attached :) On Mon, Feb 20, 2017 at 1:12 PM, Jon Evans wrote: > Hi Orson, > > I've attached a follow-up patch that moves all TOOL_ACTIONs out of > pcb_actions.cpp and creates a COMMON_TOOLS class for storing > cross-application tools. I was not able

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-02-20 Thread Jon Evans
Hi Orson, I've attached a follow-up patch that moves all TOOL_ACTIONs out of pcb_actions.cpp and creates a COMMON_TOOLS class for storing cross-application tools. I was not able to move all zoom/grid tools because of dependencies on pcbnew that need to be resolved -- I did not want to take on

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

2017-02-20 Thread Wayne Stambaugh
Please post the rebased patch. I like to take a look at it and test it. Thanks, Wayne On 2/20/2017 12:50 PM, Maciej Sumiński wrote: > Hi Jon, > > I have just tested the patch, and I really like it. I just need to test > it a bit longer, as there are numerous changes, but I am in favor of >

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

2017-02-20 Thread Jon Evans
Thanks Orson, no I don't mind changing to static consts! Best, Jon On Mon, Feb 20, 2017 at 12:50 PM, Maciej Sumiński wrote: > Hi Jon, > > I have just tested the patch, and I really like it. I just need to test > it a bit longer, as there are numerous changes, but I am

Re: [Kicad-developers] [PATCH] Change from EDA_COLOR_T to COLOR4D and arbitrary color support

2017-02-20 Thread Maciej Sumiński
Hi Jon, I have just tested the patch, and I really like it. I just need to test it a bit longer, as there are numerous changes, but I am in favor of merging the patch. I also applied one more patch changing a few defines (UNSPECIFIED, BLACK, WHITE) to static consts, I hope you do not mind. If

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-02-20 Thread Maciej Sumiński
Thank you John, we really appreciate your efforts. Regards, Orson On 02/20/2017 03:50 PM, Jon Evans wrote: > Hi Orson, > > I can definitely pull the pcb_actions into their respective files, I will > do that and send another patch. > > Best, > Jon > > On Mon, Feb 20, 2017 at 4:25 AM, John

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-02-20 Thread Jon Evans
Hi Orson, I can definitely pull the pcb_actions into their respective files, I will do that and send another patch. Best, Jon On Mon, Feb 20, 2017 at 4:25 AM, John Beard wrote: > HI Orson, > > I think that sounds like a sensible idea. Having a huge central list > of

Re: [Kicad-developers] Stable release 4.0.6

2017-02-20 Thread Wayne Stambaugh
Thanks for the update. I don't know if you are aware, but libcurl is now required to build the 4 stable branch. JP backported the changes from the testing branch to remove avhttp. An rc candidate may make sense in this case. I have tested the github plugin on both 32 and 64 bit windows builds

[Kicad-developers] [PATCH] Move bitmaps.h out of base_struct.h

2017-02-20 Thread John Beard
Hi, Here is a patch to prevent bitmaps.h being included by nearly every file in KiCad via base_struct.h. Prior to this commit, simply touching bitmaps.h would require the recompilation of over 400 files for pcbnew alone, not counting the bitmap files themselves, which are fairly quick to build.

Re: [Kicad-developers] [PATCH] Setting grid line sizes and density

2017-02-20 Thread Maciej Sumiński
Hi John, Well done! Now everything works as expected, so I have just committed your patches. Thank you for your contribution. Cheers, Orson On 02/16/2017 07:05 PM, John Beard wrote: > Hi Orson, > > I have modified the incrementer control to unbind from the kill focus > event. This meant I

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-02-20 Thread Maciej Sumiński
Hi Jon, I see the point of your patch, as COMMON_ACTIONS are now a bit misused. They should not keep majority of the TOOL_ACTIONs, as many of them are pcbnew specific, but there are still actions that will be shared with other applications (e.g. zoom & grid control, move/rotate/flip). For some

Re: [Kicad-developers] [PATCH] Remove dependence on LAYER_ID from EDA_DRAW_PANEL_GAL

2017-02-20 Thread Maciej Sumiński
Hi Jon, Thank you very much, I have just committed your patch. Regards, Orson On 02/17/2017 02:02 AM, Jon Evans wrote: > Hi all, > > Another refactoring of the GAL base classes, this time to not depend on > LAYER_ID, which is specific to pcbnew. > > Best, > Jon > > > >

Re: [Kicad-developers] "Save and Exit" problem?

2017-02-20 Thread Joseph Chen
This error case can be duplicated with the following steps: 1. start "kicad" 2. Open the existing file "a-file.pro" 3. After "Project Rescue Helper" window popping up, un-check the square of "Accept" so not to rescue the old parts. 4. Click "OK" 5. Click "OK" again for "No Symbols were rescued"