Re: [Kicad-developers] Torrents for KiCad distribution

i still wouldn't call it security, validity yes, security no. nor is md5 security On 24 February 2017 at 20:06, Marco Ciampa wrote: > On Fri, Feb 24, 2017 at 08:01:38AM +0100, Nick Østergaard wrote: >> 2017-02-24 7:59 GMT+01:00 Marco Ciampa : >> > On

Re: [Kicad-developers] Torrents for KiCad distribution

On Fri, Feb 24, 2017 at 08:01:38AM +0100, Nick Østergaard wrote: > 2017-02-24 7:59 GMT+01:00 Marco Ciampa : > > On Thu, Feb 23, 2017 at 11:50:59AM -0500, Mark Roszko wrote: > > > >> > I have no issue with that but there is no way for KiCad to control > >> > what is uploaded to a

Re: [Kicad-developers] Torrents for KiCad distribution

On Thu, Feb 23, 2017 at 11:50:59AM -0500, Mark Roszko wrote: > > I have no issue with that but there is no way for KiCad to control > > what is uploaded to a torrent so I really don't want the project to be > > responsible for it > > The torrent could be autogenerated by the download server when

[Kicad-developers] [PATCH] Add cancel interactive tool to GAL

Hi, This adds a new action to the common ACTIONS tools: cancelInteractive. This is an action which can be called to terminate an ongoing interactive tool, for example a drawing tool. The action is can be used pretty much everywhere that the generic IsCancel() event can, but also allows adding an

[Kicad-developers] libcurl dependency

Hi folks, While attempting to build on Windows with -DBUILD_GITHUB_PLUGIN=OFF the build failed due to common/CMakeLists.txt (lines 18-20): if( NOT APPLE ) # windows and linux use openssl under curl find_package( OpenSSL REQUIRED ) endif() Since I know nothing of the github plugin code

Re: [Kicad-developers] Stable release 4.0.6

Let me know when when the osx release is ready to go. Thank you for all of your hard work. Cheers, Wayne On 2/23/2017 8:29 AM, Adam Wolf wrote: > I suspect I will be able to have a release candidate by the end of the > weekend, ie 4 days from now. > > I don't have any way to test if it will

[Kicad-developers] Change behaviour of selectCopper and selectNet feature

Hy, I think the "select Copper" and "select Net" feature should also select zones, and not only track's and via's. When thinking about a user which doesn't know the behavior of the "select Copper" feature, it should be the expected assumption that this feature is really selecting the

Re: [Kicad-developers] Optimization flags in 3d-viewer

Keep it up, your eye candy is excellent :D On Thu, Feb 23, 2017 at 10:43:54PM +, Mário Luzeiro wrote: > I will! That's my style... That's why I bring the "eye candy wow! factor" to > the KiCad's 3D viewer! > > From: Chris Pavlina

Re: [Kicad-developers] Optimization flags in 3d-viewer

I will! That's my style... That's why I bring the "eye candy wow! factor" to the KiCad's 3D viewer! From: Chris Pavlina [pavlina.ch...@gmail.com] Sent: 23 February 2017 22:31 To: Mário Luzeiro Cc: Simon Richter; KiCad Developers Subject: Re:

Re: [Kicad-developers] Optimization flags in 3d-viewer

It's okay if you paint the code red though. That really does make it go faster. Stripes are dope too. On Thu, Feb 23, 2017 at 10:27:36PM +, Mário Luzeiro wrote: > I am *sorry* > > Mario > > > From: Chris Pavlina [pavlina.ch...@gmail.com] > Sent: 23

Re: [Kicad-developers] Optimization flags in 3d-viewer

I am *sorry* Mario From: Chris Pavlina [pavlina.ch...@gmail.com] Sent: 23 February 2017 22:06 To: Mário Luzeiro Cc: Simon Richter; KiCad Developers Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer On Thu, Feb 23, 2017 at 03:48:39PM +,

Re: [Kicad-developers] Optimization flags in 3d-viewer

On Thu, Feb 23, 2017 at 03:48:39PM +, Mário Luzeiro wrote: > Yes I added it, because for 3D we need *speed* :P Things like this are speed holes. https://youtu.be/whnms4CLJys?t=42 *Please* do not add speed holes. If your code is not faster, add optimizations you understand, and remove

Re: [Kicad-developers] [PATCH 2/2] Remove unnecessary double define

Patch committed. Thank you for your contribution. On 2/23/2017 12:00 PM, Simon Richter wrote: > > CMake already sets NDEBUG by default for Release builds, no need to duplicate > this. > --- > CMakeLists.txt | 3 --- > 1 file changed, 3 deletions(-) > > > >

Re: [Kicad-developers] [PATCH 1/2] Drop unnecessary and possibly harmful optimization setting

Patch committed. Thank you for your contribution. On 2/23/2017 12:00 PM, Simon Richter wrote: > > Using -O3 is default for release builds with gcc/clang anyway, so this > doesn't gain anything, but overwriting the existing flags might remove some > that might be needed. > --- >

Re: [Kicad-developers] update on filename fun under Windows

On Fri, Feb 24, 2017 at 8:09 AM, Nick Østergaard wrote: > I tried to bump to 0.18, but it does not build as is. > > I get som errors with "error: external linkage required for symbol" ... > Same here. I wonder if it's a CMake issue. The Microsoft compiler of course by default

Re: [Kicad-developers] update on filename fun under Windows

I tried to bump to 0.18, but it does not build as is. I get som errors with "error: external linkage required for symbol" ... 2017-02-23 21:33 GMT+01:00 Cirilo Bernardo : > On Fri, Feb 24, 2017 at 2:08 AM, Nick Østergaard wrote: >> 2017-02-23 14:53

Re: [Kicad-developers] Torrents for KiCad distribution

Does anyone have stats on what the typical bandwidth transfer is from the download server over time (such as when there is a release)? If there is a problem (i.e. the current server slows down too much or costs too much when there is a release and lots of people download at once), it would be

Re: [Kicad-developers] Torrents for KiCad distribution

I believe the server is located in France Being located most distantly from the kicad download servers i have no issues with the speeds from the download server, If we were qt and had 2.x GB downloads and the speed was complete crap like i get from qt i would encourage torrents. but from

Re: [Kicad-developers] update on filename fun under Windows

On Fri, Feb 24, 2017 at 2:08 AM, Nick Østergaard wrote: > 2017-02-23 14:53 GMT+01:00 Wayne Stambaugh : >> On 2/22/2017 10:01 PM, Cirilo Bernardo wrote: >>> Hi folks, >>> >>> I was looking into non-ASCII characters in file paths under Windows >>> in hopes

[Kicad-developers] [PATCH] Make Mac-specific function conditional

If we want to have an override marker on this function, it needs to be conditional on Mac. --- common/single_top.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/common/single_top.cpp b/common/single_top.cpp index 38ed55f89..c9bd80625 100644 --- a/common/single_top.cpp

Re: [Kicad-developers] Torrents for KiCad distribution

On Thu, Feb 23, 2017 at 08:02:55PM +0100, Ingo Kletti wrote: > Am Donnerstag, 23. Februar 2017, 09:49:41 schrieben Sie: > > No plans currently. Do you think enough people would use them for it to > > really work? > > I have no idea and, as far as I understood the concept of torrents, you could >

[Kicad-developers] [PATCH] Remove lying "override" comments

--- eeschema/class_netlist_object.h| 2 +- gerbview/class_gbr_layout.h| 4 ++-- pagelayout_editor/class_pl_editor_layout.h | 4 ++-- pcbnew/class_netclass.h| 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [Kicad-developers] Optimization flags in 3d-viewer

On Thu, Feb 23, 2017 at 11:45:40AM -0500, Mark Roszko wrote: > Does -O3 really have that much of an improvement though? I assume the > only thing cpu bound thing in the 3d viewer is the raytracing. Even on CPU-bound things -O3 tends not to be too much of an improvement on both gcc and clang. -O2

[Kicad-developers] [PATCH] Remove debug code matching on specific component names

--- eeschema/class_libentry.cpp | 8 pcbnew/eagle_plugin.cpp | 28 pcbnew/legacy_plugin.cpp| 17 - 3 files changed, 53 deletions(-) diff --git a/eeschema/class_libentry.cpp b/eeschema/class_libentry.cpp index 9e7a1b244..b87fb2345

Re: [Kicad-developers] Torrents for KiCad distribution

Am Donnerstag, 23. Februar 2017, 09:49:41 schrieben Sie: > No plans currently. Do you think enough people would use them for it to > really work? I have no idea and, as far as I understood the concept of torrents, you could not tell the number of downloads, just a sum of Bytes transferred

Re: [Kicad-developers] Optimization flags in 3d-viewer

I didn't made any measures or profiling. It will also depending of the target system ... (cache size, etc) ... I leave that to you ;) Mario From: Mark Roszko [mark.ros...@gmail.com] Sent: 23 February 2017 16:45 To: Mário Luzeiro Cc: Simon Richter; KiCad

Re: [Kicad-developers] Strange COLOR4D::LegacyMix( COLOR4D aColor ) optimization

Le 23/02/2017 à 17:00, Jon Evans a écrit : > By the way, thanks for fixing issue with EDA_COLOR_T constructor, I had that > fixed locally but for > some reason it did not make it in to my patch. Sorry about that. I will > have some more time > tonight to look at other color issues if you run

[Kicad-developers] [PATCH 2/2] Remove unnecessary double define

CMake already sets NDEBUG by default for Release builds, no need to duplicate this. --- CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 167fd37c6..5dc9fd77b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -233,9 +233,6 @@ if(

Re: [Kicad-developers] [PATCH] Fix grid sizes in GAL modedit

Hello. Legacy Canvas is deprecated. Only GAL canvas bugs is reported now. I thought that is enough to understand where is a issue. Sorry if I'm wrong. В Четверг, 23 фев. 2017 в 5:15 , John Beard написал: Hi, The COMMON_TOOLS GAL tool wasn't registered in modedit, so

[Kicad-developers] [PATCH 1/2] Drop unnecessary and possibly harmful optimization setting

Using -O3 is default for release builds with gcc/clang anyway, so this doesn't gain anything, but overwriting the existing flags might remove some that might be needed. --- 3d-viewer/CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/3d-viewer/CMakeLists.txt

Re: [Kicad-developers] Torrents for KiCad distribution

Hi Wayne, On 23.02.2017 17:40, Wayne Stambaugh wrote: > I'm > just curious as to what torrents buy us that we don't already provide. It has partial checksums, so if the 3D models are largely unchanged, the total download will be smaller. I'm not convinced it would be useful to many users

Re: [Kicad-developers] Torrents for KiCad distribution

I know that Amazon provides torrent downloads for files in S3, so if we uploaded our files to S3, we could also provide them via torrent. I am not certain this gets us anything though. Adam Wolf On Thu, Feb 23, 2017 at 10:50 AM, Mark Roszko wrote: >>I have no issue with

Re: [Kicad-developers] Torrents for KiCad distribution

>I have no issue with that but there is no way for KiCad to control what is >uploaded to a torrent so I really don't want the project to be responsible for >it The torrent could be autogenerated by the download server when the files are transferred over, the download server would act as the

Re: [Kicad-developers] Optimization flags in 3d-viewer

Hi, On 23.02.2017 16:48, Mário Luzeiro wrote: > Yes I added it, because for 3D we need *speed* :P It's unnecessary though, as cmake defaults to "-O3 -DNDEBUG". So overwriting that will likely enable assertion checks. > What kind of warnings it is causing? O_o MSVC only knows "-O2" as a

Re: [Kicad-developers] Optimization flags in 3d-viewer

Does -O3 really have that much of an improvement though? I assume the only thing cpu bound thing in the 3d viewer is the raytracing. If you really want speed you would throw in PGO :P. ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] Torrents for KiCad distribution

It's not something I think the project should endorse or maintain. If users want to upload packages to torrents, I have no issue with that but there is no way for KiCad to control what is uploaded to a torrent so I really don't want the project to be responsible for it. Does our website not have

Re: [Kicad-developers] Strange COLOR4D::LegacyMix( COLOR4D aColor ) optimization

By the way, thanks for fixing issue with EDA_COLOR_T constructor, I had that fixed locally but for some reason it did not make it in to my patch. Sorry about that. I will have some more time tonight to look at other color issues if you run in to them. If not, I will keep working on GerbView.

Re: [Kicad-developers] Optimization flags in 3d-viewer

Yes I added it, because for 3D we need *speed* :P What kind of warnings it is causing? O_o Mario From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of Simon Richter [simon.rich...@hogyros.de] Sent: 23

Re: [Kicad-developers] Strange COLOR4D::LegacyMix( COLOR4D aColor ) optimization

Hi JP, You could well be right, I did not perform cycle counting on this method, just kept the map lookup because that is what was used before. It would be a better optimization (if one if even needed) to come up with a fast way of hashing a COLOR4D so that it can be used as a key in a key-value

[Kicad-developers] [PATCH] Make COMPILE_FLAGS property set conditional on sane value

If the compiler doesn't support -Wshadow, the variable is empty, leading to a broken declaration. --- pcbnew/CMakeLists.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/pcbnew/CMakeLists.txt b/pcbnew/CMakeLists.txt index 2c22916f0..4535daa1b 100644 ---

[Kicad-developers] Strange COLOR4D::LegacyMix( COLOR4D aColor ) optimization

Hi Jon, When searching a fix to an issue in legacy mode (incorrect calculation of ORed wxColors), I had a look at COLOR4D::LegacyMix( COLOR4D aColor ) and for me the optimization to calculate the mix between 2 wxColors need more calculation than the basic calculation. optimization: normalize

[Kicad-developers] Optimization flags in 3d-viewer

Hi, in 3d-viewer/CMakeLists.txt we have set( CMAKE_C_FLAGS_RELEASE "-O3" ) set( CMAKE_CXX_FLAGS_RELEASE "-O3" ) Is that intentional? - it seems to be unused in the Make based builds - it overwrites any existing flags in these variables - it causes warnings on MSVC Simon

Re: [Kicad-developers] Stable release 4.0.6

2017-02-23 14:35 GMT+01:00 Wayne Stambaugh : > Does the ubuntu package even have the correct docs, translations, and > libraries? AFAIK, some of this has not been committed and tagged yet. > In the future, please hold off making stable packages available until we > have

Re: [Kicad-developers] update on filename fun under Windows

2017-02-23 14:53 GMT+01:00 Wayne Stambaugh : > On 2/22/2017 10:01 PM, Cirilo Bernardo wrote: >> Hi folks, >> >> I was looking into non-ASCII characters in file paths under Windows >> in hopes of at least fixing latent bugs in non-MCAD 3D plugins and >> IDF/VRML exports.

Re: [Kicad-developers] Torrents for KiCad distribution

No plans currently. Do you think enough people would use them for it to really work? On Feb 23, 2017 9:06 AM, "Ingo Kletti" wrote: > Hello, > > currently the stable releases are distributed as direct downloads from > kicad- > pcb.org. Are there any plans for

Re: [Kicad-developers] [PATCH] Fix grid sizes in GAL modedit

Thank you John, your patch has just been committed. Cheers, Orson On 02/23/2017 03:15 PM, John Beard wrote: > Hi, > > The COMMON_TOOLS GAL tool wasn't registered in modedit, so the grid > setting didn't work. > > Here's a patch. This fixes lp:1667264, possibly the tersest bug report > ever,

Re: [Kicad-developers] Stable release 4.0.6

I had assumed it did not. I will investigate before building it myself though. Thanks for the pointer. Adam Wolf On Thu, Feb 23, 2017 at 8:22 AM, Simon Wells wrote: > @adam why do you neeed a libcurl? does 10.7 not come with libcurl? > > On 24 February 2017 at 02:35, Wayne

Re: [Kicad-developers] Stable release 4.0.6

@adam why do you neeed a libcurl? does 10.7 not come with libcurl? On 24 February 2017 at 02:35, Wayne Stambaugh wrote: > Does the ubuntu package even have the correct docs, translations, and > libraries? AFAIK, some of this has not been committed and tagged yet. > In the

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

1.62 works fine here On 24 February 2017 at 02:07, Wayne Stambaugh wrote: > This is a known issue. I believe the last valid version of boost that > doesn't cause a crash is 1.61. Anything after that causes this issue on > all platforms not just osx. @Orson or @Tom, any

[Kicad-developers] [PATCH] Fix grid sizes in GAL modedit

Hi, The COMMON_TOOLS GAL tool wasn't registered in modedit, so the grid setting didn't work. Here's a patch. This fixes lp:1667264, possibly the tersest bug report ever, with a grand total of 6 words and a colon, plus the copy-paste version info. Any bug reporters out there, pretty please use

[Kicad-developers] Torrents for KiCad distribution

Hello, currently the stable releases are distributed as direct downloads from kicad- pcb.org. Are there any plans for distributing the stable releases as torrents? Regards, Ingo -- --- HTWG Konstanz Hochschule Technik,

Re: [Kicad-developers] update on filename fun under Windows

On 2/22/2017 10:01 PM, Cirilo Bernardo wrote: > Hi folks, > > I was looking into non-ASCII characters in file paths under Windows > in hopes of at least fixing latent bugs in non-MCAD 3D plugins and > IDF/VRML exports. Unfortunately the problem has proved much more > difficult than I originally

Re: [Kicad-developers] Coroutines, in general

Hi, For what it's worth, I've been bitten by some changes in boost coroutine(s?)(2) and there are actually two different interfaces (coroutines and coroutines2) and the previous is deprecated. My workaround is to do the following in our project to get something that works both before boost 1.55

Re: [Kicad-developers] Stable release 4.0.6

Does the ubuntu package even have the correct docs, translations, and libraries? AFAIK, some of this has not been committed and tagged yet. In the future, please hold off making stable packages available until we have packages for the three major platforms. I'm ok if some of the more obscure

Re: [Kicad-developers] Stable release 4.0.6

I suspect I will be able to have a release candidate by the end of the weekend, ie 4 days from now. I don't have any way to test if it will work as far back as we claim support for for the 4x line, but I am not certain that is a world-ending problem at this point. (I will be able to confirm it

Re: [Kicad-developers] Coroutines, in general

Fair enough. Has coroutine really been as bad as context though? Seems we've had to resort to using some internal API functions in context, which really seems to be screwing us over.. :P On Thu, Feb 23, 2017 at 02:27:59PM +0100, Tomasz Wlostowski wrote: > On 23.02.2017 14:17, Chris Pavlina wrote:

Re: [Kicad-developers] Stable release 4.0.6

Do you need a project manager ? :D M Trimis de pe iPhone-ul meu Pe 23 feb. 2017, la 15:22, Chris Pavlina a scris: > In the future we should probably look into making our releases a bit > more coordinated. > > https://forum.kicad.info/t/4-0-6-for-ubuntu-is-out/5441 >

Re: [Kicad-developers] Coroutines, in general

On 23.02.2017 14:17, Chris Pavlina wrote: > boost::coroutine? Seems the latter has a much more stable API, is > it missing something we require? Hi Chris, I can't agree that either boost::context or boost::coroutine have stable APIs, that's why have our own wrapper on top... Cheers, Tom

Re: [Kicad-developers] Stable release 4.0.6

In the future we should probably look into making our releases a bit more coordinated. https://forum.kicad.info/t/4-0-6-for-ubuntu-is-out/5441 On Tue, Feb 14, 2017 at 09:26:21AM -0500, Wayne Stambaugh wrote: > Are there any outstanding issues to prevent rolling out a 4.0.6 stable > release? If

Re: [Kicad-developers] Stable release 4.0.6

Sounds like we might need another week before making the release announcement or am I misreading this? On 2/23/2017 8:06 AM, Adam Wolf wrote: > No problem, I am still contemplating how to generate a libcurl that runs > on OS X 10.7 > > Adam Wolf > > On Feb 23, 2017 12:29 AM, "Nick

[Kicad-developers] Coroutines, in general

Hi, Just out of curiosity, I'm not sure what the reasoning is here and nobody on IRC really knew last night --- can anyone explain why we use boost::context with our own coroutine implementation on top, rather than using boost::coroutine? Seems the latter has a much more stable API, is it

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

This is a known issue. I believe the last valid version of boost that doesn't cause a crash is 1.61. Anything after that causes this issue on all platforms not just osx. @Orson or @Tom, any chance you could take a look at this to see what boost changed in the context library? Cheers, Wayne

Re: [Kicad-developers] Stable release 4.0.6

No problem, I am still contemplating how to generate a libcurl that runs on OS X 10.7 Adam Wolf On Feb 23, 2017 12:29 AM, "Nick Østergaard" wrote: The docs are not quite ready yet, there are some things that still needs to be included. Den 23/02/2017 01.56 skrev "Adam

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

Hi Orson, Here's an updated patch with the changes you requested. The only issue is, without some kind of caching, I had to change the call sites that were interested in the board bounding box with edges only, so the patch has grown in scope. Let me know if this looks better. Best, Jon On

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

just fyi https://bugs.launchpad.net/kicad/+bug/1658249 On 24 February 2017 at 00:38, Chris Pavlina wrote: > Backtrace attached. Boost is 1.63.0. > > On Thu, Feb 23, 2017 at 11:36:02AM +0100, Maciej Sumiński wrote: >> Hi Chris, >> >> Would you give more details about the

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

Heh, okay, I should have tested more. Seems GAL is quite completely broken after this patch, do not apply :P On Thu, Feb 23, 2017 at 06:38:39AM -0500, Chris Pavlina wrote: > Backtrace attached. Boost is 1.63.0. > > On Thu, Feb 23, 2017 at 11:36:02AM +0100, Maciej Sumiński wrote: > > Hi Chris, >

[Kicad-developers] Teardrops

Hi all, Few days ago I pushed to YouTube some videos about my teardrops Legacy canvas implementation is full working, maybe too much things. In Gal canvas there are some work to do. Biggest job is going to be in pushed tracks / vias. And router, if it is wanted same kind of WYSIWYG as in Legacy.

Re: [Kicad-developers] {PATCH] Icon tweaks

thanks a lot JP. cheers Fabrizio On Wed, Feb 22, 2017 at 8:58 AM, jp charras wrote: > Le 21/02/2017 à 10:01, Fabrizio Tappero a écrit : > > Hi Guys, > > could we please go ahead and get this: > > https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/icons > >

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

Backtrace attached. Boost is 1.63.0. On Thu, Feb 23, 2017 at 11:36:02AM +0100, Maciej Sumiński wrote: > Hi Chris, > > Would you give more details about the problem? Boost version, backtrace? > > Regards, > Orson > > On 02/23/2017 02:23 AM, Chris Pavlina wrote: > > Hi, > > > > pcbnew is

Re: [Kicad-developers] [PATCH] Change reporter message of footprint missmatch to warning on netlist-import

Hi Marco, Good catch, I have just committed your patch. Thank you for your contribution. Regards, Orson On 02/22/2017 02:30 PM, Marco Sterbik wrote: > Hi, > > this patch just fixes a small thing that may irritate beginners to the > program (at least in a recent training some people were a bit

Re: [Kicad-developers] [PATCH] Fix MacOS coroutine segfault

Hi Chris, Would you give more details about the problem? Boost version, backtrace? Regards, Orson On 02/23/2017 02:23 AM, Chris Pavlina wrote: > Hi, > > pcbnew is segfaulting on launch on my MacOS Sierra build, due to a null > dereference in the coroutine code: > > coroutine.h > 408static

Re: [Kicad-developers] [PATCH] Select filter dialog in GAL

Hi John, I have just pushed the patches, and modified the context menu conditions, so everything should work nicely now. Thank you for your contribution! Cheers, Orson On 02/22/2017 06:53 PM, John Beard wrote: > Hi Orson, > > Yes, I am aware that the existing dialog is not very advanced, but

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

Hi Jon, I really like the generic approach in the zoom methods. This part I would merge instantly, but there is an issue with caching the board bounding box. It does not take into account that items already added to board may change their position and affect the bounding box. I would remove

Re: [Kicad-developers] [PATCH] Update tool framework documention

Hi John, I planned to do this, but your changes are even better than what I had in mind. Thank you, your patch is already pushed with a few minor modifications in a separate commit. Cheers, Orson On 02/23/2017 04:51 AM, John Beard wrote: > Hi, > > In light of recent changes to the tool