Re: [Kicad-developers] [PATCH] Eeschema automatic manage junctions

On 2017-11-02 06:31 PM, Seth Hillbrand wrote: Please let me know if there are any additional issues or suggestions for improvement. How difficult would it be to have junctions draw last on schematics? There is a minor negative visual effect when you have a component with one end joined to a

Re: [Kicad-developers] KiCad Library Download Page

Yeah I've got some formatting to do. I will put all the symbol info into a table. On Fri, Nov 3, 2017 at 12:24 PM, Wayne Stambaugh wrote: > Oliver, > > Nice! My only suggestion is that the line spacing and text seem a bit > large. For libraries with a lot of symbols, you

Re: [Kicad-developers] KiCad Library Download Page

Oliver, Nice! My only suggestion is that the line spacing and text seem a bit large. For libraries with a lot of symbols, you have to scroll down too much. Thanks, Wayne On 11/2/2017 8:31 PM, Oliver Walters wrote: > Hi all, > > Stage 2 of ? of the library update project is underway. > >

[Kicad-developers] KiCad Library Download Page

Hi all, Stage 2 of ? of the library update project is underway. Idea: A downloads page for the libraries that presents individual libraries for download, and users can preview the data available in the libraries. This is auto-built based on the latest library data. Preview:

Re: [Kicad-developers] Update of KiCad documentation?

No one is going to argue that our documentation could be improved. I'm not really sure what the best approach would be to do that. I would prefer that we work with the tools and infrastructure we already have in place rather than create a new dependency if at all possible. What about creating a

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

Tom, I fine with all of this except the boost option change. Copying the boost files into the KiCad source is not really removing boost. Why not just create a simple header that includes the boost option header and your OPT() macro. Wouldn't this work just as well when we transition to C++17?

Re: [Kicad-developers] [PATCH] Eeschema automatic manage junctions

Hi All- Attached is an updated patchset for this feature, rebased to current master. This should resolve the issues that Nick and Michael reported as well as update to handle imported Eagle schematics. Please let me know if there are any additional issues or suggestions for improvement.

[Kicad-developers] [PATCH 06/12] Remove unused #define

--- eeschema/sch_screen.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index 02f2030d1..50d921b2d 100644 --- a/eeschema/sch_screen.cpp +++ b/eeschema/sch_screen.cpp @@ -66,9 +66,6 @@ static double SchematicZoomList[] = 13.0, 16.0,

[Kicad-developers] [PATCH 03/12] build: Remove dead code

--- CMakeLists.txt | 8 1 file changed, 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 54d477e22..3a8ee4518 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -693,14 +693,6 @@ if( KICAD_SCRIPTING OR KICAD_SCRIPTING_MODULES ) endif() -if( EXISTS

[Kicad-developers] [PATCH 02/12] build: Use CMAKE_INSTALL_DATADIR

--- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5d01d6577..54d477e22 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -380,9 +380,9 @@ if( NOT APPLE ) CACHE PATH "Location of KiCad user-loaded

[Kicad-developers] [PATCH 04/12] build: Don't install *.bat scripts on Unix

--- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3a8ee4518..efd02e103 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -774,6 +774,7 @@ if( UNIX ) install( DIRECTORY scripts DESTINATION ${KICAD_DOCS} COMPONENT

[Kicad-developers] [PATCH 08/12] Remove orphaned code files

--- common/wxunittext.cpp | 142 - include/wxunittext.h | 144 -- 2 files changed, 286 deletions(-) delete mode 100644 common/wxunittext.cpp delete mode 100644 include/wxunittext.h diff --git

[Kicad-developers] [PATCH 07/12] Remove some dead code

--- eeschema/sch_item_struct.cpp | 7 --- eeschema/sch_item_struct.h | 4 2 files changed, 11 deletions(-) diff --git a/eeschema/sch_item_struct.cpp b/eeschema/sch_item_struct.cpp index 6e4f98c8d..873a8921a 100644 --- a/eeschema/sch_item_struct.cpp +++ b/eeschema/sch_item_struct.cpp

[Kicad-developers] [PATCH 10/12] Remove duplicate #include

--- common/class_undoredo_container.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/common/class_undoredo_container.cpp b/common/class_undoredo_container.cpp index ada087480..88eec3001 100644 --- a/common/class_undoredo_container.cpp +++ b/common/class_undoredo_container.cpp @@ -25,8

[Kicad-developers] [PATCH 11/12] Remove some else-after-return's

--- common/class_undoredo_container.cpp | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/common/class_undoredo_container.cpp b/common/class_undoredo_container.cpp index 88eec3001..e3f974eb3 100644 ---

[Kicad-developers] [PATCH 12/12] Use std::remove_pointer instead of own implementation (NFC)

--- include/core/typeinfo.h | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/include/core/typeinfo.h b/include/core/typeinfo.h index 34c3324e6..537171348 100644 --- a/include/core/typeinfo.h +++ b/include/core/typeinfo.h @@ -28,19 +28,7 @@ #ifndef

[Kicad-developers] [PATCH 09/12] Remove some extra semicolons

--- 3d-viewer/3d_cache/dialogs/3d_cache_dialogs.h | 2 +- 3d-viewer/3d_cache/sg/sg_helpers.cpp| 2 +- 3d-viewer/3d_cache/sg/sg_helpers.h | 2 +- 3d-viewer/3d_cache/sg/sg_node.h | 2 +- 3d-viewer/3d_cache/str_rsort.h | 2 +-

[Kicad-developers] [PATCH 05/12] Fix a typo

--- gerbview/class_gerbview_layer_widget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gerbview/class_gerbview_layer_widget.cpp b/gerbview/class_gerbview_layer_widget.cpp index 6e9b8e312..498dac397 100644 --- a/gerbview/class_gerbview_layer_widget.cpp +++

[Kicad-developers] [PATCH 01/12] build: Don't install INSTALL.txt

--- CMakeLists.txt | 4 1 file changed, 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9405416a3..5d01d6577 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -775,10 +775,6 @@ add_custom_target( uninstall # Installation

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

Hi Tom, On 02.11.2017 18:16, Tomasz Wlostowski wrote: > Thanks for testing. Could you try applying the attached patch? Works if scripting is disabled. What is the sanest way to run all tests (so this can be integrated into the nightly and patch builds)? Simon signature.asc Description:

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

On 02/11/17 18:10, Simon Richter wrote: > Hi, > > On 02.11.2017 17:20, Simon Richter wrote: > >> I've tried an msys2 build[1], and the qa project failed due to a missing >> config.h. Did you forget to check it in, or is there a dependency >> missing (I've built with -j40)? > > FWIW, same error

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

Hi, On 02.11.2017 17:20, Simon Richter wrote: > I've tried an msys2 build[1], and the qa project failed due to a missing > config.h. Did you forget to check it in, or is there a dependency > missing (I've built with -j40)? FWIW, same error on Linux with -j8. Simon signature.asc

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

Hi, On 02.11.2017 17:32, Clemens Koller wrote: >> [1] http://kiwi.hogyros.de:8080/job/windows-kicad-msys2-patch/15/console > from [1]: > [...] > 17:08:24 error: git apply: bad git-diff - inconsistent old filename on line > 305 > 17:08:24 + RES=128 > 17:08:24 + echo ' Patch exit: 128' >

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

Hi, Simon! On 2017-11-02 17:20, Simon Richter wrote: > [1] http://kiwi.hogyros.de:8080/job/windows-kicad-msys2-patch/15/console from [1]: [...] 17:08:24 error: git apply: bad git-diff - inconsistent old filename on line 305 17:08:24 + RES=128 17:08:24 + echo ' Patch exit: 128' 17:08:24

Re: [Kicad-developers] [RFC] pcbnew internals refactoring for testing

Hi Tom, On 01.11.2017 23:58, Tomasz Wlostowski wrote: > Here's a patch set [1] that refactors some internal PCBnew stuff (mostly > GAL & tool framework related), focusing on testability. The goal is to > be able to use the BOARD class, GAL view and tools without the > GUI-related code for the

[Kicad-developers] Oval Pads in Zones

Hello, I filed a bug [1] a while ago pertaining to oval pads in zones leading to clearance violation in the Gerber output. I've tested the current master revision (e5c4cfc3b01724de705609c901575b40cd3958b4) and it still seems to be an issue. I'd appreciate it if someone took a look, as it is

Re: [Kicad-developers] Update of KiCad documentation?

We used to have an ether pad on pads.kicad-pcb.org where I collected notes on new features and changes for 5.0.0. But this is down, and Ajo who runs it has been unresponsive for quite some time. I was intending to start a news post on the website to collect it, but I didn't manage to do this in

Re: [Kicad-developers] Update of KiCad documentation?

Am 01.11.2017 um 16:20 schrieb Marco Ciampa: > This is my suggestion: > > Dev programmers whose group of patches were made accepted in the master > tree should at least write a line in the (now inexistent) NEWS file. That's the way it's typically working. And looking at workflows and methods of