Re: [Kicad-developers] wxGrid boolean changes

Hi Jeff, This version works great in the library tables, but breaks the footprint wizard table (it's no longer possible to check/uncheck booleans using mouse or keyboard). Unfortunately I don't have time to debug tonight, but can try tomorrow unless you have an idea of what is wrong. By the way,

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

2018-03-22 1:02 GMT+02:00 Seth Hillbrand : > With the patch, the state became that you had a valid board but could no > longer delete or edit the module. > I repeat: this state doesn't come with the patch. It exists already. Without the patch you will have a pad like

Re: [Kicad-developers] Feedback on 6.0 work

Good point. I think that *is* the plan as far as I understand it. > On 21 Mar 2018, at 23:43, Jon Evans wrote: > > I actually thing that's a reasonable thing to think about supporting. > > On Wed, Mar 21, 2018, 19:38 Russell Oliver

Re: [Kicad-developers] Feedback on 6.0 work

I actually thing that's a reasonable thing to think about supporting. On Wed, Mar 21, 2018, 19:38 Russell Oliver wrote: > Yes, I guess so, unless there is a plan with the new schematic format to > allow "unique/independent" symbols that include modifications from the >

Re: [Kicad-developers] Feedback on 6.0 work

Yes, I guess so, unless there is a plan with the new schematic format to allow "unique/independent" symbols that include modifications from the library symbol, that are only stored in the schematic. On Thu, 22 Mar 2018 10:18 Jeff Young, wrote: > In the Mod-Edit version only,

Re: [Kicad-developers] wxGrid boolean changes

OK, guys, here’s a modified-Jon-solution in GRID_TRICKS. Note that I can’t seem to build with Python on my Mac so the Footprint Wizard is totally untested (although it has, in theory, been updated to use GRID_TRICKS). Please let me know how it looks…. Cheers, Jeff.

Re: [Kicad-developers] Feedback on 6.0 work

In the Mod-Edit version only, right? I don’t think we allow editing of pins at all in the schematic, do we? > On 21 Mar 2018, at 21:48, Russell Oliver wrote: > > Just thinking that another tab showing the list of pins and their properties > would be a good addition to

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Hi Eeli- My comment above was to note that previously, we could get into a state where you needed to delete the module to get back to a valid board. With the patch, the state became that you had a valid board but could no longer delete or edit the module. This is what I meant by solving one

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

2018-03-21 20:16 GMT+02:00 Wayne Stambaugh : > Sounds reasonable. If I'm reading the comments correctly, I don't like > the idea that the current proposed patch leaves footprints in a state > where they cannot be selected and edited. I'm sure that will quickly > produce

Re: [Kicad-developers] wxGrid boolean changes

My change was in GRID_TRICKS, but doesn’t work very well. Jon’s was only in the Footprint Wizard, but seems to work better. I’m currently moving Jon’s to GRID_TRICKS. > On 21 Mar 2018, at 21:48, Wayne Stambaugh wrote: > > Does the footprint wizard use GRID_TRICKS? In

Re: [Kicad-developers] wxGrid boolean changes

Does the footprint wizard use GRID_TRICKS? In either case, we should roll these changes into GRID_TRICKS so it can be used everywhere we us boolean checkboxes in wxGrid. On 03/21/2018 05:38 PM, Jon Evans wrote: It's already committed, if you use the footprint wizard, any of the boolean

Re: [Kicad-developers] Feedback on 6.0 work

Just thinking that another tab showing the list of pins and their properties would be a good addition to this also. If you can copy and paste into the grid On Wed, 21 Mar 2018 23:34 Wayne Stambaugh, wrote: > Jeff, > > Looks good to me. I prefer the in place editing so go

Re: [Kicad-developers] wxGrid boolean changes

It's already committed, if you use the footprint wizard, any of the boolean values in the parameters table use the new behavior On Wed, Mar 21, 2018 at 5:31 PM, Wayne Stambaugh wrote: > Jeff, > > I don't remember the outcome testing Jon's patch. That was a few weeks > ago

Re: [Kicad-developers] [PATCH] Fixes in GAL selection filter

I went ahead and merged these. Thanks! On Sun, Mar 18, 2018 at 12:10 PM, Jeff Young wrote: > I’ve always considered a jagged feature envelope a design bug. I’d > support adding the via checkbox. > > Cheers, > Jeff. > > > On 18 Mar 2018, at 15:31, Jon Evans

Re: [Kicad-developers] wxGrid boolean changes

Jeff, I don't remember the outcome testing Jon's patch. That was a few weeks ago so my old man memory is at work here. I don't have that patch any longer so if Jon reposts it, I will test it on windows. Cheers, Wayne On 03/21/2018 05:07 PM, Jeff Young wrote: Hi Wayne, That sounds

Re: [Kicad-developers] wxGrid boolean changes

Cool; I’ll stick it into GRID_TRICKS and test it on Mac. > On 21 Mar 2018, at 21:15, Jon Evans wrote: > > I tested my change (to the footprint wizard parameters table) on Windows and > didn't see any bad behavior. > > On Wed, Mar 21, 2018 at 5:07 PM, Jeff Young

Re: [Kicad-developers] wxGrid boolean changes

I tested my change (to the footprint wizard parameters table) on Windows and didn't see any bad behavior. On Wed, Mar 21, 2018 at 5:07 PM, Jeff Young wrote: > Hi Wayne, > > That sounds pretty similar to the bad behaviour I was trying to fix on > Linux, so I’m guessing it’ll be

Re: [Kicad-developers] wxGrid boolean changes

Hi Wayne, That sounds pretty similar to the bad behaviour I was trying to fix on Linux, so I’m guessing it’ll be the same. The native control on Mac does a fade-in when checked or unchecked, which I was trying to retain. But it looks like we’ll have to go with something more like Jon’s idea

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Sounds reasonable. If I'm reading the comments correctly, I don't like the idea that the current proposed patch leaves footprints in a state where they cannot be selected and edited. I'm sure that will quickly produce another but report. On 3/21/2018 1:36 PM, Seth Hillbrand wrote: > Hi Wayne- >

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Hi Wayne- Perhaps there should be a clear limit to layers that remove full footprints. Maybe only copper layers? Otherwise, a user accidentally removing F.Mask removes most of their footprints. Warning or not, that seems extreme. -S 2018-03-21 9:46 GMT-07:00 Wayne Stambaugh

Re: [Kicad-developers] [RFC] Experimental grid pattern in zone fill

JP, Nice! The smoothing works as expected. This will make a nice addition to v6. You might want to fix the file format token and source code method name spelling errors before you merge this (smooting -> smoothing). I also didn't see where you bumped the board file format but I may have

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

JP, Did you take a look at this patch? I know we have talked about this in the past and that the fix would not be easy. Until we can define and implement a complete solution, this could be a short term fix. When you get a chance, please take a look at it an comment on it. hauptmech, I'm not

Re: [Kicad-developers] wxGrid boolean changes

Jeff, This doesn't work on windows. The first click works as expected where is selects the row and checks the checkbox. The subsequent click selects the row and the next click behaves like two consecutive clicks which leave the checkbox in it's original state. I will try to test this on linux

Re: [Kicad-developers] [PATCH] DRC: Add an optional mode to report all track errors

Ah! That would explain the apply issue ;) On 3/21/2018 11:12 AM, Jon Evans wrote: > I already pushed it.  Let me know if you have concerns with it and I can > make changes accordingly. > > -Jon > > On Wed, Mar 21, 2018 at 11:00 AM, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] DRC: Add an optional mode to report all track errors

I already pushed it. Let me know if you have concerns with it and I can make changes accordingly. -Jon On Wed, Mar 21, 2018 at 11:00 AM, Wayne Stambaugh wrote: > Jon, > > This patch is not applying cleaning. Please rebase and resubmit it so I > can test it. I fine with

Re: [Kicad-developers] [PATCH] Add/modify python APIs for querying available pcbnew footprints

Miles, Please configure your editor to remove tailing white space and follow the kicad coding policy for formatting the c++ code. You have mixed the footprint enumeration of symbol library table entries and the io plugin which is confusing. These enumerations have separate intentions and should

Re: [Kicad-developers] [PATCH] DRC: Add an optional mode to report all track errors

Jon, This patch is not applying cleaning. Please rebase and resubmit it so I can test it. I fine with the idea even if there is a performance hit. Cheers, Wayne On 3/19/2018 10:58 PM, Jon Evans wrote: > I'd like some eyes on this before I push it, since it's a rather > significant change. >

Re: [Kicad-developers] wxGrid boolean changes

Oops, scratch that last one (it doesn’t even compile).Let’s try again: 0003-Don-t-make-users-click-twice-to-toggle-a-wxGrid-chec.patch Description: Binary data On 21 Mar 2018, at 10:59, Jeff Young wrote:Hi Jon,Could you try this one out on Linux?  (It should be active for the

Re: [Kicad-developers] CvPcb Save

I'm fine with getting rid of the save and updating the schematic footprint fields when closing cvpcb. Most of this is historical baggage from when cvpcb was a stand alone app and required intermediate files for assigning footprints. On 3/21/2018 9:41 AM, Jeff Young wrote: > But what’s the point

Re: [Kicad-developers] CvPcb Save

But what’s the point of having ctrl-S at all if it just moves it to some other place in volatile memory? The user might as well just wait until they close CvPcb, as volatile is volatile, no? > On 21 Mar 2018, at 12:47, Wayne Stambaugh wrote: > > A possible short term

Re: [Kicad-developers] small contrib to the website

Marco, Please submit a pull request against the kicad website repo[1] on github. Thanks, Wayne [1]: https://github.com/KiCad/kicad-website On 3/21/2018 8:45 AM, Marco Ciampa wrote: > Hello devs! > here is a small contrib to the website... > > Is it ok to send it as a patch or do you prefer a

Re: [Kicad-developers] small contrib to the website

Changes to the website are preferably made as pull requests on https://github.com/KiCad/kicad-website It makes it easier to handle when I am not at my dev host. 2018-03-21 13:45 GMT+01:00 Marco Ciampa : > Hello devs! > here is a small contrib to the website... > > Is it ok

Re: [Kicad-developers] CvPcb Save

A possible short term fix is to change the action from save to update schematic which is what really happens and is more analogous to clicking the OK button in a modal dialog. I don't know if saving the schematic from CvPcb makes a lot of sense. I would keep the ctrl+s shortcut. Changing this

[Kicad-developers] small contrib to the website

Hello devs! here is a small contrib to the website... Is it ok to send it as a patch or do you prefer a pull request on git-hub? TIA -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364

Re: [Kicad-developers] Feedback on 6.0 work

Jeff, Looks good to me. I prefer the in place editing so go ahead and apply this where it makes sense. I don't like the bare bones properties either. If wxGrid provides a simple way to hide them, let the user decide which properties to show and/or hide. There may be use cases where the user

Re: [Kicad-developers] wxGrid boolean changes

Hi Jon,Could you try this one out on Linux?  (It should be active for the library tables, but not the footprint wizard.)Thanks,Jeff. 0003-Don-t-make-users-click-twice-to-toggle-a-wxGrid-chec.patch Description: Binary data On 20 Mar 2018, at 13:49, Jon Evans wrote:I haven't

Re: [Kicad-developers] [PATCH] DRC: Add an optional mode to report all track errors

So do we really need the checkbox then? > On 21 Mar 2018, at 00:38, Jon Evans wrote: > > Stacking up the BOARD_COMMITs was most of the problem. Thanks for the tip, > Seth! > > On Tue, Mar 20, 2018 at 9:52 AM, Jon Evans >