Re: [Kicad-developers] Debian and Ubuntu packaging.

2016-05-05 Thread Simon Richter
On 02.05.2016 21:44, Chris Pavlina wrote: > Perhaps we could provide our own Debian and Ubuntu packages, like the Ubuntu > nightly PPA. That still wouldn't be legal, though -- the OpenSSL licence is incompatible with the GPL, and the result is undistributable, so any time the KiCad project ships

Re: [Kicad-developers] [RFC] On net ties, microwave tools & custom pad shapes, altogether.

2016-05-05 Thread Simon Richter
Hi, On 03.05.2016 14:40, Tomasz Wlostowski wrote: > - net_tie: DRC treats the primitive as non-conducting and doesn't throw > a short circuit error (see drawing A) That requires the net tie to have a size that is at least larger than the minimum clearance of any of the netclasses involved. My

[Kicad-developers] [PATCH] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets

2016-05-04 Thread Simon Richter
This function is unused, and looks similar to the tree builder above, so it might likely be left over from a refactoring effort. --- .../netlist_exporters/netlist_exporter_generic.cpp | 73 -- .../netlist_exporters/netlist_exporter_generic.h | 7 --- 2 files changed, 80

[Kicad-developers] [PATCH 2/4] Don't clear compiler flags in 3d_cache directory

2016-05-01 Thread Simon Richter
--- 3d-viewer/3d_cache/CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/3d-viewer/3d_cache/CMakeLists.txt b/3d-viewer/3d_cache/CMakeLists.txt index 82ed6de..cc06e9d 100644 --- a/3d-viewer/3d_cache/CMakeLists.txt +++ b/3d-viewer/3d_cache/CMakeLists.txt @@ -1,3 +1 @@ -# unset

[Kicad-developers] [PATCH 1/4] Warn about missing override specifiers, if supported (gcc 5.1, clang 3.5)

2016-05-01 Thread Simon Richter
--- CMakeLists.txt | 12 1 file changed, 12 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index f077de3..130b1cc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -152,6 +152,18 @@ if( CMAKE_VERSION VERSION_LESS 3.1 AND ( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_C

[Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

2016-05-01 Thread Simon Richter
l overriding methods Simon Simon Richter (4): Warn about missing override specifiers, if supported (gcc 5.1, clang 3.5) Don't clear compiler flags in 3d_cache directory Add "virtual" keyword on implicitly virtual methods Add C++11 "override" specifie

[Kicad-developers] [PATCH 3/3] Replace last instance of boost::shared_array

2016-04-30 Thread Simon Richter
This is a bit tricky, because the smart pointer is actually used only for delayed deletion, and no users of the object are involved. This code could probably be replaced with a pool allocator that flushes the entire pool after rendering is complete, to improve performance. ---

[Kicad-developers] [PATCH 2/3] Replace unshared boost::shared_array with std::unique_ptr

2016-04-30 Thread Simon Richter
These are never shared, so std::unique_ptr works fine. --- common/gal/opengl/opengl_gal.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/gal/opengl/opengl_gal.cpp b/common/gal/opengl/opengl_gal.cpp index 4325fe7..330e390 100644 ---

[Kicad-developers] [PATCH 1/3] Replace boost::shared_ptr with std::shared_ptr

2016-04-30 Thread Simon Richter
--- 3d-viewer/3d_mesh_model.h | 4 ++-- common/gal/opengl/opengl_gal.cpp | 2 +- common/geometry/hetriang.cpp | 34 +- eeschema/class_libentry.h | 7 +++ eeschema/sch_component.h | 5 ++---

[Kicad-developers] [PATCH 0/3] Deboostify shared_ptr

2016-04-30 Thread Simon Richter
(so std::unique_ptr has the correct semantics), and one is used in place of a more sensible allocator. Simon Simon Richter (3): Replace boost::shared_ptr with std::shared_ptr Replace unshared boost::shared_array with std::unique_ptr Replace last instance of boost::shared_array 3d

Re: [Kicad-developers] Optimization

2016-04-28 Thread Simon Richter
Hi, On 27.04.2016 08:42, Lorenzo Marcantonio wrote: > First guess is that in modern CPUs pipelining, branch prediction and > cache locality have a bigger effect than raw computation. FWIW, the fully optimized code even has the compiler replacing the separate sin() and cos() invocations by a

[Kicad-developers] [PATCH v2] Make EDA_ITEM::Clone() abstract

2016-04-26 Thread Simon Richter
--- 3d-viewer/3d_material.h| 3 +++ 3d-viewer/3d_struct.h | 2 ++ common/base_struct.cpp | 7 --- eeschema/class_libentry.h | 6 ++ eeschema/class_sch_screen.h| 3 +++ gerbview/class_gbr_screen.h

Re: [Kicad-developers] Net Ties

2016-04-22 Thread Simon Richter
On 22.04.2016 15:23, Tomasz Wlostowski wrote: > IMHO it can be done without any changes on the eeschema side by adding a > special component to the standard library (just like GND/power ports). Yes, but that'd feel like more of a hack. > PCBnew could interpret it as a zero-sized copper pad.

Re: [Kicad-developers] Net Ties

2016-04-22 Thread Simon Richter
Hi Wayne, On 22.04.2016 15:04, Wayne Stambaugh wrote: >> I've added UI[1] and save support in eeschema already, still needs >> mapping to the netlist and pcbnew support. > Are you aware that changes to the current schematic file format are > forbidden until we (I) finish implementing the new

Re: [Kicad-developers] Net Ties

2016-04-22 Thread Simon Richter
Hi, On 22.04.2016 22:28, Jean-Paul Louis wrote: > Please give us an example where you would need to connect more than 2 nets. You can also use net ties to help with the layout of star topologies, length controlled splits and decoupling capacitors. Star Topologies: Connect the diode and

Re: [Kicad-developers] [PATCH] Make EDA_ITEM::Clone() abstract

2016-04-20 Thread Simon Richter
Hi, On 20.04.2016 22:15, Mark Roszko wrote: > Since we have C++11 now...why not use the override specifier? :D We still have to make it abstract though if we want to be told off when we forget to implement it. Simon signature.asc Description: OpenPGP digital signature

[Kicad-developers] Net Ties

2016-04-20 Thread Simon Richter
Hi, as wxWidgets is getting on my nerves with editing widgets in the pin table not rendering properly, I've started on support for net ties. In the current iteration, they would be placed the same way as junctions. Rules: - Any wire or pin connected to a net tie is in a separate net (unless

[Kicad-developers] [PATCH] Make EDA_ITEM::Clone() abstract

2016-04-20 Thread Simon Richter
Make this function abstract in the base, and provide private functions emitting error messages in all types that are actually instantiated. --- 3d-viewer/3d_material.h| 3 +++ 3d-viewer/3d_struct.h | 2 ++ common/base_struct.cpp | 7

Re: [Kicad-developers] Bitmap fonts

2016-04-14 Thread Simon Richter
Hi, On 14.04.2016 20:27, Vesa Solonen wrote: > Orson, please have a look how rendering is done on gEDA gschem. IIRC > font rendering is by Peter Clifton and he went on to optimize stroke > (pixel)grid fitting, etc. The actual renderer is Cairo, but could we use > Cairo to make the font textures

Re: [Kicad-developers] Bitmap fonts

2016-04-14 Thread Simon Richter
Hi, On 14.04.2016 11:33, Maciej SumiƄski wrote: > Currently, the most expensive thing to draw is stroked text, as there > are lots of labels on tracks and pads. To reduce the drawing cost (and > memory requirements), texts that are not targeted to Gerber files (i.e. > pad & track labels) might

Re: [Kicad-developers] dyn_cast

2016-04-13 Thread Simon Richter
Hi, On 13.04.2016 18:13, Chris Pavlina wrote: > What is the purpose of dyn_cast<> in include/core/typeinfo.h? Why don't we > just > use dynamic_cast<>? And can we either replace the former with the latter, or > add a comment to the former explaining its purpose? It uses the parallel type

Re: [Kicad-developers] 3D file relative paths

2016-04-13 Thread Simon Richter
Hi, On 13.04.2016 02:40, David Godfrey wrote: > The use of Env Vars is the only sensible and portable method that can be > used. From a distribution point of view: this is unusable. We need to ship something that can be started from a desktop icon, without extra setup, and users need to be able

[Kicad-developers] 3D merge: new warnings

2016-04-06 Thread Simon Richter
Hi, first Jenkins builds after the merge went through, we have a few new warnings. The msys build is rather silent[1]: ogl_legacy_utils.cpp:209 variable 'end' set but not used [-Wunused-but-set-variable] The MSVC build has a few more new warnings[2], sorted by category here: vrml.cpp:185

[Kicad-developers] [PATCH 0/2] Two small portability patches

2016-04-06 Thread Simon Richter
Hi, these should be fairly obvious: - all Windows platforms use declspec(dllexport) - MSVC does not set a symbol called "MSVC" - use wxFileName to access the FS rather than POSIX Simon Simon Richter (2): Fix condition for Windows-style DLL export Make file test more por

[Kicad-developers] [PATCH 1/2] Fix condition for Windows-style DLL export

2016-04-06 Thread Simon Richter
--- include/plugins/3dapi/ifsg_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/plugins/3dapi/ifsg_defs.h b/include/plugins/3dapi/ifsg_defs.h index 0523bf1..d0fd56d 100644 --- a/include/plugins/3dapi/ifsg_defs.h +++ b/include/plugins/3dapi/ifsg_defs.h @@ -31,7

Re: [Kicad-developers] [PATCH] Enable C++11

2016-04-05 Thread Simon Richter
Hi, On 06.04.2016 05:19, Simon Richter wrote: > This enables C++11 support, if either CMake is sufficiently new to have > this feature built in, or the compiler is supported by the workaround code > (gcc or clang). Meh, that patch was still in the temp dir where I stage mails befor

[Kicad-developers] [PATCH] Drop dependency on

2016-04-05 Thread Simon Richter
This appears to be unused. --- include/plugins/3dapi/xv3d_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/plugins/3dapi/xv3d_types.h b/include/plugins/3dapi/xv3d_types.h index 630d057..43222d6 100644 --- a/include/plugins/3dapi/xv3d_types.h +++

[Kicad-developers] [PATCH] Enable C++11

2016-04-05 Thread Simon Richter
This enables C++11 support, if either CMake is sufficiently new to have this feature built in, or the compiler is supported by the workaround code (gcc or clang). --- CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index

[Kicad-developers] [PATCH] Drop dependency on mm_malloc.h

2016-04-05 Thread Simon Richter
Hi, apparently, the only mention of the string "mm_malloc" in the entire codebase is this include, so there should be no ill effects from dropping it. Simon Simon Richter (1): Drop dependency on include/plugins/3dapi/xv3d_types.h | 1 - 1 file changed, 1 deletion(-)

Re: [Kicad-developers] [PATCH] Enable C++11

2016-03-19 Thread Simon Richter
Hi Wayne, On 17.03.2016 20:35, Wayne Stambaugh wrote: > @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and > clang instead of the -gnu-c++11. This seems to be an issue that should > be addressed. Maybe this is what is breaking @Mark's builds. I would > feel more comfortable

Re: [Kicad-developers] [PATCH] Enable C++11

2016-03-12 Thread Simon Richter
Hi, On 12.03.2016 18:04, Mark Roszko wrote: > But o well, screw it, undoubtedly someone will get the issue > eventually later but screw wasting time finding what it was. Agreed. One thing we should look into though is actually getting Ubuntu bug reports. I know that there are several people

Re: [Kicad-developers] [PATCH] Enable C++11

2016-03-11 Thread Simon Richter
Hi, On 11.03.2016 17:48, Wayne Stambaugh wrote: > It still sounds to me that boost needs to be bumped to 1.55 and possibly > some definitions need to added to the build configuration for Boost to > build properly. Hm, compiling worked for me with Boost 1.55 on Debian with no further changes.

[Kicad-developers] [PATCH] Enable C++11

2016-03-09 Thread Simon Richter
This enables C++11 support, if either CMake is sufficiently new to have this feature built in, or the compiler is supported by the workaround code (gcc or clang). --- CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index

[Kicad-developers] C++11 support

2016-03-09 Thread Simon Richter
Hi, after all the C++11 discussion, here is a patch to use C++11 as default, tested on Linux and MSYS2. Simon Simon Richter (1): Enable C++11 CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) -- 2.1.4 ___ Mailing

Re: [Kicad-developers] [PATCH 3/8] Use PATH to search for shared libraries on Windows

2016-03-01 Thread Simon Richter
Hi, On 01.03.2016 16:58, jp charras wrote: > I do no see what issue patch 1 fixes. That is one half of the things I did -- the Windows API offers InterlockedIncrement and InterlockedDecrement only for unsigned types, while gcc's intrinsic is overloaded, so I had to change that in a common

[Kicad-developers] [PATCH] Make sure KIFACE_GETTER linkage is consistent

2016-02-27 Thread Simon Richter
This makes sure that the declaration is always the same within a single module, so all users have the same idea of whether the symbol is imported. In all dynamically linked objects, all users should be aware that the symbol is imported, while in the statically linked bitmap2component program, no

[Kicad-developers] [PATCH 6/8] Use ptrdiff_t in potrace instead of ssize_t

2016-02-26 Thread Simon Richter
This is backported from potrace 1.13. --- potrace/bitmap.h| 15 --- potrace/greymap.cpp | 2 +- potrace/greymap.h | 3 ++- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/potrace/bitmap.h b/potrace/bitmap.h index 605aa31..059fb2b 100644 --- a/potrace/bitmap.h

[Kicad-developers] [PATCH 5/8] Open namespace around definitions

2016-02-26 Thread Simon Richter
While defining functions in another namespace is technically allowed as long as the definition can be matched to a declaration, this can lead to ambiguous resolutions, such as here (GAL vs KIGFX). --- pcbnew/ratsnest_viewitem.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[Kicad-developers] [PATCH 7/8] Avoid C99 style compound statement

2016-02-26 Thread Simon Richter
Support for C99 in C++ programs is a gcc extension. --- eeschema/autoplace_fields.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/eeschema/autoplace_fields.cpp b/eeschema/autoplace_fields.cpp index 4d97cd8..07c1002 100644 --- a/eeschema/autoplace_fields.cpp +++

[Kicad-developers] [PATCH 8/8] Avoid conflicting declaration for Pgm()

2016-02-26 Thread Simon Richter
This function has two conflicting definitions in the "kicad" executable and the other wrapper programs. As the kifaces can be loaded from either, this silently assumes compatible data layout for the PGM_KICAD and PGM_BASE types when passed by reference, which is valid only when the compiler is

[Kicad-developers] [PATCH 3/8] Use PATH to search for shared libraries on Windows

2016-02-26 Thread Simon Richter
This is appropriate for all Windows targets, not just MSYS. --- include/kiway.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/kiway.h b/include/kiway.h index 406ab91..347c0bb 100644 --- a/include/kiway.h +++ b/include/kiway.h @@ -118,8 +118,10 @@ as such! As

[Kicad-developers] [PATCH 2/8] Use Windows-style DLL import/export for all Windows compilers

2016-02-26 Thread Simon Richter
This should be used whenever Windows is targetted, not just for MSYS. --- include/import_export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/import_export.h b/include/import_export.h index c31729e..672709f 100644 --- a/include/import_export.h +++

[Kicad-developers] [PATCH 4/8] Add missing C++ stdlib headers

2016-02-26 Thread Simon Richter
The GCC standard library headers often include other headers, which makes some code compile that forgets to include several headers. --- common/gal/graphics_abstraction_layer.cpp | 2 ++ common/grid_tricks.cpp | 2 ++ common/selcolor.cpp|

[Kicad-developers] [PATCH 1/8] Make locale init counter unsigned

2016-02-26 Thread Simon Richter
This counts initializations of the locale subsystem, there is no real good reason why this should be a signed variable. --- common/common.cpp | 2 +- include/common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/common.cpp b/common/common.cpp index

[Kicad-developers] [PATCH 3/5] Refactor ELECTRICAL_PINTYPE

2016-02-26 Thread Simon Richter
nList( LIB_PIN::GetOrientationNames(), LIB_PIN::GetOrientationSymbols() ); dlg.SetOrientation( LIB_PIN::GetOrientationCodeIndex( pin->GetOrientation() ) ); dlg.SetStyle( pin->GetShape() ); -dlg.SetElectricalTypeList( LIB_PIN::GetElectricalTypeNames(), -

[Kicad-developers] [PATCH 4/5] Use TypeSheetLabel enum where appropriate

2016-02-26 Thread Simon Richter
--- eeschema/dialogs/dialog_edit_label.cpp | 3 ++- eeschema/dialogs/dialog_sch_edit_sheet_pin.h | 8 ++-- eeschema/edit_label.cpp | 8 eeschema/sch_sheet_pin.cpp | 2 +- eeschema/sch_text.cpp| 4 ++--

[Kicad-developers] [PATCH 5/5] Add icon to pin type column

2016-02-26 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 51 -- 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index 369a227..047f737 100644 ---

[Kicad-developers] [PATCH 2/5] Refactor DrawPinShape

2016-02-26 Thread Simon Richter
Shape() ); dlg.SetElectricalTypeList( LIB_PIN::GetElectricalTypeNames(), LIB_PIN::GetElectricalTypeSymbols() ); dlg.SetElectricalType( pin->GetType() ); @@ -147,7 +146,7 @@ void LIB_EDIT_FRAME::OnEditPin( wxCommandEvent& event ) LastPin

[Kicad-developers] [PATCH 0/5] Enum refactoring and shiny icons

2016-02-26 Thread Simon Richter
hopefully enhandle readability. This requires the text/bitmap lookup changes from earlier, that's why it's in this patch set. Simon Simon Richter (5): Fix typo Refactor DrawPinShape Refactor ELECTRICAL_PINTYPE Use TypeSheetLabel enum where appropriate Add icon to pin type column

[Kicad-developers] [PATCH 1/5] Fix typo

2016-02-26 Thread Simon Richter
--- eeschema/lib_pin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eeschema/lib_pin.h b/eeschema/lib_pin.h index 51f5f58..15d5412 100644 --- a/eeschema/lib_pin.h +++ b/eeschema/lib_pin.h @@ -277,7 +277,7 @@ public: /** * Get the electrical type of the pin.

Re: [Kicad-developers] Fwd: CMakeLists.txt order

2016-02-24 Thread Simon Richter
Hi, On 24.02.2016 15:07, Simon Wells wrote: > Any comments on this patch or?? Looks good to me. Is anyone still using the linker maps, or can that be dropped? Simon signature.asc Description: OpenPGP digital signature ___ Mailing list:

Re: [Kicad-developers] [PATCH 01/19] Replace DrawPinShape enum with PinShape

2016-02-22 Thread Simon Richter
Hi, On 19.02.2016 18:27, jp charras wrote: > Could you modify your changes to be compliant with our coding style > policy, when changing enum names? Sure -- do we really want enum names to be uppercase like class names, or is that going to lead to confusion? > Also can you group yours patches

Re: [Kicad-developers] [PATCH] Separate ElectricPinType and TypeSheetLabel

2016-02-22 Thread Simon Richter
Hi, On 19.02.2016 21:40, Wayne Stambaugh wrote: > I asked JP to take a look at this patch for me and he went ahead and > fixed it which caught me a bit off guard. Apparently your patch had > some issues in the ERC. I apologize for the confusion. I'm assuming > you will have to revise your

[Kicad-developers] [PATCH] Update comments (ElectricPinType -> ELECTRICAL_PINTYPE)

2016-02-22 Thread Simon Richter
--- eeschema/lib_pin.cpp | 4 ++-- eeschema/lib_pin.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/eeschema/lib_pin.cpp b/eeschema/lib_pin.cpp index 85ae347..bbf7819 100644 --- a/eeschema/lib_pin.cpp +++ b/eeschema/lib_pin.cpp @@ -103,7 +103,7 @@ static const int

[Kicad-developers] [PATCH] Add icons to pin table's type column

2016-02-17 Thread Simon Richter
. Simon Simon Richter (1): Add icon to pin type column eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 51 -- 1 file changed, 47 insertions(+), 4 deletions(-) -- 2.1.4 ___ Mailing list: https://launchpad.net/~kicad-developers

[Kicad-developers] [PATCH] Add icon to pin type column

2016-02-17 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 51 -- 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index 5a6202e..294ee09 100644 ---

[Kicad-developers] [PATCH 03/19] PinShapeComboBox: Fully initialize in c'tor

2016-02-17 Thread Simon Richter
This makes the widget universally usable without special initialisation. --- eeschema/dialogs/dialog_lib_edit_pin.cpp | 12 eeschema/dialogs/dialog_lib_edit_pin.h | 1 - eeschema/pinedit.cpp | 1 - eeschema/widgets/pin_shape_combobox.cpp | 12 4

[Kicad-developers] [PATCH 10/19] ElectricPinType: Use enum rather than int where possible

2016-02-17 Thread Simon Richter
--- eeschema/class_netlist_object.cpp| 6 +++--- eeschema/class_netlist_object.h | 8 ++-- eeschema/dialogs/dialog_lib_edit_pin.cpp | 2 +- eeschema/dialogs/dialog_lib_edit_pin.h | 6 +++--- eeschema/erc.cpp | 10 +- eeschema/lib_pin.cpp

[Kicad-developers] [PATCH 06/19] PinShape: move text lookup

2016-02-17 Thread Simon Richter
--- eeschema/CMakeLists.txt | 1 + eeschema/lib_pin.cpp| 29 +++-- eeschema/pin_shape.cpp | 67 + eeschema/pin_shape.h| 5 4 files changed, 76 insertions(+), 26 deletions(-) create mode 100644 eeschema/pin_shape.cpp

[Kicad-developers] [PATCH 15/19] PinTypeComboBox: typesafe Get/Set

2016-02-17 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin.h | 2 +- eeschema/widgets/pin_type_combobox.cpp | 12 eeschema/widgets/pin_type_combobox.h | 5 + 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin.h

[Kicad-developers] [PATCH 13/19] PinTypeComboBox: Introduce widget

2016-02-17 Thread Simon Richter
plyToAllParts; diff --git a/eeschema/widgets/pin_type_combobox.cpp b/eeschema/widgets/pin_type_combobox.cpp new file mode 100644 index 000..3c2ac7e --- /dev/null +++ b/eeschema/widgets/pin_type_combobox.cpp @@ -0,0 +1,43 @@ +/* + * This program source code file is part of KiCad, a free EDA CAD

[Kicad-developers] [PATCH 04/19] PinShapeComboBox: typesafe Get/Set

2016-02-17 Thread Simon Richter
These overrides provide typed access to the current selection, overriding the regular integer-based accessor/mutator. --- eeschema/dialogs/dialog_lib_edit_pin.h | 2 +- eeschema/widgets/pin_shape_combobox.cpp | 12 eeschema/widgets/pin_shape_combobox.h | 5 + 3 files

[Kicad-developers] [PATCH 08/19] PinShape: move bitmap lookup

2016-02-17 Thread Simon Richter
This moves the bitmaps out of the data model as well. --- eeschema/lib_pin.cpp| 22 eeschema/lib_pin.h | 7 --- eeschema/pin_shape.cpp | 37 + eeschema/pin_shape.h

[Kicad-developers] [PATCH 16/19] ElectricPinType: move text lookup

2016-02-17 Thread Simon Richter
--- eeschema/CMakeLists.txt | 1 + eeschema/erc.cpp| 8 +++--- eeschema/lib_pin.cpp| 27 ++ eeschema/lib_pin.h | 9 +- eeschema/pin_type.cpp | 73 + eeschema/pin_type.h | 5 6 files changed, 86

[Kicad-developers] [PATCH 17/19] ElectricPinType: remove list interfaces

2016-02-17 Thread Simon Richter
--- eeschema/lib_pin.cpp | 11 --- eeschema/lib_pin.h | 6 -- eeschema/widgets/pin_type_combobox.cpp | 5 +++-- 3 files changed, 3 insertions(+), 19 deletions(-) diff --git a/eeschema/lib_pin.cpp b/eeschema/lib_pin.cpp index cbea37c..d7a83f7

[Kicad-developers] [PATCH 19/19] TypeSheetLabel: use enum

2016-02-17 Thread Simon Richter
--- eeschema/class_netlist_object.h | 2 +- eeschema/dialogs/dialog_edit_label.cpp | 3 ++- eeschema/dialogs/dialog_sch_edit_sheet_pin.h | 8 ++-- eeschema/edit_label.cpp | 8 eeschema/sch_sheet_pin.cpp | 2 +-

[Kicad-developers] [PATCH 18/19] ElectricPinType: move bitmap lookup

2016-02-17 Thread Simon Richter
--- eeschema/lib_pin.cpp | 28 +- eeschema/lib_pin.h | 8 --- eeschema/pin_type.cpp | 43 ++ eeschema/pin_type.h| 2 ++ eeschema/widgets/pin_type_combobox.cpp | 4

[Kicad-developers] [PATCH 12/19] ElectricPinType: Separate PINTYPE_COUNT from enum

2016-02-17 Thread Simon Richter
This allows us to use compiler warnings for enum coverage in switch statements. --- eeschema/lib_pin.cpp | 6 +++--- eeschema/pin_type.h | 7 +-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/eeschema/lib_pin.cpp b/eeschema/lib_pin.cpp index e210d11..99be160 100644 ---

[Kicad-developers] [PATCH 14/19] PinTypeComboBox: fully initialize in c'tor

2016-02-17 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin.cpp | 13 - eeschema/dialogs/dialog_lib_edit_pin.h | 1 - eeschema/pinedit.cpp | 2 -- eeschema/widgets/pin_type_combobox.cpp | 15 +++ 4 files changed, 15 insertions(+), 16 deletions(-) diff --git

[Kicad-developers] [PATCH 07/19] PinShape: drop list interfaces

2016-02-17 Thread Simon Richter
This removes the list generation, and simply iterates over the allowed values. --- eeschema/lib_pin.cpp| 11 --- eeschema/lib_pin.h | 7 --- eeschema/widgets/pin_shape_combobox.cpp | 11 +++ 3 files changed, 7 insertions(+), 22

[Kicad-developers] [PATCH 11/19] ElectricPinType: Rename PIN_NMAX to PINTYPE_COUNT

2016-02-17 Thread Simon Richter
--- eeschema/dialogs/dialog_erc.cpp | 18 +- eeschema/dialogs/dialog_erc.h | 4 ++-- eeschema/erc.cpp| 6 +++--- eeschema/lib_pin.cpp| 6 +++--- eeschema/pin_type.h | 2 +- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git

[Kicad-developers] [PATCH 01/19] Replace DrawPinShape enum with PinShape

2016-02-17 Thread Simon Richter
The bitmask requires a mapping to a different type used for the combobox, and only few of the enumeration values actually make sense. This removes the mapping, and uses a the same numbering throughout the entire code. --- eeschema/dialogs/dialog_lib_edit_pin.cpp | 2 +-

[Kicad-developers] [PATCH 05/19] PinShape: move enum to own header

2016-02-17 Thread Simon Richter
--- eeschema/lib_pin.h| 21 +-- eeschema/pin_shape.h | 50 +++ eeschema/widgets/pin_shape_combobox.h | 2 +- 3 files changed, 52 insertions(+), 21 deletions(-) create mode 100644 eeschema/pin_shape.h diff --git

[Kicad-developers] [PATCH 02/19] PinShapeComboBox: Introduce widget

2016-02-17 Thread Simon Richter
a/widgets/pin_shape_combobox.cpp new file mode 100644 index 000..0c69bb2 --- /dev/null +++ b/eeschema/widgets/pin_shape_combobox.cpp @@ -0,0 +1,43 @@ +/* + * This program source code file is part of KiCad, a free EDA CAD application. + * + * Copyright (C) 2015 Simon Richter <simon.rich

[Kicad-developers] [PATCH 09/19] ElectricPinType: move definition to pin_type.h

2016-02-17 Thread Simon Richter
--- eeschema/lib_pin.h | 20 +--- eeschema/pin_type.h | 49 + 2 files changed, 50 insertions(+), 19 deletions(-) create mode 100644 eeschema/pin_type.h diff --git a/eeschema/lib_pin.h b/eeschema/lib_pin.h index f1121d3..a5d9675

[Kicad-developers] [PATCH 4/4] eeschema dialogs: Update wxFormBuilder timestamp in generated sources

2016-02-17 Thread Simon Richter
For most dialogs, this is the only change after regeneration. Update the timestamp to show what version was used. --- eeschema/dialogs/dialog_annotate_base.cpp| 2 +- eeschema/dialogs/dialog_annotate_base.h | 2 +- eeschema/dialogs/dialog_bom_base.cpp

[Kicad-developers] [PATCH 2/4] eeschema dialogs: update old dialog

2016-02-17 Thread Simon Richter
This dialog was built using an older version of wxFormBuilder, so convert to newer version. No changes otherwise. --- eeschema/dialogs/dialog_lib_edit_draw_item.fbp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/eeschema/dialogs/dialog_lib_edit_draw_item.fbp

[Kicad-developers] [PATCH 1/4] eeschema dialogs: parent of elements in wx Sizer

2016-02-17 Thread Simon Richter
The parent object for elements that are children of a Sizer is the Sizer object itself, not the dialog root. --- eeschema/dialogs/dialog_edit_component_in_lib_base.cpp | 8 eeschema/dialogs/dialog_edit_libentry_fields_in_lib_base.cpp | 4 ++--

[Kicad-developers] [PATCH 0/4] Regenerate and update eeschema dialogs

2016-02-17 Thread Simon Richter
the dialog's hierarchy. Simon Simon Richter (4): eeschema dialogs: parent of elements in wx Sizer eeschema dialogs: update old dialog eeschema dialogs: Add wxALIGN_CENTER_VERTICAL flag eeschema dialogs: Update wxFormBuilder timestamp in generated sources eeschema/dialogs

Re: [Kicad-developers] Windows 10 reports stable 4.0.1 installer as malware.

2016-02-17 Thread Simon Richter
Hi, On 17.02.2016 21:01, Simon Richter wrote: > For the current binaries, I've attached the checksums. I just noticed that the stable release's checksums are missing. We don't have these binaries in Jenkins anymore. Simon signature.asc Description: OpenPGP digital signat

Re: [Kicad-developers] Windows 10 reports stable 4.0.1 installer as malware.

2016-02-17 Thread Simon Richter
Hi, On 17.02.2016 19:55, Wayne Stambaugh wrote: > Is there any way > to confirm that the installer on the website hasn't been compromised? That is a known problem with the heuristic detection: it triggers often on JIT compilers, so it is possible that we are getting false alarms here. >

[Kicad-developers] [PATCH] Pin Table: Make pin position and pin type columns sortable

2016-02-16 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index f905a55..5a6202e 100644 ---

[Kicad-developers] [PATCH] Separate ElectricPinType and TypeSheetLabel

2016-02-16 Thread Simon Richter
These enums are silently treated as equivalent in the ERC, because the values are casted to integers. This works for the most part, because the values are similar, but this is in no way enforced, and there is a small inconsistency (NET_UNSPECIFIED vs PIN_PASSIVE). This turns the storage into a

Re: [Kicad-developers] [PATCH v2 0/3] Correctly split patch

2016-02-15 Thread Simon Richter
Hi Wayne, On 15.02.2016 18:29, Wayne Stambaugh wrote: >> The "v2" set replaces the incorrectly split [2/19] patch. I can prepare >> a branch if that is easier. > If you don't mind. That would make my life a lot easier than having to > apply all of these patches individually. Sent as

Re: [Kicad-developers] [PATCH v2 0/3] Correctly split patch

2016-02-15 Thread Simon Richter
Hi Wayne, Am 15.02.2016 um 17:17 schrieb Wayne Stambaugh: > Have you tested this patch on MSYS and/or MSYS2? Yes, I've tested that with MSYS2. The difference to the previous patch are the parts that went to the cmake developers list: - fix the case where multiple CXXFLAGS that are neither -D

[Kicad-developers] [PATCH 09/19] FindwxWidgets.cmake: documentation for variables

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index a48a315..0e7eb7a 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -463,7

[Kicad-developers] [PATCH 10/19] FindwxWidgets.cmake: Expect directory layout for MSVC 64 bit

2016-02-13 Thread Simon Richter
On 64 bit MSVC, the DLLs and import libraries are placed in a directory called vc_x64, to allow parallel installation of 32 and 64 bit wxWidgets. --- CMakeModules/FindwxWidgets.cmake | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeModules/FindwxWidgets.cmake

[Kicad-developers] [PATCH 07/19] FindwxWidgets.cmake: Fix indentation

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index d4b21d7..e2b46db 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -261,7 +261,7

[Kicad-developers] [PATCH 02/19] FindwxWidgets.cmake: remove a few dbg_msg() invocations

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 55e057d..eed7166 100644 --- a/CMakeModules/FindwxWidgets.cmake +++

[Kicad-developers] [PATCH 00/19] FindwxWidgets.cmake updates

2016-02-13 Thread Simon Richter
in turn. Simon Simon Richter (19): FindwxWidgets.cmake: Remove arguments from else() and end*() FindwxWidgets.cmake: remove a few dbg_msg() invocations FindwxWidgets.cmake: Use uppercase for DBG_MSG macro FindwxWidgets.cmake: Show line number in debug output FindwxWidgets.cmake: Use

[Kicad-developers] [PATCH 08/19] FindwxWidgets.cmake: Look for versioned wx-config scripts

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index e2b46db..a48a315 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -707,7

[Kicad-developers] [PATCH 14/19] FindwxWidgets.cmake: Drop nonsensical assignment

2016-02-13 Thread Simon Richter
No idea where that came from, but it is almost certainly an error. --- CMakeModules/FindwxWidgets.cmake | 2 -- 1 file changed, 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 2711ca7..254621c 100644 --- a/CMakeModules/FindwxWidgets.cmake

[Kicad-developers] [PATCH 16/19] FindwxWidgets.cmake: Reformat documentation

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 147 ++- 1 file changed, 85 insertions(+), 62 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 7f57d8a..7d8007c 100644 --- a/CMakeModules/FindwxWidgets.cmake +++

[Kicad-developers] [PATCH 17/19] FindwxWidgets.cmake: Use ENV foo rather than ENV{foo}

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 7d8007c..f6ff9ab 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -445,12

[Kicad-developers] [PATCH 18/19] FindwxWidgets.cmake: Report failure of wx-config when looking for components

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index f6ff9ab..31c9ae3 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -834,6 +834,7 @@ else()

[Kicad-developers] [PATCH 11/19] FindwxWidgets.cmake: Simplify MATCHES

2016-02-13 Thread Simon Richter
Arbitrary characters at beginning and end of the line are implicitly allowed anyway --- CMakeModules/FindwxWidgets.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 8ac93f3..eca3466 100644 ---

[Kicad-developers] [PATCH 19/19] FindwxWidgets.cmake: Remove extra newline

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 31c9ae3..cf6d450 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -902,7 +902,6 @@

[Kicad-developers] [PATCH 13/19] FindwxWidgets.cmake: Determine version even when not asked to

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 8c6c333..2711ca7 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -857,7 +857,7

[Kicad-developers] [PATCH 05/19] FindwxWidgets.cmake: Use uppercase for macro names

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 88 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 471996c..8c9471e 100644 --- a/CMakeModules/FindwxWidgets.cmake +++

[Kicad-developers] [PATCH 06/19] FindwxWidgets.cmake: Use lowercase for CMake builtins

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 8c9471e..d4b21d7 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -561,7

<    2   3   4   5   6   7   8   9   >