Re: [Kicad-developers] [PATCH] - File format shim for clearance data

I finally got a chance to test this and here is what I found. Please note, my testing was limited to simply adding (foo bar) to each section and object in the board file. I did not add anything more complex such as (foo (bar 1.15)(baz "A baz string")). All valid syntax would need to be

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

I agree with this. The current pad parsing code should not be open ended even if there are plans for future expansion. On 3/27/2018 1:51 PM, Seth Hillbrand wrote: > Hi Jeff- > > Can we split this patch?  I think the addition of strict checking for > the pads should be in 5.   > > -S > >

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

@Jeff, I still have to test the round tripping to make sure there is no data loss for potential combinations of unknown tokens. As soon as I have tested it, I will let you know. On 3/27/2018 1:34 PM, Jeff Young wrote: > 5.0, 6.0 or abandon? > >> On 20 Mar 2018, at 16:47, Jeff Young

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Jeff- Can we split this patch? I think the addition of strict checking for the pads should be in 5. -S 2018-03-27 10:34 GMT-07:00 Jeff Young : > 5.0, 6.0 or abandon? > > > On 20 Mar 2018, at 16:47, Jeff Young wrote: > > Hi Wayne, > > This solution *is*

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

5.0, 6.0 or abandon? > On 20 Mar 2018, at 16:47, Jeff Young wrote: > > Hi Wayne, > > This solution is pretty much “property” tokens except that: > > 1) it’s more flexible (properties can be arbitrary s-expressions) > 2) it handles 3rd-party-needs and our own with a single

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Wayne, This solution is pretty much “property” tokens except that: 1) it’s more flexible (properties can be arbitrary s-expressions) 2) it handles 3rd-party-needs and our own with a single infrastructure I was going to add (3) it requires name-spacing, but “property” tokens will require

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

The user would have to click through a big fat warning that the file is from the future. If you wanna be doubly sure, open things in read only mode if there is a version mismatch, so the user at worst can save the file with another name, allowing recovery without having to drop into a text editor.

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Jeff, I wanted some time to think about this. It has been discussed before. While I'm not completely opposed to it, I still haven't found a more compelling argument to convince me that it is a better idea than using strict parsing. As a user, it does have a certain appeal. As a developer, it

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

@Wayne, did you have any thoughts on this iteration? > On 20 Mar 2018, at 10:22, Jeff Young wrote: > > Oh, and I don’t think this materially alters the support equation: we already > have to deal with hand-edited boards, so what’s in the file is never > guaranteed to be

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Oh, and I don’t think this materially alters the support equation: we already have to deal with hand-edited boards, so what’s in the file is never guaranteed to be something Kicad put there. > On 20 Mar 2018, at 10:19, Jeff Young wrote: > > Hi Seth, > > The original version

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Seth, The original version spit out log entries for skipped elements. This version follows the XML/browser convention of silently ignoring. Even though this isn’t an XML format, I think we need to recognise that we live in an XML world and XML processing conventions set expectations. The

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Jeff- A few questions on how you are implementing this: 1) How does the user know what was skipped? I can imagine team members with different versions getting into difficulty, especially if the features being skipped change the board layout. 2) You are removing strict checking for most of

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

OK, for your guys’ (re)viewing pleasure, a patch which losslessly round-trips stuff it doesn’t understand. 0001-Lossless-round-tripping-of-unknown-constructs.patch Description: Binary data On 16 Mar 2018, at 19:15, hauptmech wrote:While i would still like to see this (my)

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

While i would still like to see this (my) shim go in, I agree with wayne. Until/unless a less brittle approach is used for the parser, it's better to signal a problem painfully and maintain the integrity of the file. I have to admit that when i first heard the s-expressions idea I assumed that

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Wayne, Patch reverted. However, I think your concern is misplaced. If we want to prevent dataloss (ie: from reading a 6.0 file into 5.0), then we should warn the user based on the version string (and give them a chance to say “I still want to open”). But either way, actually failing to

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Jeff, Please revert this patch. Any changes to the board file parser and/or formatter need to be discussed before the changes are committed. It has been the intention that the board parser be pendantic by design to prevent data loss by ignoring unknown formatting. Allowing anything outside of

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Perhaps somewhat germane to this discussion I have removed the strict-format nags from the PCB parser. It now logs warnings to stderr but otherwise ignores structures it doesn’t understand. I’m not sure that helps hauptmech much as if the file is subsequently written the unknown markup will

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi Thomasz, I hope I'm able to address you concerns. I'm stuck using kicad stable in many situations. I brought clearances up for discussion last July but no one moved on it, nor are they required to. Clearance management is a major pain point for me so I wrote a fix. This patch will let us

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Hi! On 2018-03-07 13:44, Tomasz Wlostowski wrote: > I'm not totally opposed to hauptmech's change, I just think it's too > early to merge it. We should discuss such ideas before writing code. My > goal for V6 DRC is to be able to define clearance rules for at least: > - per-net & per-netclass > -

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Le 07/03/2018 à 14:02, Wayne Stambaugh a écrit : > On 3/7/2018 7:44 AM, Tomasz Wlostowski wrote: >> On 07/03/18 12:10, Russell Oliver wrote: >>> Forgive my ignorance but why would storing the clearance for each track >>> segment (if required to by design intent) conflict with a sophisticated >>>

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

On 07/03/18 14:02, Wayne Stambaugh wrote: > It will save us a lot of grief in the > long run. I can't agree more! Tom ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

On 3/7/2018 7:44 AM, Tomasz Wlostowski wrote: > On 07/03/18 12:10, Russell Oliver wrote: >> Forgive my ignorance but why would storing the clearance for each track >> segment (if required to by design intent) conflict with a sophisticated >> design rule management system?  > > For example: what

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

On 07/03/18 12:10, Russell Oliver wrote: > Forgive my ignorance but why would storing the clearance for each track > segment (if required to by design intent) conflict with a sophisticated > design rule management system?  For example: what would happen to the clearance of the segment/via if it

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

Forgive my ignorance but why would storing the clearance for each track segment (if required to by design intent) conflict with a sophisticated design rule management system? As a general approach shouldn't KiCad allow freedom of design when the intention of the designer is clear? Russell On

Re: [Kicad-developers] [PATCH] - File format shim for clearance data

On 07/03/18 11:02, hauptmech wrote: > I have a patch for treating track clearance the same as track width. The > user can already specify a track width that is an exception to the > netclass width, and now do the same for clearance. ( > https://youtu.be/05vfAvYwDio ) Hi hauptmech, I'm sorry but

[Kicad-developers] [PATCH] - File format shim for clearance data

I have a patch for treating track clearance the same as track width. The user can already specify a track width that is an exception to the netclass width, and now do the same for clearance. ( https://youtu.be/05vfAvYwDio ) This is not that patch. This is a small shim for the file format