Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On Wed, Jun 12, 2013 at 9:00 AM, Dick Hollenbeck wrote: > > > > > > > Ahh. Dick, maybe it makes sense to wait until this work is done and > simply feed the idea > > forward to Maciej for the rework, rather than doing the work twice. The > current pan mode > > is usable. > > > > Chris > > > Let me

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

> > > Ahh. Dick, maybe it makes sense to wait until this work is done and simply > feed the idea > forward to Maciej for the rework, rather than doing the work twice. The > current pan mode > is usable. > > Chris Let me know if it is your intention to wait. If so, I will file a bug report,

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On 06/11/2013 07:10 AM, Chris Morgan wrote: > > On Tue, Jun 11, 2013 at 4:16 AM, Maciej Suminski > wrote: > > Hi Chris, > > > On 06/11/2013 02:11 AM, Chris Morgan wrote: > > - Is the rewrite by CERN going to cause all of this dragging/moving >

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On Tue, Jun 11, 2013 at 4:16 AM, Maciej Suminski wrote: > Hi Chris, > > > On 06/11/2013 02:11 AM, Chris Morgan wrote: > >> - Is the rewrite by CERN going to cause all of this dragging/moving code >> to be rewritten? >> > > Yes. In the future it is going to be implemented using tool framework (if >

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

Hi Chris, On 06/11/2013 02:11 AM, Chris Morgan wrote: - Is the rewrite by CERN going to cause all of this dragging/moving code to be rewritten? Yes. In the future it is going to be implemented using tool framework (if you want to know more details, you may have a look at http://www.ohwr.org/

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On Mon, Jun 10, 2013 at 9:39 AM, Dick Hollenbeck wrote: > On 06/10/2013 07:37 AM, Chris Morgan wrote: > > > > On Mon, Jun 10, 2013 at 8:29 AM, Dick Hollenbeck > > wrote: > > > > > > > > Can you test the attached patch: > > > It removes the if( ..) useless tes

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On 06/10/2013 07:37 AM, Chris Morgan wrote: > > On Mon, Jun 10, 2013 at 8:29 AM, Dick Hollenbeck > wrote: > > > > > Can you test the attached patch: > > It removes the if( ..) useless test (and perhaps broken) which explains > > sometimes the panning does

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On Mon, Jun 10, 2013 at 8:29 AM, Dick Hollenbeck wrote: > > > > Can you test the attached patch: > > It removes the if( ..) useless test (and perhaps broken) which explains > > sometimes the panning does not happen. > > It set the cross hair position before sending the event which uses this > > p

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

> > Can you test the attached patch: > It removes the if( ..) useless test (and perhaps broken) which explains > sometimes the panning does not happen. > It set the cross hair position before sending the event which uses this > position, and ensure the zoom center does not uses a strange previou

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

Le 09/06/2013 20:25, Chris Morgan a écrit : I think you have good points. I'll take a look at the more comprehensive fix for the issue. On the point of animating the pan, what are your thoughts? The pan today is very discontinuous looking. Chris On Sunday, June 9, 2013, Dick Hollenbeck wrote

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On 06/09/2013 01:25 PM, Chris Morgan wrote: > I think you have good points. I'll take a look at the more comprehensive fix > for the issue. > > On the point of animating the pan, what are your thoughts? The pan today is > very > discontinuous looking. >From a user interface standpoint, the ani

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

I think you have good points. I'll take a look at the more comprehensive fix for the issue. On the point of animating the pan, what are your thoughts? The pan today is very discontinuous looking. Chris On Sunday, June 9, 2013, Dick Hollenbeck wrote: > On 06/09/2013 01:01 PM, Dick Hollenbeck w

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On 06/09/2013 01:01 PM, Dick Hollenbeck wrote: > >> The if() test should probably be: >> >> >> if( size.x <= event.GetX() || size.y <= event.GetY() >> || event.GetX() < 0 || event.GetY() < 0 ) > > > Fine, that works. > > But let's remember that there are workspace limits defined by how ma

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

> The if() test should probably be: > > > if( size.x <= event.GetX() || size.y <= event.GetY() > || event.GetX() < 0 || event.GetY() < 0 ) Fine, that works. But let's remember that there are workspace limits defined by how many nanometers can fit in a 32 bit integer workspace. I don't

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

Looking at it again, I think there *still* some asymmetry with respect to the if() test. The if() test should probably be: if( size.x <= event.GetX() || size.y <= event.GetY() || event.GetX() < 0 || event.GetY() < 0 ) So that if the mouse is even one pixel outside the client, or more, t

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

Thanks Chris for reporting this problem. I am not thrilled about having support for panning in two different places (especially if the original location is no longer functional). The original place is EDA_DRAW_PANEL::OnMouseLeaving() as you pointed out. Looking in there, I discovered an "off b

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On Sun, Jun 9, 2013 at 11:05 AM, Dick Hollenbeck wrote: > On 06/08/2013 07:08 PM, Chris Morgan wrote: > > I'm still not sure how to generate patches with bzr. I really want to do > 'bzr format-patch > > -1' like with git but I can't find an equivalent approach. > > > > ---

Re: [Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

On 06/08/2013 07:08 PM, Chris Morgan wrote: > I'm still not sure how to generate patches with bzr. I really want to do 'bzr > format-patch > -1' like with git but I can't find an equivalent approach. > > > revno: 4196 > committer: Chris

[Kicad-developers] [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

I'm still not sure how to generate patches with bzr. I really want to do 'bzr format-patch -1' like with git but I can't find an equivalent approach. revno: 4196 committer: Chris Morgan branch nick: kicad timestamp: Sat 2013-06-08 16:50: