Zficani, are you still working on this? It came up in
https://gitlab.com/kicad/code/kicad/issues/1973#note_277712551.
You could fork in gitlab and make it a merge request.
Eeli Kaikkonen
On Sat, Oct 26, 2019 at 3:58 AM Zficani Zficani wrote:
> Hi,
> I'm sorry for the delay but I finally got
On 2019-10-25 17:57, Zficani Zficani wrote:
> Hi,
> I'm sorry for the delay but I finally got everything sorted out. I formatted
> the code and fixed a few bugs I found.
> Regarding `git format-patch`, I used it originally but my commits contain
> many TODOs and temporary code so I was told
Use the clang-format git commit hook[1] to only format the changes in
your git commits rather than entire files.
[1]:
http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html#tools
On 10/15/19 4:22 PM, Zficani Zficani wrote:
> HI,
> thank you so much for the
HI,
thank you so much for the feedback.
I agree with your first point, will do that very soon.
Regarding the code formatting, I tried using both uncrustify and
clang-format with the supplied configs but none of them really worked
because they would end up changing lots of other code outside of the
On 2019-10-15 11:57, Moses McKnight wrote:
On 10/15/19 1:41 PM, Seth Hillbrand wrote:
4) Single-line statements after if/else don't get brackets {}
Is that actually part of the kicad code standard?!? Every standard
and recommendation I've ever seen recommends/requires the opposite to
prevent
On 2019-10-15 11:41, Seth Hillbrand wrote:
On 2019-10-14 14:42, Zficani Zficani wrote:
Hi,
No problem, I just wanted to make sure I sent the message properly.
Here's a single squashed patch with all previous changes and these
comments about copying selection.
Thank you so much for your
Hi,
No problem, I just wanted to make sure I sent the message properly. Here's
a single squashed patch with all previous changes and these comments about
copying selection.
Thank you so much for your review.
On Mon, Oct 14, 2019 at 12:13 AM Ian McInerney
wrote:
> Zifcani,
>
> Sorry for the
Zifcani,
Sorry for the delay in the response. Yes, you can just attach the new
patches to an email and send it to the list. You can either squash them all
into 1 patch, or create 2 patches (the first just the wxFormbuilder dialog
class, so all the _base.fbp/cpp/h files, and the second the
Hi,
I see, I will send in new patches later today. Do I just send them in an
email like this?
On Fri, 11 Oct 2019, 02:10 Seth Hillbrand, wrote:
>
> On 2019-10-09 17:08, Zficani Zficani wrote:
>
> Hi,
> it's been about 10 days since my message so I just want to make sure I
> sent it properly and
On 2019-10-09 17:08, Zficani Zficani wrote:
> Hi,
> it's been about 10 days since my message so I just want to make sure I sent
> it properly and you noticed it because I'm not sure as I'd want to be able to
> actually use this feature soon because it's very useful for me.
>
> Thank you.
>
Hi,
it's been about 10 days since my message so I just want to make sure I sent
it properly and you noticed it because I'm not sure as I'd want to be able
to actually use this feature soon because it's very useful for me.
Thank you.
On Sun, Sep 29, 2019 at 11:55 PM Zficani Zficani wrote:
> Hi,
Hi,
I reviewed your remarks and made appropriate changes but I have a few
questions.
Regarding your first remark, I had to make them non-reference because
the selection is sorted inplace which means that the original selection
will be modified which in turn make unhighlight hang/enter and infinite
Thanks for putting together this changeset. I have a few comments from just
looking through it (I haven't actually compiled and tested it yet).
1) Why did you change the variable type for the EE_SELECTION in patches 5
and 6? The requestSelection function returns a reference to the object, and
Hi,
On 28.09.19 20:40, Zficani Zficani wrote:
> This patch adds an option to automatically annotate components/symbols
> when they're placed, copied or duplicated. Configuration can be found
> in Preferences and it is akin to 'Annotate Schematic...' tool. User can
> choose how they want their
14 matches
Mail list logo
