Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

I made a quick implementation of this in my GerbView branch and it seems to work great. I'm not sure about doing it this way for pcbnew because all the items override ViewGetLayers -- do you think adding some superclass behavior to ViewGetLayers would be a good approach, or maybe there is a better

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

On 09/15/2017 09:09 PM, Jon Evans wrote: > Hi Orson, > > I understand your concern; I will back out this patch and look at other > ways of improving the behavior (the current behavior does not work very > well at all in GerbView when zoomed in, but I could maybe set another > factor for the

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

Hi Orson, I understand your concern; I will back out this patch and look at other ways of improving the behavior (the current behavior does not work very well at all in GerbView when zoomed in, but I could maybe set another factor for the variable line width for GerbView that would work better).

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

Hi Jon, The implementation is correct, I tested the patch and it works as advertised, but I am not sure if we really want to switch to fixed line width for BRIGHT_BOX. Drawing a 10px wide outline looks fine at certain zoom levels, but the items are covered with the outline when the view is zoomed

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

Hi Orson, Could you please review this and advise when you have a chance? If there is some problem with it I can back this out of my branch. This is the only open patch before I start sending Gerbview patches. Thanks, Jon On Tue, Sep 5, 2017 at 10:03 PM, Oliver Walters <

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

Bump On Tue, Sep 5, 2017 at 10:21 PM, Jon Evans wrote: > OK, will wait to hear from Orson then. I did test and it seems to do what > I want on OpenGL + Cairo > > -Jon > > On Tue, Sep 5, 2017 at 10:03 PM, Oliver Walters < > oliver.henry.walt...@gmail.com> wrote: > >> Jon, >>

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

OK, will wait to hear from Orson then. I did test and it seems to do what I want on OpenGL + Cairo -Jon On Tue, Sep 5, 2017 at 10:03 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Jon, > > I submitted a very similar patch earlier this year, and Orson raised an > issue, saying

Re: [Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

Jon, I submitted a very similar patch earlier this year, and Orson raised an issue, saying that it would cause issues with cached targets on OpenGl? I don't know much about this particular issue but it would be good to get his sign off on this patch. IIRC he said he would look into it when he

[Kicad-developers] [PATCH] Make BRIGHT_BOX line width dependent on zoom level

Hi all, This patch is a quick one to make the line width of the BRIGHT_BOX dependent on the zoom level so that it remains basically the same apparent size on the screen. -Jon From fe5c8f7879c8c74ad67ea2c45a1945a9692150e7 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Tue, 5