Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-04-01 Thread Kevin Cozens
On 2017-03-30 12:05 PM, Fabrizio Tappero wrote: I think the "no snap to grid" option reachable with Shift-Ctrl is not visible in any menu nor in the hotkey list People will have hard time to find it I suppose unless they read the manual. What? You expect people to RTFM? ;) I just tried

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-30 Thread jp charras
Le 30/03/2017 à 15:34, John Beard a écrit : > Ctrl is already used for angle snap. > > I think there should be a generic way to turn grid snap on and off in > all GAL modes. Then it stays on or off until you toggle it again. FYI, temporary turn grid snap off exists in Eeschema (when moving

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-30 Thread John Beard
Ctrl is already used for angle snap. I think there should be a generic way to turn grid snap on and off in all GAL modes. Then it stays on or off until you toggle it again. This is a little bit tricky to do as a global action due to how the GAL tool manager keeps VIEW_CONTROL state for each

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-30 Thread Fabrizio Tappero
I second this Regards Fabrizio On Wed, Mar 29, 2017 at 2:23 AM, Andrey Kuznetsov wrote: > Good point Kevin. > > Can we have "hold down CTRL" to disable snap to grip feature? That would > cover the caliper and other myriad of uses when snap to grid is unwanted. > > On Tue,

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-28 Thread Andrey Kuznetsov
Good point Kevin. Can we have "hold down CTRL" to disable snap to grip feature? That would cover the caliper and other myriad of uses when snap to grid is unwanted. On Tue, Mar 28, 2017 at 7:07 AM, Kevin Cozens wrote: > On 2017-03-28 03:25 AM, Fabrizio Tappero wrote: > >> this

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-28 Thread John Beard
I agree that presistent rulers would be nice, but saving into the files will take a format bump. I opened an issue for it for people to put their comments on: https://bugs.launchpad.net/kicad/+bug/1676814 Perhaps a ruler graticule around the preview window would work? Something like the Inkscape

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-28 Thread Simon Richter
Hi, On 28.03.2017 09:41, Andrey Kuznetsov wrote: > It would be nice if the ruler could be a manipulable object that can be > saved, locked, have multiple rulers on screen. It won't be output to > gerbers, for kicad viewing only. I wonder if it would make sense to have dimensions in the

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-28 Thread Fabrizio Tappero
Hi guys, this ruler (caliper icon) does look really good. Is there anyway to have it available in the 2D/3D viewer when a footprint is chosen (inside the library browser)? It is often a good idea to have a way to measure footprint size. cheers Fabrizio On Fri, Mar 10, 2017 at 5:07 PM, Maciej

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread Maciej Sumiński
Perfect, the measurement tool is already included in the master branch. Thanks! Cheers, Orson On 03/10/2017 03:07 PM, John Beard wrote: > Hi Orson, > > That patch looks fine. Sorry about the formatting/copyright header. > You are right for the by-ref and the const. > > "Measure distance"

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread John Beard
Hi Orson, That patch looks fine. Sorry about the formatting/copyright header. You are right for the by-ref and the const. "Measure distance" sounds fine to me. Cheers, John On Fri, Mar 10, 2017 at 9:59 PM, Maciej Sumiński wrote: > Hi John, > > All I can say is: it

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread Maciej Sumiński
Hi John, All I can say is: it looks really cool! I would like to merge, but before I do so, would you consider the attached fixup patch? If so, I simply update the existing set of patches and merge everything. Changes: - Changed std::vector<> to const std::vector<>& in

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread John Beard
Hi Nick, That's because the label formatting just uses a fixed 2 DP display for mm (it uses 4 for inches, and 1 for degrees). It's not a perfect solution, but it does line up nicely when the labels are on the left of the line. Stripping trailing zeroes would make it ragged when you zoom in a bit

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-10 Thread Nick Østergaard
It certainly looks quite nice. I have not yet tested the patch, but I wonder why it shall show the integer labels here with decimals behind it when they are all zero? 2017-03-09 18:18 GMT+01:00 John Beard : > By the way, here's a screenshot of the ruler tool: > > Cheers, >

Re: [Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-09 Thread John Beard
By the way, here's a screenshot of the ruler tool: Cheers, John On Fri, Mar 10, 2017 at 1:11 AM, John Beard wrote: > Hi, > > Here's a tool I'm had on my list for a while - a ruler tool. > > This patch set introduces a new directory, for "preview items" which > are

[Kicad-developers] [PATCH] Measurement tool for GAL

2017-03-09 Thread John Beard
Hi, Here's a tool I'm had on my list for a while - a ruler tool. This patch set introduces a new directory, for "preview items" which are EDA_ITEMS that are only used for transient previews, such as drawing aids and selection boxes. These are located in common, so that they can (in theory) be