Re: [Kicad-developers] [PATCH] Pcbnew menu bar

I can’t tell, I didn’t look for that bug. I didn’t follow the restructuring on the ML. My comment was just about the “Preferences” menu entry in KiCad menu. I did search it for some time before the restructuring and wondered a bit that it still like that after. > On 21. Feb 2018, at 19:13, Michae

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Bernhard, do you mean this bug [1] existed before the 3b085f0 "Pcbnew new menubar structure" commit? [1] https://bugs.launchpad.net/kicad/+bug/1750494 On 21 February 2018 at 13:07, Bernhard Stegmaier wrote: > Hi, > > Just to mention… it has been like this before the patches. > At least on macOS,

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

On 2018-02-21 15:08, Jeff Young wrote: > Yes, but not for 5.0. > > See https://bugs.launchpad.net/kicad/+bug/1748680 (most of the Kicad menu > items will be app settings). > > But this reminds me that I should probably add a task to tabularize pcbnew’s > preferences like we did with eeschema.

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Yes, the JetBrains stuff did that too. I remember being quite a fan of it. > On 21 Feb 2018, at 14:42, Jon Evans wrote: > > List+Tabs can work well too. I just think we will benefit from multiple > levels of hierarchy, and from having the first level of hierarchy be a > vertical list that ca

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

List+Tabs can work well too. I just think we will benefit from multiple levels of hierarchy, and from having the first level of hierarchy be a vertical list that can have some kind of logical grouping (section headers, horizontal lines, etc) To be honest, I don't find Qt Creator to be a shining e

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

I’m not a fan of tree controls for preferences, but there’s also the compromise of a list + tabs (a la QTCreator). > On 21 Feb 2018, at 14:28, Jon Evans wrote: > > Before you commit to that, I had wanted to make an argument in favor of tree > view preferences instead of tabs. > I think we will

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Before you commit to that, I had wanted to make an argument in favor of tree view preferences instead of tabs. I think we will quickly exceed a reasonable number of tabs in order to accommodate having all the preferences in one place, especially given that we will only have more and more features t

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Yes, but not for 5.0. See https://bugs.launchpad.net/kicad/+bug/1748680 (most of the Kicad menu items will be app settings). But this reminds me that I should probably add a task to tabularize pcbnew’s preferences like we did with eeschema. Chee

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi, Just to mention… it has been like this before the patches. At least on macOS, there is still a “Preferences” menu entry below the “KiCad” menu bar entry (the “General Settings” dialog). Then, there is the “Preferences” menu… without those “General Setting”. Because there is a “Preferences” m

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hello Michael and Jeff, It seems like we got our first small regression from this patch series. Could you have a look. Please note it looks like it is window manager dependent. https://bugs.launchpad.net/kicad/+bug/1750494 Nick 2018-02-18 23:03 GMT+01:00 Wayne Stambaugh : > Indeed I did forget.

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Indeed I did forget. Thanks for the reminder. Thank you Jeff for the patches. On 02/18/2018 03:02 PM, Michael Kavanagh wrote: Thanks Wayne. Please don't forget to merge Jeffs dialog changes which complete the Pcbnew menubar modifications. I have reattached them to this email for convenience.

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Michael, I figured out why we are not using IS_ACCELERATOR for these menu entries. AddHotkeyName() adds a "+Alt+" to the hotkey so this is *not* what we want so I used the original 0003 patch. I apologize for the confusion. I merged this and you 0004 patch. We can make any tweaks to it if

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

In every other app New, Open, Save, Save As and Print are standard hotkeys and not accelerators. They don't have the modifier key, so are the "standard" keyboard shortcuts. Nevertheless, please find attached new patches for review. These accompany both of Jeffs dialog patches. Hopefully I didn't b

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

It should be. We really need to get out of the bad habit of having toolbar only access to tools and settings. I'm sure there are some in the schematic editor, symbol editor, and footprint editor as well. On 02/17/2018 06:16 AM, Jeff Young wrote: > The Fill/Outline stuff is included. Not sure ab

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

On 02/16/2018 03:29 PM, Jeff Young wrote: Is 0003-Fix-up-file-menu-and-hotkeys.patch suitable for merging straight away? Yes, I believe it is. AddHotkeyName() should be specified with IS_ACCELERATOR because New, Save, Save As, etc. are menu accelerators not hotkeys so that needs to be fixed

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

The Fill/Outline stuff is included. Not sure about High Contrast mode, but it probably should be. > On 17 Feb 2018, at 06:58, Gaurav Juvekar wrote: > > Hi all, > > Probably not too relevant, but can we have a workaround of > https://bugs.launchpad.net/kicad/+bug/1575097 (hidden icons) by add

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi all, Probably not too relevant, but can we have a workaround of https://bugs.launchpad.net/kicad/+bug/1575097 (hidden icons) by adding View -> High Contrast (Checkable like the "Flip board view") View -> Tracks -> Outline (Radio button like the canvas selector) -> Fill View -> V

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

> Is 0003-Fix-up-file-menu-and-hotkeys.patch suitable for merging straight away? Yes, I believe it is. Cheers, Jeff. > On 16 Feb 2018, at 19:31, Michael Kavanagh wrote: > > Footprint library table is has a global part yes, but its still to do > with the PCB being designed and not the applicat

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Footprint library table is has a global part yes, but its still to do with the PCB being designed and not the application, so IMO belongs in the setup menu. Regardless, I'll work on the revised plans this weekend, and move "Grid Settings..." to the view menu. Is 0003-Fix-up-file-menu-and-hotkeys.

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hey Jeff, I agree with these changes so as soon as Michael posts the revised patches, we can get them reviewed and I can merge them. Thanks for helping out with the patch review. I appreciate the help. Cheers, Wayne On 2/16/2018 10:47 AM, Jeff Young wrote: > Hi Wayne, > > With these changes:

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi Wayne, With these changes: “Footprint Library Wizard” and “Footprint Library Table” are environmental settings so they belong under Preferences, not Setup. That (and moving “User Defined Grid…”) should make it short enough not to need the nested menu for Dimensions. I still feel strongly

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Gentlemen, Where do we stand on this? I would like to get this into rc1 if possible just to reduce long term maintenance issues. Once I branch version 5, all patches have to be merged from the development branch to the version 5 branch so it makes more work for me. Thanks, Wayne On 2/15/2018

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

“Footprint Library Wizard” and “Footprint Library Table” are environmental settings so they belong under Preferences, not Setup. That (and moving “User Defined Grid…”) should make it short enough not to need the nested menu for Dimensions. I still feel strongly that “User Defined Grid…” belong

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Thanks for that Orson, and sorry for causing so much confusion everyone. Lesson learnt. Also thanks Jeff for helping with the dialog change. I'll pause for feedback and we can address the rest of the patches one by one. For context here is what I suggest: - File: as per 0003-Fix-up-file-menu-a

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

It appears in this case that they are being used as hotkeys rather than menu accelerators so no change is necessary. On 2/15/2018 11:40 AM, Maciej Sumiński wrote: > Hi Wayne, > > I am not sure if there is an issue, I think cut/copy/paste are genuine > hotkeys and not just accelerators, unless you

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi Wayne, I am not sure if there is an issue, I think cut/copy/paste are genuine hotkeys and not just accelerators, unless you have something else in mind. In any case, I have committed patch 0002 as is it was sent here. Cheers, Orson On 02/15/2018 05:31 PM, Wayne Stambaugh wrote: > Orson, > >

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Orson, Did you fix the IS_ACCELERATOR issue in patch 0002 when calling AddHotkeyName()? Wayne On 2/15/2018 11:00 AM, Maciej Sumiński wrote: > To reduce the discussion scope, I have committed the obvious improvements: > 0001-Fix-spelling-error.patch > 0002-Improve-edit-menu-and-use-common-hotkeys

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

To reduce the discussion scope, I have committed the obvious improvements: 0001-Fix-spelling-error.patch 0002-Improve-edit-menu-and-use-common-hotkeys.patch 0004-Remove-duplicate-track-menu-item.patch To be discussed: 0003-Fix-up-file-menu-and-hotkeys.patch 0005-Add-missing-tools-to-menubar.patch

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Yep. Looks good. > On 15 Feb 2018, at 13:46, Michael Kavanagh wrote: > > Was this what you meant? > > On 15 February 2018 at 11:15, Jeff Young > wrote: > Hi Michael, > > Only thing I found wrong was that you have Sketch & Wireframe zones backwards: > > Wireframe == I

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi Michael, Only thing I found wrong was that you have Sketch & Wireframe zones backwards: Wireframe == ID_TB_OPTIONS_SHOW_ZONES_DISABLE Sketch == ID_TB_OPTIONS_SHOW_ZONES_OUTLINES_ONLY On the opinion side, the Inspect menu is growing on me. So if no one else has objections to it, then I’ll s

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Okay thanks. Also I think I messed up even the simple first patch (git n00b over here). Please await an updated patch set. Cheers, Michael On 14 February 2018 at 21:30, Wayne Stambaugh wrote: > Michael, > > For future reference, please try to avoid posting a large patch set like > this. I makes

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Michael, For future reference, please try to avoid posting a large patch set like this. I makes it difficult to comment on them without the email thread quickly becoming difficult to follow. Also, please make an announcement on the mailing when making substantial changes like this. You could ha

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Can we please address these patches one at a time? This thread is getting hard for me to follow due to my old age induced diminished brain capacity. Patch 1 is a no problem since it's just a code spelling error so I will merge this one as soon as I get a chance. I will follow up with the remaini

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

I’m going to reply to some comment here inline. But I also wanted to mention from the other thread that I’m happy to do the dialog changes. > On 14 Feb 2018, at 12:11, Michael Kavanagh wrote: > > Hi Jeff, thanks for your feedback. Please see my comments inline below > > On 14 February 2018 at

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi Orson, On 14 February 2018 at 08:54, Maciej Sumiński wrote: > Well done, Michael! There is one more patch that should go with these > changes (see the attachment), otherwise Linux users see some asserts. > > I mostly agree with Jeff's remarks below, but IMHO your patches are > already a huge i

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Hi Jeff, thanks for your feedback. Please see my comments inline below On 14 February 2018 at 01:23, Jeff Young wrote: > > Good stuff; I like most of these changes. > > A few issues: > > Show/Hide Layers Manager and Show/Hide Microwave Toolbar should be changed to checkable items (with just the

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

See comments inline: > On 14 Feb 2018, at 08:54, Maciej Sumiński wrote: > > Well done, Michael! There is one more patch that should go with these > changes (see the attachment), otherwise Linux users see some asserts. > > I mostly agree with Jeff's remarks below, but IMHO your patches are > alr

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Well done, Michael! There is one more patch that should go with these changes (see the attachment), otherwise Linux users see some asserts. I mostly agree with Jeff's remarks below, but IMHO your patches are already a huge improvement in their current state. On 02/14/2018 02:23 AM, Jeff Young wro

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

Good stuff; I like most of these changes. A few issues: Show/Hide Layers Manager and Show/Hide Microwave Toolbar should be changed to checkable items (with just the show version of the text). They should also probably move down the menu so they’re in the same order as the toolbar buttons.