Re: [Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-22 Thread Wayne Stambaugh
On 6/22/2015 1:20 AM, jp charras wrote: Le 21/06/2015 22:24, Wayne Stambaugh a écrit : Does anyone else have an opinion on this? Is there any objection to getting rid of the search dialog or do you prefer adding both a search (current dialog) and a browse (Chris's patch) option to select the

Re: [Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-21 Thread jp charras
Le 21/06/2015 22:24, Wayne Stambaugh a écrit : Does anyone else have an opinion on this? Is there any objection to getting rid of the search dialog or do you prefer adding both a search (current dialog) and a browse (Chris's patch) option to select the footprint. I'm fine with either option.

Re: [Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-21 Thread Nick Østergaard
I think it is good. Mostly I click Select by Browser anyway. And if Henner plans to move his awesome search as you type dialog to pcbnew after the release I think it is ok. 2015-06-21 22:24 GMT+02:00 Wayne Stambaugh stambau...@gmail.com: Does anyone else have an opinion on this? Is there any

Re: [Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-21 Thread Wayne Stambaugh
The problem this fixes will not be fixed by Henner's search dialog because the lag is due to the loading of the all footprints in the fp lib table. Henner's search dialog will need the entire list of footprint in order for the search to be effective. The footprint browser solves this problem

Re: [Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-21 Thread Wayne Stambaugh
Does anyone else have an opinion on this? Is there any objection to getting rid of the search dialog or do you prefer adding both a search (current dialog) and a browse (Chris's patch) option to select the footprint. I'm fine with either option. I want to be sure before I commit this patch. On

Re: [Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-19 Thread Wayne Stambaugh
Chris, I'm not opposed to this patch. I actually prefer the footprint viewer over the footprint search dialog for two reasons. One, the footprint viewer uses lazy loading (it doesn't actually read the footprint files until you select a library) so there is no lag showing the viewer due to

[Kicad-developers] [PATCH] Use new footprint selector for Change Footprints

2015-06-14 Thread Chris Pavlina
This patch enables use of the new (kiface) footprint selector in the Exchange Footprints dialog. As suggested in this bug report: https://bugs.launchpad.net/kicad/+bug/1464821 I'll look into making this change in the module editor as well, but that will require more work. -- Chris commit