Re: [Kicad-developers] 3D filename resolution

2016-06-12 Thread Wayne Stambaugh
Patch committed in product branch r6924. Thanks. On 6/11/2016 10:32 PM, Cirilo Bernardo wrote: > The attached patch makes the following changes: > > 1. Adds a Help button and text to the 3D alias configuration dialog > 2. Displays KISYS3DMOD and internally defined KiCad path env vars > 3. Adds

Re: [Kicad-developers] 3D filename resolution

2016-06-11 Thread Cirilo Bernardo
The attached patch makes the following changes: 1. Adds a Help button and text to the 3D alias configuration dialog 2. Displays KISYS3DMOD and internally defined KiCad path env vars 3. Adds a button to bring up the "Configure Paths" (env vars) dialog 4. Removes the file name mapping feature from

Re: [Kicad-developers] 3D filename resolution

2016-06-09 Thread Cirilo Bernardo
On Thu, Jun 9, 2016 at 10:07 PM, Wayne Stambaugh wrote: > On 6/9/2016 2:44 AM, jp charras wrote: > > Le 09/06/2016 à 08:31, Cirilo Bernardo a écrit : > >> Thanks Jean-Pierre, > >> > >> I'll work on the help button and on the display of KISYS3DMOD. In the > case > >> of

Re: [Kicad-developers] 3D filename resolution

2016-06-09 Thread Wayne Stambaugh
On 6/9/2016 2:44 AM, jp charras wrote: > Le 09/06/2016 à 08:31, Cirilo Bernardo a écrit : >> Thanks Jean-Pierre, >> >> I'll work on the help button and on the display of KISYS3DMOD. In the case >> of KISYS3DMOD, should I allow editing of the value or just display it? >> >> - Cirilo > > I do not

Re: [Kicad-developers] 3D filename resolution

2016-06-09 Thread jp charras
Le 09/06/2016 à 08:31, Cirilo Bernardo a écrit : > Thanks Jean-Pierre, > > I'll work on the help button and on the display of KISYS3DMOD. In the case > of KISYS3DMOD, should I allow editing of the value or just display it? > > - Cirilo I do not have a strong opinion. Try to allow editing. It

Re: [Kicad-developers] 3D filename resolution

2016-06-09 Thread Cirilo Bernardo
Thanks Jean-Pierre, I'll work on the help button and on the display of KISYS3DMOD. In the case of KISYS3DMOD, should I allow editing of the value or just display it? - Cirilo On Thu, Jun 9, 2016 at 3:58 PM, jp charras wrote: > Le 30/05/2016 à 10:56, Cirilo Bernardo a

Re: [Kicad-developers] 3D filename resolution

2016-06-08 Thread jp charras
Le 30/05/2016 à 10:56, Cirilo Bernardo a écrit : > Attached is an updated patch made against r6854. A patch to fix Bug > #1585714 prevented the previous patch from applying cleanly. > > - Cirilo > > Hi, Cirilo, I committed your patch in rev 6905. Thanks. After playing with your 3D path

Re: [Kicad-developers] 3D filename resolution

2016-05-30 Thread Cirilo Bernardo
Attached is an updated patch made against r6854. A patch to fix Bug #1585714 prevented the previous patch from applying cleanly. - Cirilo On Thu, Apr 21, 2016 at 5:01 AM, Wayne Stambaugh wrote: > The environment variables defined externally to kicad should take >

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Mário Luzeiro
Cirilo sent us today a (pending) patch that may have some modifications related with this subject. Mario > > So does it show the external env var or the config one? If it shows the > > external one, that is what Mario expects. > > The internally defined environment variable is shown. I suppose

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Nick Østergaard
don't see is change > > the variable path. > >> > > >> > Mario > >> > > >> > From: Kicad-developers > > [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net > > <mailto:ua...@lists.launchpad.net&g

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Wayne Stambaugh
ed in the GUI. >> > Users will get puzzled if something that they don't see is change > the variable path. >> > >> > Mario >> > >> > From: Kicad-developers > [kicad-developers-bounces+mrluzeiro=ua...@lists.la

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Nick Østergaard
; > > > From: Kicad-developers [kicad-developers-bounces+mrluzeiro= ua...@lists.launchpad.net] on behalf of Cirilo Bernardo [ cirilo.berna...@gmail.com] > > Sent: 20 April 2016 01:19 > > To: KiCad Developers > > Subject: [Kicad-deve

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Wayne Stambaugh
___ > From: Kicad-developers > [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of > Cirilo Bernardo [cirilo.berna...@gmail.com] > Sent: 20 April 2016 01:19 > To: KiCad Developers > Subject: [Kicad-developers] 3D filename resolution > > H

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Mário Luzeiro
__ > From: Kicad-developers > [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of > Cirilo Bernardo [cirilo.berna...@gmail.com] > Sent: 20 April 2016 01:19 > To: KiCad Developers > Subject: [Kicad-developers] 3D filename resolution > &

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread easyw
bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of Cirilo Bernardo [cirilo.berna...@gmail.com] Sent: 20 April 2016 01:19 To: KiCad Developers Subject: [Kicad-developers] 3D filename resolution Hi folks, I'm cleaning up the new 3D filename resolution code, removing some redundant code and fix

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread yann jautard
th. Mario From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of Cirilo Bernardo [cirilo.berna...@gmail.com] Sent: 20 April 2016 01:19 To: KiCad Developers Subject: [Kicad-developers] 3D filename resolution Hi fol

Re: [Kicad-developers] 3D filename resolution

2016-04-20 Thread Mário Luzeiro
rs-bounces+mrluzeiro=ua...@lists.launchpad.net] on behalf of Cirilo Bernardo [cirilo.berna...@gmail.com] Sent: 20 April 2016 01:19 To: KiCad Developers Subject: [Kicad-developers] 3D filename resolution Hi folks, I'm cleaning up the new 3D filename resolution code, removing some redundant code and fix

[Kicad-developers] 3D filename resolution

2016-04-19 Thread Cirilo Bernardo
Hi folks, I'm cleaning up the new 3D filename resolution code, removing some redundant code and fixing corner-case bugs which break with legacy behavior. I'd just like some input on one item: if a ENV_VAR path has been defined via "Preferences->Configure Paths" and that ENV_VAR already exists on