Re: [Kicad-developers] Getting patches committed

2017-12-12 Thread Jeff Young
Hi Maciej, Thanks for the workaround for the progress dialog on OSX. The attached patch is a similar workaround but preserves more of the progress window functionality. Please have a look and let me know what you think. BTW, I’ve also noticed that the DRC window ends up behind the document wi

Re: [Kicad-developers] Getting patches committed

2017-12-11 Thread Wayne Stambaugh
Hey Jeff, The preferred method is for you to use git and committing your changes to your local repo (all commits in git are local) then using `git format-patch` to submit your patches. Using `git format-patch` eliminates the need for busy lead developers from having to enter your author informati

Re: [Kicad-developers] Getting patches committed

2017-12-11 Thread Chris Pavlina
Hi Jeff, Thanks for your patches! You've already done the right thing - KiCad uses a somewhat old-fashioned flow so submitting patches directly like that is the norm. I'll just take a little while for them to be reviewed. If you have patches that add features rather than fixing bugs, you can sub

[Kicad-developers] Getting patches committed

2017-12-11 Thread Jeff Young
Hi guys and gals, I’ve logged a few bugs that affect me and developed fixes for some of them[1]. After decades of svn and then a few years of retirement I don’t trust my git skills so I added the fixes as patches. What’s the process for getting them reviewed and committed? Thanks, Jeff. [1]