Re: [Kicad-developers] Version String using KICAD_VERSION

2019-12-17 Thread Wayne Stambaugh
It's been a while but if memory serves we stopped allowing KICAD_VERSION from being overridden because we were getting some odd package names. Only KICAD_VERSION_EXTRA user configurable. On 12/17/19 3:39 PM, Nick Østergaard wrote: > As far as I understand it the non-extra version is not supposed

Re: [Kicad-developers] Version String using KICAD_VERSION

2019-12-17 Thread Nick Østergaard
As far as I understand it the non-extra version is not supposed to be modified by the user/packager. So only adding custom stuff to the _EXTRA is supposed to work "right". On Tue, 17 Dec 2019 at 21:29, Steven A. Falco wrote: > > On 12/17/19 3:13 PM, Ian McInerney wrote: > > Is the version string

Re: [Kicad-developers] Version String using KICAD_VERSION

2019-12-17 Thread Steven A. Falco
On 12/17/19 3:13 PM, Ian McInerney wrote: > Is the version string supposed to be able to be overridden on the CMake > command line (e.g. specifying -DKICAD_VERSION="blah")? It appears that the > version string defined by CMake is always taking priority (then the git > string is used afterwards

[Kicad-developers] Version String using KICAD_VERSION

2019-12-17 Thread Ian McInerney
Is the version string supposed to be able to be overridden on the CMake command line (e.g. specifying -DKICAD_VERSION="blah")? It appears that the version string defined by CMake is always taking priority (then the git string is used afterwards if it exists), so this flag is being overwritten. I