Re: [Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Mark Roszko
>A tongue-in-cheeck suggestion: don't let any commit go to the repo if the >commit message doesn't have the word "because" at least once. Well, 2014 was still a older era in KiCad development On Sat, Dec 28, 2019 at 12:18 PM Eeli Kaikkonen wrote: > > > > On Sat, Dec 28, 2019 at 5:52 PM Ian

Re: [Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Nick Østergaard
Ok, sounds good to me. lør. 28. dec. 2019 17.09 skrev Ian McInerney : > I have run a build on both OSX and Linux (with wxWidgets 3.0) and don't > see any more problems with the deprecation warnings (I fixed up the OSX > ones by turning off the OpenGL deprecation warnings, since Apple has >

Re: [Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Eeli Kaikkonen
On Sat, Dec 28, 2019 at 5:52 PM Ian McInerney wrote: > The commit that did it is this one from 2014: > https://gitlab.com/kicad/code/kicad/commit/a3211b2b9e57a36c79f4ba2b00d0ac1aa30dceb3, > but the log is literally just: "disable deprecation warnings in Debug > build, change message in

Re: [Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Ian McInerney
I have run a build on both OSX and Linux (with wxWidgets 3.0) and don't see any more problems with the deprecation warnings (I fixed up the OSX ones by turning off the OpenGL deprecation warnings, since Apple has deprecated OpenGL, sigh...). I am going to go ahead and re-enable these warnings in

Re: [Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Ian McInerney
The commit that did it is this one from 2014: https://gitlab.com/kicad/code/kicad/commit/a3211b2b9e57a36c79f4ba2b00d0ac1aa30dceb3, but the log is literally just: "disable deprecation warnings in Debug build, change message in fp_lib_table.cpp," so I don't know what the actual reasoning behind the

Re: [Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Nick Østergaard
What does the git log tell you? I once did it in my build scripts because of: # Add flag to silence deprecation warnings # Due to bug in gcc 5.1,5.2 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65974 So it would spew out a tremendous amount of unrelated warnings and was useless. Maybe it was

[Kicad-developers] Why is -Wno-deprecated-declarations defined

2019-12-28 Thread Ian McInerney
Is there a reason we disable warnings on deprecated declarations in debug mode? Other than a lot of warnings about OpenGL being deprecated on MacOS (gee, thanks Apple) that we can turn off pretty easily, I see no reason we should be forcing this in our CMakeLists. I tried tracing this back through