[Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Wayne Stambaugh
I found a nasty wxFileSystemWatcher bug on windows (and possibly other platforms) when switching between a project on a mapped network drive to a project on a local drive. This crashes kicad every time. It doesn't crash when switching from a local drive to a mapped network drive. I fixed the pro

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Simon Wells
Hi Wayne, I have tested this on OSX with a mounted network drive, i think that is the most equivalent to a mapped network drive on windows. And do not see a crash, But i switched back to the local project using the recent project list. Does it occur if you use that list as well or only if you do a

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Wayne Stambaugh
Hey Simon, I was seeing the crash when switching back to a local project using the MRU list as well before my patch. After my patch, the problem went away. I didn't test opening a new local project but I suspect the crash would occur since the same code is called. I'm not sure how the GAL chang

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Simon Wells
It was when opening pcbnew, in each project. I will test your patch locally as soon as my updated build is done and see whether it causes any issues. Just thought i would test without first to see if it would be better for it to be ifdef'd out on osx. I haven't actually looked into the code but b

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Wayne Stambaugh
On 6/14/2016 4:34 PM, Simon Wells wrote: > It was when opening pcbnew, in each project. > > I will test your patch locally as soon as my updated build is done and > see whether it causes any issues. Just thought i would test without > first to see if it would be better for it to be ifdef'd out on

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Simon Wells
Does windows even support filesystemwatcher events on network drives? as would that not make for quite heavy loads on the network? On Wed, Jun 15, 2016 at 8:38 AM, Wayne Stambaugh wrote: > On 6/14/2016 4:34 PM, Simon Wells wrote: >> It was when opening pcbnew, in each project. >> >> I will test y

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Wayne Stambaugh
Apparently so. I just add a dummy text file to the remote project folder and the text file showed up in the kicad file window. I deleted the file and it disappeared from the kicad file window. Who knew? On 6/14/2016 4:47 PM, Simon Wells wrote: > Does windows even support filesystemwatcher event

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-14 Thread Simon Wells
Also tested the patch here, and works fine On Wed, Jun 15, 2016 at 8:49 AM, Wayne Stambaugh wrote: > Apparently so. I just add a dummy text file to the remote project > folder and the text file showed up in the kicad file window. I deleted > the file and it disappeared from the kicad file windo

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-15 Thread Wayne Stambaugh
Thanks Simon. I'll commit the patch as soon as I get a chance to test it on Linux. On 6/14/2016 5:12 PM, Simon Wells wrote: > Also tested the patch here, and works fine > > On Wed, Jun 15, 2016 at 8:49 AM, Wayne Stambaugh wrote: >> Apparently so. I just add a dummy text file to the remote proj

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-15 Thread Chris Pavlina
Tested on Linux with NFS and SSHFS mounts, no issue here either. On Wed, Jun 15, 2016 at 09:18:21AM -0400, Wayne Stambaugh wrote: > Thanks Simon. I'll commit the patch as soon as I get a chance to test > it on Linux. > > On 6/14/2016 5:12 PM, Simon Wells wrote: > > Also tested the patch here, an

Re: [Kicad-developers] wxFileSystemWatcher bug.

2016-06-16 Thread Wayne Stambaugh
Thanks for testing this Chris. I'll commit the patch some time today. On 6/15/2016 8:14 PM, Chris Pavlina wrote: > Tested on Linux with NFS and SSHFS mounts, no issue here either. > > On Wed, Jun 15, 2016 at 09:18:21AM -0400, Wayne Stambaugh wrote: >> Thanks Simon. I'll commit the patch as soon