Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

Wayne, I have recreated the patch set once again, and there is no reference to "printf" in any of these patch files. Please apply with the --ignore-whitepace flag, the file /include/lib_table_grid.h is full of MS-DOS line endings and I believe this is the cause. Patch set attached, hopefully

[Kicad-developers] Polygons: should have outline mode to draw Edge.Cuts

Hi, So polygons are very neat as they employ the nice polygon drawing features we are used to from zone drawing [*1]. A missing feature here is to _not_ have them filled but simply an outline. Why ? This would be _very_ useful to draw Edge.Cuts. Currently, the only way is to draw single lines,

[Kicad-developers] All kinds of glitches because polygons don't have an origin. Also: Outline ?

Hi, I am playing with polygons currently and notice that they only really can be created, but not moved or copied. A move (m) creates a phantom polygon on the screen that is offset from the polygon the same distance as the original polygon from the origin. A similar glitch happens when attempting

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Wayne, Friendly bump in case this has been forgotten - this thread has wandered around a fair bit. Patches 0001 through 0008 are in the email above. Thanks On Fri, Nov 17, 2017 at 11:05 PM, Oliver Walters < oliver.henry.walt...@gmail.com> wrote: > Wayne, > > Please ignore the previous patch

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

Oliver, I merged these patches into the development branch. Thanks, Wayne On 11/20/2017 04:35 PM, Oliver Walters wrote: > Wayne, > > Patch files attached. > > Once again the --ignore-whitespace flag will need to be used, I believe > it is because a line in kicad-plugin.h (46, corresponding

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

Wayne, Ok, apologies I thought I had addressed that (I haven't had a chance to go back and look at these patches). I'll do so tonight. On Tue, Nov 21, 2017 at 10:00 AM, Wayne Stambaugh wrote: > I looked at patches 3-6 and I didn't see where the printf was removed. > > On

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

I looked at patches 3-6 and I didn't see where the printf was removed. On 11/20/2017 05:47 PM, Oliver Walters wrote: > The printf() statement should be removed in one of the subsequent > patches, as should the removal of that line. I'm unable to check this > right now, are you able to confirm if

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

The printf() statement should be removed in one of the subsequent patches, as should the removal of that line. I'm unable to check this right now, are you able to confirm if one of the later patches fixes this problem? On Tue, Nov 21, 2017 at 9:44 AM, Wayne Stambaugh wrote:

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

I made a change to fix a bug with the default plugin type when appending a new row to the table which caused the conflict. This where I noticed the printf() debugging statement. I also noticed that it appears that you removed a scroll to row call and I'm not sure how to reconcile the conflict.

Re: [Kicad-developers] Library Editor refactor

Hello Maciej, I have some comments: First of all, it looks quite neat. Secondly I noticed a small thing. When I open the symbol library editor and it open in a small window and i resize it (make it bigger). The canvas contains some resizing artefacts, but if I zoom on step with the scroll whell

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

Wayne, Patch files attached. Once again the --ignore-whitespace flag will need to be used, I believe it is because a line in kicad-plugin.h (46, corresponding to 20170920) has a DOS newline instead of a UNIX newline. Thanks, On Tue, Nov 21, 2017 at 4:27 AM, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

Wayne, I think it is a whitespace issue, does it apply if you add --ignore-whitespace to git-am ? On Tue, Nov 21, 2017 at 1:03 AM, Wayne Stambaugh wrote: > Oliver, > > No go yet again. It looks like my commit 8b2b1381 is causing a conflict > with patch 2 so please rebase

Re: [Kicad-developers] Library Editor refactor

Orson, Go ahead a merge it if it's ready. The sooner we get this out to users for general testing the better. Thank you for getting the ready for the stable 5 release. Cheers, Wayne On 11/20/2017 10:20 AM, Maciej Sumiński wrote: > It was not as difficult as I initially thought, meaning the

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

Oliver, Please send me the latest patch(es) when you get a chance so I can get this merged. I cannot find it (them) in my inbox. I must have deleted the email by accident. Cheers, Wayne On 11/18/2017 8:39 PM, Oliver Walters wrote: > Wayne, > > Any further issues to address here? :) > > On

[Kicad-developers] [PATCH] Allow items to be moved from all anchor points

A change in commit 57310001350 caused kicad to stop allowing users to move items like footprints, arcs and lines using anchors other than the center point. This was caused by the new code that stores reference points for clipboard pasting, a call to updateModificationPoint() prevented some old

Re: [Kicad-developers] Library Editor refactor

It was not as difficult as I initially thought, meaning the libedit branch now also offers cut/copy/paste for graphical items in the library editor. There is nothing else I could add to the branch, so as long as there are no known bugs, I consider it ready for merging. Cheers, Orson On

Re: [Kicad-developers] [PATCH] LIB_TABLE tweaks

Oliver, No go yet again. It looks like my commit 8b2b1381 is causing a conflict with patch 2 so please rebase your patches. I also noticed a printf() debugging statement in patch 2. Please remove this and make sure there are not any other printf() statements in your patches. Sorry about

Re: [Kicad-developers] [PATCH] fix MANDATORY_FIELDS comparisons

Thank you Julius, I have just merged your patch. Regards, Orson On 11/18/2017 01:32 PM, Julius Schmidt wrote: > Apologies for the delay, but here's the patch as an attachment. > > On Thu, 9 Nov 2017, Wayne Stambaugh wrote: > >> Julius, >> >> I cannot git am this patch.  Apparently, the extra