Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-13 Thread Wayne Stambaugh
I finally had a chance to test this. Here are my concerns: * The Ctrl+mouse wheel behavior is completely broken on windows and I suspect Linux as well when the use mouse wheel to pan option is set. It acts just the Shift+mouse scroll wheel (scroll vertically). This needs to be fixed. The

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-13 Thread Bob Gustafson
You might try to compile with Clang on Fedora 21. It is pretty close to the OSX version and gives lots of warning messages (which correlate pretty well with the coverity diagnostics). Bob G On 03/13/2015 07:42 PM, inkblotter wrote: On 03/13/2015 04:00 PM, Wayne Stambaugh wrote: I finally

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-13 Thread inkblotter
On 03/13/2015 04:00 PM, Wayne Stambaugh wrote: I finally had a chance to test this. Here are my concerns: * The Ctrl+mouse wheel behavior is completely broken on windows and I suspect Linux as well when the use mouse wheel to pan option is set. It acts just the Shift+mouse scroll wheel

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-03 Thread Adam Wolf
Hi Wayne, Did you have any luck testing Garth's trackpad branch? Is the fact that it isn't enabled for pl_editor and 3D Viewer a dealbreaker? Is there something we can do to help this along? Thanks! Adam Wolf Cofounder and Engineer WL On Tue, Feb 24, 2015 at 11:05 PM, Garth Corral

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-03 Thread Bernhard Stegmaier
Hi, as Garth pointed out, it does work for 3D-Viewer… the only bad thing is that xy-panning is *always* enabled because it doesn’t respect the pcbnew preference setting. When I look into the some things I maybe will find some time to also look into that. PL editor is probably not a big deal

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-03 Thread Wayne Stambaugh
If it doesn't make it in this stable release, we can definitely merge it during the next development cycle. On 3/3/2015 4:54 PM, Adam Wolf wrote: I am not sure how much work it is to put it in pl_editor and 3d viewer. I am actually not familiar with the code. It is very possible we cannot

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-03 Thread Adam Wolf
I am not sure how much work it is to put it in pl_editor and 3d viewer. I am actually not familiar with the code. It is very possible we cannot get this in in time for the stable release. If so, let's get it in the next one! Adam Wolf On Tue, Mar 3, 2015 at 3:49 PM, Wayne Stambaugh

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-03-03 Thread Wayne Stambaugh
Hey Adam, I just ran out of time this weekend. Hopefully I can find some time this weekend to test it. If we do decide to merge it, I would prefer that it be enabled in the PL editor and the 3D viewer. I think users would find it confusing if the behavior was different between the rendering

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Bob Gustafson
Since the pinch part still needs to be developed for wxWidgets, it doesn't have to be in at the moment (my vote anyway). For zoom, the cmd + and cmd - will do fine, as long as the panning is both sideways and up-down. Zoom tends to be sensitive anyway. Having only panning as two finger trackpad

[Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Adam Wolf
Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is possible, what needs to be done, and who can do it? (Please, folks, this is not a thread for bug reports or debugging builds. If we're going to have any

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Bob Gustafson
Super!!! I can do testing as needed. I have magic mouse and MacAir with trackpad - running 10.10.2 Bob G On 02/24/2015 09:51 AM, Adam Wolf wrote: Hi folks, Can we start a discussion on if it would be appropriate to get Garth's trackpad support in before the feature freeze? If it is

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Wayne Stambaugh
As far as the wx patch goes, I don't have any issues with that. We have other OSX specific wxWidgets patches so I don't see why one more would hurt. However, the kicad patch must be thoroughly tested on Linux and Windows to make sure the default behavior is not changed for mouse wheel zooming

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Bernhard Stegmaier
I normally just do a bzr merge lp:~gcorral/kicad/osx-trackpad-gestures into the current head I am building and that’s it… Regards Bernhard On 24 Feb 2015, at 19:56, Wayne Stambaugh stambau...@gmail.com wrote: As far as the wx patch goes, I don't have any issues with that. We have other

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Bob Gustafson
I locally merged Garth's code a week or so ago and had difficulties - don't know if it was his files, my dependencies, or something else. Attached is the log of my merge - it was against r5431 and shows the names of the merged files. One of my problems was that after I built KiCad, after

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Bernhard Stegmaier
Hi, would be really great. I use it since Garth provided his branch and merge it regularly into my builds. Currently I only use the panning part, because you still have to patch wxWidgets for the pinch-to-zoom. I didn’t see any showstopper on my MacBook (TouchPad) and my desktop (Mighty and

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Adam Wolf
Bernhard, that is a good point. If Wayne et al are reluctant to patch wx for pinch-to-zoom, we can pull in just the panning changes. I have had Nick test on Linux--I seem to remember he said there wasn't an impact to him, but I am not sure if the changes are too subtle to notice. Basically, at

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Adam Wolf
Hi Wayne, The Waynelight worked! :) I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go back and re-read the details. Nick has merged this into a linux build, and used it there, and didn't

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Nick Østergaard
True, but it is quite some time ago, although not a first announcement. I have not seen if any new changes has been made after that. Also the patch adds an alternative pan/zoom mode, and still has the old style (almost unaffected). In the old mode, I think he swapped the actions of the ctrl+scroll

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Wayne Stambaugh
On 2/24/2015 2:13 PM, Adam Wolf wrote: Hi Wayne, The Waynelight worked! :) Too funny! Must resist urge to make batman jokes. I believe there is a minor change to scrolling behavior on all platforms. Garth has the details. I am not sure if it's something we care about--I need to go

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Garth Corral
Sorry for being so silent, folks. I'll try to send a summary later tonight with my take on these changes and the impediments to getting them in. Garth On Feb 24, 2015, at 11:17 AM, Nick Østergaard oe.n...@gmail.com wrote: True, but it is quite some time ago, although not a first

Re: [Kicad-developers] Getting Trackpad Support in before feature freeze?

2015-02-24 Thread Garth Corral
Okay, so yes, this code hasn’t been touched in a while but I’ve been merging lp:kicad about once a week. Here’s where I think things are. The pinch to zoom stuff, while optional, is both really useful for OS X trackpad users and probably the easiest to get in. I committed this separately