I believe Cristian's comments were directed to the author of the commit,
looped-in.
cheers,
Łukasz (the other one ;))
2016-06-18 20:24 GMT+02:00 Cristian Oneț :
> Is the start line always greater than zero? Isn't it 0 based like all
> sane programming structures which use indexes?
>
> On a side
https://bugs.kde.org/show_bug.cgi?id=315072
Łukasz Maszczyński changed:
What|Removed |Added
CC||luk...@maszczynski.net
--- Comment #27
hat it will be matched with an transaction imported using HBCI.
You've got a point.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109913/#review63994
--------
27a5cac
Diff: https://git.reviewboard.kde.org/r/109913/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
2013/10/10 Cristian Oneț :
> Łukasz,
>
> Do you have any idea what could be causing this? The only change I
> remember in this area is the transaction matching refactoring that you
> worked on.
Hi Cristian, Marko,
The refactoring I did might be the reason why the two branches behave
differently.
Hi Marko,
2013/10/9 :
> Hi Łukasz,
>
> On Oct 9, 2013, at 9:22 PM, Łukasz Maszczyński wrote:
>>
>> $ nm -CD libgwengui-cpp.so | grep CppGui::getCInterface
>> 3f30 T CppGui::getCInterface()
> Ha, there we are:
> ---
> $ nm /opt/macports-test/li
Hi,
2013/10/7 :
> On Oct 7, 2013, at 7:35 AM, Thomas Baumgart wrote:
>> yes, but did you also have Gwenhywfar build with the Qt fronend? I don't
>> think
>> that this is checked by cmake.
I did some updates in cmake recently to fix compilation errors with
gwenhywfar 4.7.0. I think it is now che
is used anywhere
in the project.
Unless package maintainers (.deb/.rpm/...) do some kinky stuff with those
defines, I think they should be removed.
- Łukasz Maszczyński
On Aug. 12, 2013, 11:13 a.m., Yury Kudryashov wrote
Ok, Cristian, thanks for info. I'll revert my changes related to libkdchart.
cheers,
Łukasz
2013/8/5 Cristian Oneț :
> Hi Łukasz,
>
> Please don't change the sources in libkdchart [1] :). This lib is
> written and maintained by people at KDAB. We keep a copy in our
> repository to make the build
far.cmake 41961e6
Diff: http://git.reviewboard.kde.org/r/111672/diff/
Testing
---
built with gwenhywfar 4.6.0 and 4.3.3
Thanks,
Łukasz Maszczyński
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
2013/7/24 Thomas Baumgart :
> I am running only Gwen 4.3.3. Probably need to upgrade
> here to fix this problem (which is certainly unrelated to the mentioned bug
> but is in the same location). I think the Gwen author changed a few things
> that hit us here.
That's what I suspected. I'm still cu
Hi Thomas,
I hope you'll be able to help me as you seem to be the most often
committer to cmake/modules/FindGwenhywfar.cmake :)
The Debian version I use (jessie = testing) upgraded Gwenhywfar
libraries from 4.3 to 4.6, which causes linking errors when building
KMM, specifically the kbanking plugi
https://bugs.kde.org/show_bug.cgi?id=320598
Łukasz Maszczyński changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=320598
Bug ID: 320598
Summary: update button disabled in payee view after suggesting
a default category for the payee
Classification: Unclassified
Product: kmymoney4
Version: git master
2013/5/8 Brendan Coupe :
> The problem occurs when you have already defined a default category that is
> different from the one that KMM would suggest and then click on the Suggest
> a category button. The category changes but the update button remains
> disabled. It appears that there is some logi
bd48f42ed15526ed
kmymoney/converter/matchfindertest.cpp
879b3c26781cf2b7177febb3b8816dc6abac7de7
kmymoney/converter/transactionmatchfinder.cpp
63619e183617e017343c26ffee044f21127a5cac
Diff: http://git.reviewboard.kde.org/r/109913/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
transaction will be a match as well, just like in "regular" (non-duplicate)
matching.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108489/#review26703
---
2013/2/16 Michael Wolfe :
> On 2/13/2013 9:52 AM, Jack wrote:
>>
>> Compare the OFX log from two different downloads. If they match (except
>> for timestamps) then there is a real bug. On the other hand, if something
>> like the bankId's don't match, then KMM/libofx is behaving correctly and you
2013/2/7 Michael Wolfe :
> On 2/6/2013 9:45 AM, Łukasz Maszczyński wrote:
>>
> Problem did NOT show up today when I tried to update; everything appears to
> be working now (just as I had the bug report mostly filled out!). I did NOT
> update or recompile since yesterday.
Hmm,
2013/2/6 Michael Wolfe :
>
> I have four accounts mapped for automatic OFX download (three credit cards
> and a checking account). As of just a few days ago, when I update the
> checking account (but not any of the other three), every transaction is
> treated as a new one and is added instead of m
isting transactions can be matched ("regular" match, not a
duplicate!) if none of them, or one of them has bankId assigned, but it should
not matter which one it is.
Looking forward to hear your opinions!
- Łukasz Maszczyński
On Jan. 19, 2013, 5:08 p.m., Łukasz Maszczyński wrote:
Hi,
guessing from the logs, the warning comes actually from the boost
package, which is used by gpgme. I don't think the warning does any
harm, I believe it's there because you use an old version of g++,
which does not implement C++0x features yet. It seems that C++0x has
been introduced in g++ 4.
2ed2e11651185afe2c4a14a3c
Diff: http://git.reviewboard.kde.org/r/108489/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
was
planning to introduce, but never did.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108396/#review25420
-------
9
kmymoney/widgets/register.cpp a469e7a8deac95da737c0227bccba62a0a208efe
kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp
89916a273fc0c136c75373f0ace0e579fc0a930d
Diff: http://git.reviewboard.kde.org/r/108398/diff/
Testing
---
compile
make test
Thanks,
Łukasz Maszczyński
___
fc0c136c75373f0ace0e579fc0a930d
Diff: http://git.reviewboard.kde.org/r/108398/diff/
Testing
---
compile
make test
Thanks,
Łukasz Maszczyński
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
/converter/imymoneyreader.h which is not used anywhere in
the project
Diffs
-
kmymoney/converter/imymoneyreader.h 6c1a61936c795997ae09fe06882e24459fa7e886
Diff: http://git.reviewboard.kde.org/r/108396/diff/
Testing
---
compile from clean workspace
Thanks,
Łukasz Maszczyński
work! :)
- Łukasz Maszczyński
On Jan. 3, 2013, 7:45 p.m., Marko Käning wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
> On Jan. 3, 2013, 6:55 p.m., Łukasz Maszczyński wrote:
> > Good, the tests are getting more and more readable with every update.
>
> Marko Käning wrote:
> I see now that also testTwoInstitutions() and testOneInstitution() are
> interfering, like my tests did before.
here, as it makes the test a bit less readable. But
it's also ok the way it is. (Same in the next test
kmymoney/mymoney/mymoneyfiletest.cpp
<http://git.reviewboard.kde.org/r/107619/#comment18863>
What is the purpose of all the QVERIFY-s here? (Same in the next test)
- Łukasz
> On Jan. 2, 2013, 7:54 p.m., Łukasz Maszczyński wrote:
> > kmymoney/mymoney/mymoneyfiletest.cpp, line 2112
> > <http://git.reviewboard.kde.org/r/107619/diff/5/?file=103701#file103701line2112>
> >
> > I think that dependency on test #1 could be easily remov
onDate and colocate the variable
with others (openingDate, closingDate) for better readability
- Łukasz Maszczyński
On Jan. 2, 2013, 1:31 a.m., Marko Käning wrote:
>
> ---
> This is an automatically generated e-mail. To reply
coded value in several places in the test - this is
error prone and may require unnecessary maintenance effort in the future. Use
a.id() as you did before.
- Łukasz Maszczyński
On Jan. 1, 2013, 9:13 p.m., Marko Käning wrote:
>
> --
2012/12/30 Marko Käning
>
> OK, Lukacz, I know where you are coming from.
>
> But I guess, as you said as well, this will require an overhaul of many tests!
>
> Hi Marko,
there are 9 more tests using testAddAccounts(). Basically I would start off
by checking inside these tests whether they refer
> On Dec. 30, 2012, 9:19 a.m., Łukasz Maszczyński wrote:
> > kmymoney/mymoney/mymoneyfiletest.cpp, line 2080
> > <http://git.reviewboard.kde.org/r/107619/diff/2/?file=102889#file102889line2080>
> >
> > Is it really required to call testAddAccounts() here?
mment18561>
I'd split it into two test functions - you're testing two independent cases
after all.
- Łukasz Maszczyński
On Dec. 29, 2012, 10:05 p.m., Marko Käning wrote:
>
> ---
> This is an automatically
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107758/#review23713
-----------
On Dec. 22, 2012, 8:58 a.m., Łukasz Maszczyński wrote:
>
> ---
the transaction and
schedule should really be matched.
Diffs (updated)
-
kmymoney/converter/mymoneystatementreader.h 886a5f1
kmymoney/converter/mymoneystatementreader.cpp ef04d51
Diff: http://git.reviewboard.kde.org/r/107758/diff/
Testing
---
make test
Thanks,
Łukasz
rd.kde.org/r/107758/diff/
Testing (updated)
---
make test
Thanks,
Łukasz Maszczyński
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
f5cbfa707140f3c
kmymoney/dialogs/transactionmatchfinder.cpp
cf326e9db480ac471eba96129c448e181ecbf97b
Diff: http://git.reviewboard.kde.org/r/107759/diff/
Testing (updated)
---
make test
manual test of the case from the description
Thanks,
Łukasz Maszczyński
___
/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
2012/12/10 Thomas Baumgart :
> Hi all,
>
> On Sunday 09 December 2012 09:32:01 Alvaro Soliverez wrote:
>>
>> I don't have the final word on this, but my vote is against adding boost as
>> a dependency. At least, until a real benefit for the application is shown.
>
> I second Alvaro's opinion on thi
h d09a4cd
kmymoney/dialogs/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
__
nce with boost has been horrible in the past.
>> Removing or adding features for minor versions, API changing, no ABI
>> compatibility and other stuff. It's not the kind of dependency I'd like to
>> maintain.
>>
>
------------
On Dec. 8, 2012, 4:49 p.m., Łukasz Maszczyński wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107137/
> -
cher.h d09a4cd
kmymoney/dialogs/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
___
cher.h d09a4cd
kmymoney/dialogs/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
_
ssed - I will do that in a separate review after
this one is finished.
Anyway I fixed this case and also some other(s) in rev. 6.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kd
h d09a4cd
kmymoney/dialogs/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
__
e current style. I'm just buying
> > some time with this to get a chance to test it better ;).
> >
> >
>
> Łukasz Maszczyński wrote:
> Regarding astyle-kmymoney.sh - looks like you're really buying yourself
> some time ;) since neither normalize nor asty
> On Nov. 28, 2012, 10:45 p.m., Cristian Oneț wrote:
> > kmymoney/converter/mymoneystatementreader.cpp, line 1498
> > <http://git.reviewboard.kde.org/r/107137/diff/4/?file=96699#file96699line1498>
> >
> > Why is this copy needed?
>
> Łuka
/dialogs/transactionmatcher.h d09a4cd
kmymoney/dialogs/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łu
e this
review even bigger.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107137/#review22731
---
On Nov. 28, 201
. I
fixed it in diff revision 4.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107137/#review22669
-------
On Nov. 2
/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
___
pp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
___
KMyMoney
reply, visit:
http://git.reviewboard.kde.org/r/107137/#review22625
---
On Nov. 27, 2012, 7:35 p.m., Łukasz Maszczyński wrote:
>
> ---
> This is an automatically generated e-m
tcher.h d09a4cd
kmymoney/dialogs/transactionmatcher.cpp c380877
kmymoney/dialogs/transactionmatchfinder.h PRE-CREATION
kmymoney/dialogs/transactionmatchfinder.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
kmymoney/converter/mymoneystatementreader.cpp, line 64
> > <http://git.reviewboard.kde.org/r/107137/diff/1/?file=92954#file92954line64>
> >
> > Same as above.
Will do.
- Łukasz
---
This is an automatically ge
which you
> > might not want to exclude.
> >
> > (Well, I haven't looked into QRegExp though to check whether my above
> > regexp is correct in this case.)
>
> Łukasz Maszczyński wrote:
> Just to make sure we're on the same page: validK
strings: " PAYEE", "PAYEE ", " ", " "
I believe the "[^ ]" regexp is correct.
- Łukasz
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard
2012/10/28 Thomas Baumgart :
> Łukasz et al,
>
> On Sunday 28 October 2012 12:38:02 mk-li...@email.de wrote:
>
>> Go to reviewboard ( https://git.reviewboard.kde.org/dashboard/ ) and post
>> your patch there after having registered as a KDE developer!
>
> I think you only need an account on identit
ey/dialogs/transactionmatcher.h d09a4cd
Diff: http://git.reviewboard.kde.org/r/107137/diff/
Testing
---
make test
Thanks,
Łukasz Maszczyński
___
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
Hello,
I'm working on a few improvements in the code which deals with
transaction importing - mainly the file:
kmymoney/converter/mymoneystatementreader.cpp
So far I partially refactored the named file (extract class & method).
To my best knowledge I didn't change the application behavior, and
be
Hello,
I've prepared a patch (attached) to improve payee matching.
In short:
disallowed matching payee by using match key of " " (single space) character.
More detailed explanation:
There are three possible options when it comes to payee matching:
1. no matching
2. by payee name
3. by list of ke
65 matches
Mail list logo
