[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #1 from Katrin Fischer --- *** Bug 7081 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer changed: What|Removed |Added Blocks||7315 -- You are receiving

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer changed: What|Removed |Added Version|3.14|master --- Comment #2 from

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Nicole C. Engard changed: What|Removed |Added Depends on||6427 CC|

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Bug 10021 depends on bug 6427, which changed state. Bug 6427 Summary: Rewrite of the accounts system http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 What|Removed |Added

[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #4 from Jonathan Druart --- Created attachment 54194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54194&action=edit Bug 10021: Drop table notifys and related code This patch drops the notifys table

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Summary|Remove dead(?) code related |Remove dead code related t

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving t

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #6 from Jonathan Druart --- There are still code in C4::Account about accountlines.notify_id (at least). -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #8 from Jonathan Druart --- Created attachment 68263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68263&action=edit Bug 10021: Drop columns notify_id and notify_level from accountlines It appears th

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Attachment #54194|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Co

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Attachment #68262|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Attachment #68263|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #12 from Jonathan Druart --- Created attachment 68421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68421&action=edit Bug 10021: Update DB changes -- You are receiving this mail because: You are wat

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #13 from Jonathan Druart --- Created attachment 68422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68422&action=edit Bug 10021: Remove accountlines columns - DBIC Schema changes -- You are receivin

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Attachment #68419|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #16 from Jonathan Druart --- Created attachment 68478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68478&action=edit Bug 10021: Drop columns notify_id and notify_level from accountlines It appears t

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #17 from Jonathan Druart --- Created attachment 68479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68479&action=edit Bug 10021: Update DB changes -- You are receiving this mail because: You are wat

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #18 from Jonathan Druart --- Created attachment 68480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68480&action=edit Bug 10021: Remove accountlines columns - DBIC Schema changes -- You are receivin

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comm

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 f

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #21 from Jonathan Druart --- Created attachment 68505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68505&action=edit Bug 10021: Remove notify columns in circ/branchoverdues.tt -- You are receiving

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #22 from Jonathan Druart --- Created attachment 68506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68506&action=edit Bug 10021: Restore "Pay fines" list Previous changes were wrong, the notify_id wa

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Josef Moravec changed: What|Removed |Added Attachment #68477|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rece

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #25 from Josef Moravec --- Created attachment 68795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68795&action=edit Bug 10021: Update DB changes Signed-off-by: Josef Moravec -- You are receiving th

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #24 from Josef Moravec --- Created attachment 68794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68794&action=edit Bug 10021: Drop columns notify_id and notify_level from accountlines It appears that

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #26 from Josef Moravec --- Created attachment 68796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68796&action=edit Bug 10021: Remove accountlines columns - DBIC Schema changes Signed-off-by: Josef Mo

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #27 from Josef Moravec --- Created attachment 68797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68797&action=edit Bug 10021: Remove notify columns in circ/branchoverdues.tt Signed-off-by: Josef Mora

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #28 from Josef Moravec --- Created attachment 68798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68798&action=edit Bug 10021: Restore "Pay fines" list Previous changes were wrong, the notify_id was a

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #30 from Marcel de Rooy --- FAIL C4/Members.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL C4/Overdues.pm FAIL pod coverage

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #31 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Created attachment 68263 [details] [review] > Bug 10021: Drop columns notify_id and notify_level from accountlines > > It appears that has never

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #32

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #33 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #30) > When you remove a sub from a module without full coverage, this is the > result. Something for QA tools ? Yes, could be improved. POD failures

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #34 from Jonathan Druart --- Created attachment 68920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68920&action=edit Bug 10021: (QA follow-up) Rename variables To avoid $account, $accounts and @acco

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #35 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #33) > (In reply to Marcel de Rooy from comment #32) > > QA Comment: > > > > GetOverduesForBranch > > Please add a test. You make some fundamental cha

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off -- You are rec

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68793|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68796|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68795|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68797|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68794|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68920|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Attachment #68798|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Con

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #43

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comm

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #45 from Jonathan Druart --- Created attachment 69695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69695&action=edit Bug 10021: Remove notify headers from pay*.tt -- You are receiving this mail bec

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Jonathan Druart changed: What|Removed |Added Attachment #69695|0 |1 is obsolete|

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #47 from Jonathan Druart --- Created attachment 69698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69698&action=edit Bug 10021: Only display outstanding fines in 'Pay fines' -- You are receiving th

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 --- Comment #48 from Jonathan Druart --- (In reply to Jonathan Druart from comment #46) > Created attachment 69696 [details] [review] > Bug 10021: Remove notify headers from pay*.tt (In reply to Jonathan Druart from comment #47) >

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|