https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Fridolin SOMERS changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nicole C. Engard changed:
What|Removed |Added
CC|neng...@gmail.com |
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nicole C. Engard changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Suzanne Fayle changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #91 from Jonathan Druart
---
We need to fix these tests ASAP, a bug may be hidden.
I have managed to reproduce the failure on my local install once, but cannot
anymore.
It would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #90 from Katrin Fischer ---
Tests are failing on Jenkins, but passing when I run them locally:
http://jenkins.koha-community.org/job/Koha_master_D7/lastCompletedBuild/testReport/
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Brendan Gallagher changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #85 from Katrin Fischer ---
Created attachment 49767
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49767=edit
[PASSED QA] Bug 10612 [Follow-up] Combine and clarify menu items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #88 from Katrin Fischer ---
Created attachment 49770
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49770=edit
[PASSED QA] Bug 10612: (QA followup)
Rename
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #87 from Katrin Fischer ---
Created attachment 49769
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49769=edit
[PASSED QA] Bug 10612 - Unit tests
Signed-off-by: Katrin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #86 from Katrin Fischer ---
Created attachment 49768
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49768=edit
[PASSED QA] Bug 10612: Follow-up - correcting icon to be Font
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer changed:
What|Removed |Added
Attachment #49596|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #83 from Nick Clemens ---
Created attachment 49741
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49741=edit
Bug 10612: (QA followup)
Rename not_borrowered_since to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #49694|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #81 from Katrin Fischer ---
Tested:
- patron with fines - not deleted
- patron with issues - not deleted
- patron who is a guarantor - not deleted
- patron who has none of that and is not a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #80 from Nick Clemens ---
Created attachment 49694
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49694=edit
Bug 10612 - Unit tests
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #78 from Katrin Fischer ---
Created attachment 49607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49607=edit
Bug 10612: Follow-up - correcting icon to be Font Awesome
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #48890|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #77 from Nick Clemens ---
(In reply to Jonathan Druart from comment #74)
> > +use Koha::Database;
> Not used.
Removed
> @@ +128,5 @@
> I don't understand this line, GetBorrowersToExpunge won't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #75 from Nick Clemens ---
Created attachment 49596
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49596=edit
Bug 10612 - Add ability to delete patrons with batch patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #48892|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #74 from Jonathan Druart
---
Comment on attachment 48890
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48890
[SIGNED-OFF] Bug 10612 - Add ability to delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #48891|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #72 from Owen Leonard ---
Created attachment 48891
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48891=edit
Bug 10612 [Follow-up] Combine and clarify menu items
This follow-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Needs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Owen Leonard changed:
What|Removed |Added
Attachment #4|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #48881|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #48833|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47478|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #67 from Jonathan Druart
---
Nick, it's much more better, but there is something wrong.
The change to C4::Members::GetBorrowersToExpunge is not consistent: we expect
the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47393|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Patch complexity|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Assignee|jwea...@bywatersolutions.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Depends on|15642 |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #65 from Nick Clemens ---
Created attachment 47396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47396=edit
Bug 10612 - Change _skip_borrowers_with_fines to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47259|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|BLOCKED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47224|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47225|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #60 from Nick Clemens ---
(In reply to Jonathan Druart from comment #57)
> Undefined subroutine ::_skip_borrowers_with_nonzero_balance_or_issues
> called at
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47255|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47226|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #46279|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #46834|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #47153|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #56 from Nick Clemens ---
(In reply to Jonathan Druart from comment #51)
> It would be better to use Koha::List::Patron instead.
Done
> I'd make more sense to pass the non empty patron lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #52 from Nick Clemens ---
Created attachment 47153
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47153=edit
Bug 10612 [QA Followup]
1 - Use Koha::List::Patron
2 - Return only
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Depends on|10565
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #51 from Jonathan Druart
---
Comment on attachment 46279
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46279
Bug 10612 - Add ability to delete patrons with
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
natasha changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
natasha changed:
What|Removed |Added
Attachment #46280|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jesse Weaver changed:
What|Removed |Added
Attachment #46239|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #49 from Nick Clemens ---
Created attachment 46280
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46280=edit
Bug 10612 - [QA followup] Use font awesome icons in patron lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens changed:
What|Removed |Added
Attachment #41363|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #47 from Nick Clemens ---
I squashed patches, rebased, and added a check for issues to the subroutine:
_skip_borrowers_with_nonzero_balance
making it:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #44 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #43)
> Hm, it seems I tested the same as you but with very different results...
> what could be the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #43 from Katrin Fischer ---
Hm, it seems I tested the same as you but with very different results... what
could be the difference? My results look worrysome, especially the double
existance of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #42 from Katrin Fischer ---
- Add 4 patrons to a patron list, one has a checkout
- Select patron list in batch tool
- Reports: 4 patrons will be deleted (misleading, only 3 should)
- Choose test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nicole Engard (ByWater) nic...@bywatersolutions.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #37 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
(In reply to Katrin Fischer from comment #36)
Hi Kyle,
could you do me a favour and try the test case I described? I feel if we
push this without
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #40 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
Created attachment 41365
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41365action=edit
Bug 10612 [QA Followup] - Remove user icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:
What|Removed |Added
Attachment #36313|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #39 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
Created attachment 41364
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41364action=edit
Bug 10612 [Code cleanup] - Rename some
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #41 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan, thx for testing! - I will rerun my test and see if I did something
differently.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle,
could you do me a favour and try the test case I described? I feel if we push
this without checking the basic functionality of the tool is correct, we will
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #34 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41289
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41289action=edit
Bug 10612 [QA Followup] - Remove user icons from buttons
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
Status|In Discussion |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Assignee|k...@bywatersolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off |In
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #31 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36314
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36314action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables
To
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Attachment #36314|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #28779|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36311
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36311action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables
To
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Jacek Ablewicz a...@biblos.pk.edu.pl changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #28 from Owen Leonard oleon...@myacpl.org ---
(In reply to Jacek Ablewicz from comment #27)
Only patrons with non-zero account balance (with unpaid fines/charges) are
explicitly excluded when deleting from a list.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #26 from Owen Leonard oleon...@myacpl.org ---
Are patron automatically excluded from deletion for some reason? I tried to
delete based on a patron list that contains 82 patrons and the tool offers to
delete 2 patrons.
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Heather Braum hbr...@nekls.org changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #25 from Nick Clemens n...@quecheelibrary.org ---
Understood on all, I was unclear in my comment though, sorry for that
I checked off all 4 patrons for deletion, the deletion tool said it would
delete 3, and that it had
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Signed Off |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Nick Clemens n...@quecheelibrary.org changed:
What|Removed |Added
Status|Needs Signoff |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Summary|Add ability to delete |Add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #22837|0 |1
1 - 100 of 102 matches
Mail list logo