https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Nick Clemens changed:
What|Removed |Added
Blocks||36532
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to master|Needs documenting
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #76 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #75 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #74)
> *** Bug 33442 has been marked as a duplicate of this bug. ***
Nice to see this one :)
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #74 from Marcel de Rooy ---
*** Bug 33442 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
AspenCat Team changed:
What|Removed |Added
CC||aspencatt...@clicweb.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #73 from Christopher Brannon ---
(In reply to Jonathan Druart from comment #67)
> Not blocker, but noting:
> 2. We don't have access to already read notes. Could be added later if
> needed.
Staff do, patrons do not.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #72 from Jonathan Druart ---
Created attachment 148611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148611=edit
Bug 12029: Remove 'params' from filter_by_unread
It's not used and not needed, you can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #71 from Jonathan Druart ---
Created attachment 148610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148610=edit
Bug 12029: Ability for patrons to dismiss OPAC messages
This enhancement adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #70 from Jonathan Druart ---
Created attachment 148609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148609=edit
Bug 12029: Tests
Signed-off-by: Christopher Brannon
Signed-off-by: Jonathan Druart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #69 from Jonathan Druart ---
Created attachment 148608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148608=edit
Bug 12029: Schema updates
Signed-off-by: Christopher Brannon
Signed-off-by: Jonathan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Jonathan Druart changed:
What|Removed |Added
Attachment #147522|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #67 from Jonathan Druart ---
Not blocker, but noting:
1. A REST API endpoint would have been better for this job
2. We don't have access to already read notes. Could be added later if needed.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Blocks||33097
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Biblibre Sandboxes changed:
What|Removed |Added
Attachment #147521|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Biblibre Sandboxes changed:
What|Removed |Added
Attachment #146708|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Biblibre Sandboxes changed:
What|Removed |Added
Attachment #146707|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Biblibre Sandboxes changed:
What|Removed |Added
Attachment #146706|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Aleisha Amohia changed:
What|Removed |Added
Attachment #146709|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #59 from Katrin Fischer ---
It's definitely the issue with the sandboxes we ran into today multiple times.
Better to have this Needs SO then stuck in FQA.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #58 from Christopher Brannon ---
Feel free to sign off on it then. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Aleisha Amohia changed:
What|Removed |Added
Text to go in the|Sponsored by koha-US|This enhancement adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #55 from Aleisha Amohia ---
Created attachment 146709
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146709=edit
Bug 12029: Ability for patrons to dismiss OPAC messages
This enhancement adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #54 from Aleisha Amohia ---
Created attachment 146708
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146708=edit
Bug 12029: Tests
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #53 from Aleisha Amohia ---
Created attachment 146707
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146707=edit
Bug 12029: Schema updates
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Aleisha Amohia changed:
What|Removed |Added
Attachment #137646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Aleisha Amohia changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Rebecca Coert changed:
What|Removed |Added
CC||rco...@arlingtonva.us
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #51 from Martin Renvoize ---
Must admit, I didn't do a code review here.. just confirmed the feature worked
as described.
As you've adopted this one Owen, feel free to ask for help to update it to more
usual practices..
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #50 from Jonathan Druart ---
+my $borrowernumber = $cgi->param('borrowernumber') || undef;
$borrowernumber MUST be retrieved from get_template_and_user (or another
C4::Auth method), not from the query parameters.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #49 from Jonathan Druart ---
There is NO authentication check, everybody (no need to be loggedin) can delete
a message. This is a hard fail.
Really, it would have been better (and easier for everybody) to follow the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #48 from Jonathan Druart ---
DB naming (suffix _date), see bug 31150.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #47 from Christopher Brannon ---
Looks good to me as well.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
ByWater Sandboxes changed:
What|Removed |Added
Attachment #137523|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
ByWater Sandboxes changed:
What|Removed |Added
Attachment #137522|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
ByWater Sandboxes changed:
What|Removed |Added
Attachment #137521|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #43 from Martin Renvoize ---
(In reply to Christopher Brannon from comment #42)
> I had no idea that I needed to do that. How can I tell?
It's not entirely trivial to tell.. it's either a good habit to get into to
just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #42 from Christopher Brannon ---
(In reply to Martin Renvoize from comment #37)
> I've added the Schema patch here to make this easier to test on sandboxes...
>
>
> However.. please note when you see an error like this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137520|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137519|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137518|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #36 from Martin Renvoize ---
Created attachment 137520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137520=edit
Bug 12029: DBIC Schema
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137435|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137434|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Assignee|ivan.marquez@autoparallel.c |oleon...@myacpl.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #31 from Owen Leonard ---
Created attachment 137435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137435=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Attachment #130516|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #29 from Katrin Fischer ---
Thx for the update, Christopher.
If we could get the unit tests within the next few days, we still might make
the release.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #28 from Christopher Brannon ---
Auto-Parallel, who wrote the patch, is supposed to be uploading the unit tests.
We are waiting for them to do this.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #27
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #26 from Owen Leonard ---
Thank you for the follow-up Hayley!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Attachment #132918|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Marie changed:
What|Removed |Added
CC||marie.hed...@musikverket.se
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Hayley Pelham changed:
What|Removed |Added
CC||hayleypel...@catalyst.net.n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #23 from Hayley Pelham ---
Created attachment 132918
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132918=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #22 from Martin Renvoize ---
Comment on attachment 130516
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516
Bug 12029: Patrons should be able to delete their patron messages
Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #20 from Katrin Fischer ---
Hi Bill, thx for providing a patch!
Jonathan provided you some good feedback on things that need to be fixed,
please let us know if something is not clear!
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Kyle M Hall changed:
What|Removed |Added
Attachment #130515|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Lisette Scheer changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Kyle M Hall changed:
What|Removed |Added
Attachment #130514|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #15 from Owen Leonard ---
Created attachment 130514
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130514=edit
Bug 12029: Patrons should be able to delete their patron messages
This patch adds an
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #14 from George Williams (NEKLS) ---
(In reply to Christopher Brannon from comment #13)
> Updated per Auto-Parallel's request:
>
> * A new field (ie patron_read) will be added to the messages table to record
> that the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #13 from Christopher Brannon ---
Updated per Auto-Parallel's request:
* A new field (ie patron_read) will be added to the messages table to record
that the patron has read the message.
* If a message is set to display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #12 from Christopher Brannon ---
Okay, based on this discussion, we can simplify the scope of this project:
* A new field (ie patron_read) will be added to the messages table to record
that the patron has read the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #11 from Katrin Fischer ---
> Oh, wait. I think I understand. So, if we flag the it as read by putting a
> date in the new field, we just turn off visibility on the opac side. We
> don't have to touch the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #10 from Christopher Brannon ---
(In reply to Owen Leonard from comment #9)
> (In reply to Christopher Brannon from comment #7)
>
> > When a message is marked as B (patron), it is seen on BOTH sides, by patron
> > and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #9 from Owen Leonard ---
(In reply to Christopher Brannon from comment #7)
> When a message is marked as B (patron), it is seen on BOTH sides, by patron
> and staff. Changing it to L (staff) would accomplish dismissing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #8 from Christopher Brannon ---
One small adjustment I would suggest, and should be easy enough, is to add the
date of when the message was read to the label on the staff side. Perhaps the
date could be the flag in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #7 from Christopher Brannon ---
(In reply to Owen Leonard from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > Why the change from B to L?
>
> I agree that this doesn't seem to be a necessary step.
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #5 from Katrin Fischer ---
Probably should stay away... but since this question could also come up later
in the process...: Why the change from B to L? For me that indicates for whose
eyes the message was initially
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #4 from Autoparallel ---
Since this is what came out from the committee we will consider it as the
official scope for this project and what will be built.
Please be aware that any changes to this scope will have to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #3 from Christopher Brannon ---
The koha-US development committee met and has determined the following criteria
for this new feature:
* A new field (ie patron_read) will be added to the messages table to record
that the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #2 from Christopher Brannon ---
(In reply to George Williams (NEKLS) from comment #1)
> We have AllowAllMessageDeletion set to "Don't allow" so I'd like to see a
> system preference that can turn this feature on or off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Autoparallel changed:
What|Removed |Added
CC||ivan.marquez@autoparallel.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Version|unspecified |master
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
koha-US bug tracker changed:
What|Removed |Added
Text to go in the||Sponsored by koha-US
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Lisette Scheer changed:
What|Removed |Added
CC||lisettesla...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
koha-US bug tracker changed:
What|Removed |Added
CC||bugzi...@koha-us.org
100 matches
Mail list logo
