https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Owen Leonard changed:
What|Removed |Added
Blocks||34437
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Owen Leonard changed:
What|Removed |Added
Blocks||33906
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Owen Leonard changed:
What|Removed |Added
Blocks||33077
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Jonathan Druart changed:
What|Removed |Added
Blocks||24797
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Jonathan Druart changed:
What|Removed |Added
Blocks||24068
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #146 from Julian Maurice ---
(In reply to Caroline Cyr La Rose from comment #145)
> Woohoo! I did my first contextualization (locally)!
>
> I was wondering what is the process to add a contextualization to the
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Jonathan Druart changed:
What|Removed |Added
Blocks|15522 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Fridolin SOMERS changed:
What|Removed |Added
Blocks||22080
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Katrin Fischer changed:
What|Removed |Added
Blocks||22050
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Blocks||21895
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Victor Grousset/tuxayo changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||21823
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #143 from Katrin Fischer ---
For the next one getting stuck:
sudo apt-get install libintl-perl
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #142 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #81741|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Blocks||21789
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #141 from Julian Maurice ---
(In reply to Nick Clemens from comment #140)
> This updates dependencies - will we be able to get these packaged and ready
> for release?
The added dependencies are already packaged since
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Nick Clemens changed:
What|Removed |Added
Keywords||dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #138 from Jonathan Druart
---
Created attachment 81742
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81742=edit
Bug 15395: Use POSIX::setlocale
To keep compatibility with jessie (that have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #139 from Jonathan Druart
---
Created attachment 81743
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81743=edit
Bug 15395: Fix QA failure - filter not found
Signed-off-by: Jonathan Druart
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #137 from Jonathan Druart
---
Created attachment 81741
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81741=edit
Bug 15395: Example usage of I18N Template::Toolkit plugin
Signed-off-by: Marc Véron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #136 from Jonathan Druart
---
Created attachment 81739
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81739=edit
Bug 15395: Do not process template files that do not use i18n.inc
It should make the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #132 from Jonathan Druart
---
Created attachment 81735
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81735=edit
Bug 15395: Make msgmerge quiet
Signed-off-by: Jonathan Druart
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #135 from Jonathan Druart
---
Created attachment 81738
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81738=edit
Bug 15395: Make QA test script happy
It is not totally happy because of the template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #133 from Jonathan Druart
---
Created attachment 81736
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81736=edit
Bug 15395: Do not use nl_putenv, use $ENV instead
nl_putenv is only useful on Windows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #134 from Jonathan Druart
---
Created attachment 81737
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81737=edit
Bug 15395: Add unit tests for extract_messages_from_templates
Because LangInstaller
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Jonathan Druart changed:
What|Removed |Added
Attachment #81152|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #130 from Jonathan Druart
---
I am in favor of these patches as they will help us to handle plurals much
better than we do so far.
I have been working (test/review) on these patch for a long time and I think we
should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #129 from Victor Grousset/tuxayo ---
> I don't love the sound of these patches... (or the implementation of
> Koha::I18N).
What do you mean?
> What's performance like for handling all the translations at run time?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #127 from Katrin Fischer ---
(In reply to Julian Maurice from comment #124)
> I wrote
> https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,
> _context,_and_more_(RFC)
>
> and initiated a thread on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #126 from Julian Maurice ---
(In reply to Katrin Fischer from comment #123)
> Hm, looking at the example, it seems quite complicated and not sure I
> understand it. Do we really want to do that to all our strings?
It
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #125 from Julian Maurice ---
Moved the wiki page to
https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC
(parentheses break URL)
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #124 from Julian Maurice ---
I wrote
https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_(RFC)
and initiated a thread on Framavox to gather opinions:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Serhij Dubyk changed:
What|Removed |Added
CC||du...@ukr.net
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Katrin Fischer changed:
What|Removed |Added
CC||oleon...@myacpl.org
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #122 from Katrin Fischer ---
Hi Julian,
it's Saturday! ;)
I think some best practice examples like this one from the comments would be
good:
[% IF count %]
[% tnx('{count} item', '{count} items', count, { count =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #121 from Julian Maurice ---
(In reply to Katrin Fischer from comment #120)
> Hi all,
>
> really happy to see this one moving!
Really happy too!
>
> Maybe time to think about a few things:
>
> - When is the best
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #119 from Julian Maurice ---
Created attachment 81167
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81167=edit
Screenshot of Pootle with plural translations and context
(In reply to Julian Maurice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #118 from Julian Maurice ---
(In reply to Julian Maurice from comment #105)
> (In reply to Jonathan Druart from comment #102)
> > Code review:
> > 1. Not important but the Koha.po file provided for the tests are not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #117 from Julian Maurice ---
(In reply to Jonathan Druart from comment #104)
> (In reply to Julian Maurice from comment #92)
> > Extraction of strings from templates is a bit complicated and use
> > Template::Parser and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #116 from Julian Maurice ---
(In reply to Jonathan Druart from comment #107)
> (In reply to Julian Maurice from comment #105)
> > > 3. The content from the .inc files are added to the .po because they
> > > contain
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #77476|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #114 from Julian Maurice ---
Created attachment 81158
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81158=edit
Bug 15395: Do not process template files that do not use i18n.inc
It should make the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #113 from Julian Maurice ---
Created attachment 81157
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81157=edit
Bug 15395: Make QA test script happy
It is not totally happy because of the template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #111 from Julian Maurice ---
Created attachment 81155
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81155=edit
Bug 15395: Do not use nl_putenv, use $ENV instead
nl_putenv is only useful on Windows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #112 from Julian Maurice ---
Created attachment 81156
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81156=edit
Bug 15395: Add unit tests for extract_messages_from_templates
Because LangInstaller use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #109 from Julian Maurice ---
Created attachment 81153
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81153=edit
Bug 15395: Require Locale::Messages 1.24
1.21 fixes a bug in the way environment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #110 from Julian Maurice ---
Created attachment 81154
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81154=edit
Bug 15395: Make msgmerge quiet
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #77475|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #107 from Jonathan Druart
---
(In reply to Julian Maurice from comment #105)
> > 3. The content from the .inc files are added to the .po because they contain
> > TT blocks on several lines. Maybe we should have a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #106 from Julian Maurice ---
(In reply to Jonathan Druart from comment #104)
> BTW do you know what is the ". done." outputted by install?
It is a message outputted by msgmerge, I will make it quiet
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #105 from Julian Maurice ---
(In reply to Jonathan Druart from comment #102)
> Code review:
> 1. Not important but the Koha.po file provided for the tests are not taken
> into account. Maybe it could be better to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #104 from Jonathan Druart
---
(In reply to Julian Maurice from comment #92)
> Extraction of strings from templates is a bit complicated and use
> Template::Parser and PPI. Template is compiled into Perl code and then
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #103 from Julian Maurice ---
(In reply to Jonathan Druart from comment #101)
> So, from what I understand the third form (for 0) will be not supported,
> unless we change the Plural-Forms (are we really supposed to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #102 from Jonathan Druart
---
Code review:
1. Not important but the Koha.po file provided for the tests are not taken into
account. Maybe it could be better to generate the .mo from the tests?
2. No tests provided for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #101 from Jonathan Druart
---
It works better instead.
Just noting:
== es-ES - nplurals=2; plural=(n != 1); ==
msgid "{count} item"
msgid_plural "{count} items"
msgstr[0] "Uno ejemplar"
msgstr[1] "{count} ejemplares"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #100 from Julian Maurice ---
(In reply to Jonathan Druart from comment #99)
> > - According to
> > https://localization-guide.readthedocs.io/en/latest/l10n/pluralforms.html
> > Spanish has 2 "plural forms" (one of which
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #99 from Jonathan Druart
---
(In reply to Julian Maurice from comment #98)
> Hi Jonathan, and thanks for testing.
>
> There are several problems here:
> - You must not modify msgid_plural in the PO file, it's a string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #98 from Julian Maurice ---
Hi Jonathan, and thanks for testing.
There are several problems here:
- You must not modify msgid_plural in the PO file, it's a string identifier
just like msgid.
- According to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #97 from Jonathan Druart
---
Also I should note that I had to amend the code, the tests were failing
# Failed test 'use Koha::I18N;'
# at t/Koha/I18N.t line 10.
# Tried to use 'Koha::I18N'.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #96 from Jonathan Druart
---
Sorry but I still do not manage to make it works.
Naive test, following the test plan:
0/ do not apply the patch
1/ perl translate update es-ES && perl translate install es-ES
2/ git commit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #95 from Julian Maurice ---
JS part is in bug 21156
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Blocks||21156
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #94 from Julian Maurice ---
To ease testing I squashed all the patches, merged the test plans, and removed
the JS part (I will re-add it in another bug).
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #73901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #93 from Julian Maurice ---
Created attachment 77476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77476=edit
Bug 15395: Example usage of I18N Template::Toolkit plugin
Signed-off-by: Marc Véron
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Blocks||20988
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #91 from Julian Maurice ---
Created attachment 76330
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76330=edit
Bug 15395: Fix translation when text contains non-ASCII characters
msgid, msgid_plural
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #89 from Julian Maurice ---
Created attachment 76328
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76328=edit
Bug 15395: Keep JS translations separated from others
It saves the browser from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #90 from Julian Maurice ---
Created attachment 76329
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76329=edit
Bug 15395: Extract strings from TT BLOCKs too
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71952|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71951|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #88 from Julian Maurice ---
Patches rebased on master
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71950|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71943|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71948|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71945|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71944|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71941|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71942|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71949|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71946|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71947|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #71940|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #73 from Julian Maurice ---
Created attachment 71951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71951=edit
Bug 15395: Improve TT plugin example
Include the number in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
--- Comment #74 from Julian Maurice ---
Created attachment 71952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71952=edit
Bug 15395: Fix for libintl-perl >= 1.25
Since 1.25, LANGUAGE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #70975|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #70976|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #70974|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #62333|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #62332|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #62331|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #62330|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
Julian Maurice changed:
What|Removed |Added
Attachment #62328|0
1 - 100 of 110 matches
Mail list logo