[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #53 from Marcel de Rooy --- Created attachment 61748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61748=edit Bug 17560: Add a message when a patron checking in using the

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #54 from Marcel de Rooy --- Created attachment 61749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61749=edit Bug 17560: Improve strenght of hold existence test This patch

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #55 from Marcel de Rooy --- Created attachment 61750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61750=edit Bug 17560: Improve wordings Signed-off-by: Marcel de Rooy

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #52 from Marcel de Rooy --- Created attachment 61747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61747=edit Bug 17560: Update the wording when a patron places a hold at the

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Attachment #57241|0

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #50 from Marcel de Rooy --- Created attachment 61745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61745=edit Bug 17560: Update current code This patch updates the current

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #51 from Marcel de Rooy --- Created attachment 61746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61746=edit Bug 17560: Hold fee placement at point of checkout Currently,

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #48 from Jonathan Druart --- As you may have noticed the Circulation code is not robust and does not give us useful return values or enough trust in the actions that have been

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #47 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #46) > What may happen is this: I set rental to 6, hold fee to 7 and noissuecharge > to 5 (a weird combination), Koha still

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #46 from Marcel de Rooy --- I obsoleted the last patch. It is not really what I had in mind. I found out what my problem was in the charges display: HoldsInNoissuesCharge = Dont include

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Attachment #61691|0

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #45 from Marcel de Rooy --- > > [2] Provide a message to the SIP terminal at checkout time. (a.o. comment31, > > 34) > > Note that Colin suggested to do this on another report. > > In that case

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #44 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #41) > (In reply to Marcel de Rooy from comment #40) > > [1] If we checkout in the staff client, wouldn't it be good to also

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #43 from Marcel de Rooy --- +$hold_existed = Koha::Holds->search({ -or => { 'biblionumber' => $item->biblionumber, 'itemnumber' => $item->itemnumber}})->count; versus +

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #42 from Jonathan Druart --- Created attachment 61691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61691=edit Bug 17560: Add a message when a patron

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #41 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #40) > [1] If we checkout in the staff client, wouldn't it be good to also show a > message? (Just like the

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #40 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #36) > Marcel, by chance could you rephrase with what you want on QAing? Of course :) [1] If we checkout in the staff

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #39 from Marcel de Rooy --- (In reply to Alex Sassmannshausen from comment #33) > Fwiw, I agree with this reasoning you, Marcel (though I think the tense > 'collecting' is not quite right): >

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Attachment #61301|0

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #36 from Jonathan Druart --- Marcel, by chance could you rephrase with what you want on QAing? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #35 from Marcel de Rooy --- (In reply to Colin Campbell from comment #34) > (In reply to Marcel de Rooy from comment #32) > > Just for completeness: > > Colin: See comment 24. The currently

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #34 from Colin Campbell --- (In reply to Marcel de Rooy from comment #32) > Just for completeness: > Colin: See comment 24. The currently applied hold fee at the time of placing > a hold

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #33 from Alex Sassmannshausen --- (In reply to Marcel de Rooy from comment #22) > (In reply to Alex Sassmannshausen from comment #20) > > Claire and I have deliberated for a bit at

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #32 from Marcel de Rooy --- Just for completeness: Colin: See comment 24. The currently applied hold fee at the time of placing a hold is not shown in SIP. I guess that placing a hold via SIP is

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #31 from Marcel de Rooy --- (In reply to Colin Campbell from comment #29) > Sip calls CanBookBeIssued and will need to be told in the return that the > issue requires a fee to be paid - It will

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #30 from Marcel de Rooy --- (In reply to Fiona Borthwick from comment #27) > (In reply to Marcel de Rooy from comment #23) > > Just another question: If we checkout in the staff client, wouldn't

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Colin Campbell changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #28 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #26) > Comment from Colin regarding SIP (He's on leave today, so I've replied for > him after a conversation about this

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #27 from Fiona Borthwick --- (In reply to Marcel de Rooy from comment #23) > Just another question: If we checkout in the staff client, wouldn't it be > good to also show a message? A

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Fiona Borthwick changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #26 from Martin Renvoize --- Comment from Colin regarding SIP (He's on leave today, so I've replied for him after a conversation about this yesterday): "I think if user tries to issue

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #24 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #23) > Just another question: If we checkout in the staff client, wouldn't it be > good to also show a message? A staff

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #23 from Marcel de Rooy --- Just another question: If we checkout in the staff client, wouldn't it be good to also show a message? A staff member could remind the patron that the fee is applied

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #22 from Marcel de Rooy --- (In reply to Alex Sassmannshausen from comment #20) > Claire and I have deliberated for a bit at the hackfest, and we think the > following would be minor

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #17 from Jonathan Druart --- Created attachment 60993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60993=edit Bug 17560: Improve strenght of hold existence

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Code looks good to me. Note some wording issues and one blocker in the db > revision.

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Sally Healey changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #12 from Martin Renvoize --- My bad, they are subtly different.. one is 'Charge on collection' the other is 'Charge when ready for collection'. -- You are receiving this mail because:

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #7 from Josef Moravec --- Created attachment 57242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57242=edit [SIGNED-OFF] Bug 17560: Update current code This patch updates the

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #9 from Josef Moravec --- Created attachment 57244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57244=edit [SIGNED-OFF] Bug 17560: Update the wording when a patron places a

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #8 from Josef Moravec --- Created attachment 57243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57243=edit [SIGNED-OFF] Bug 17560: Hold fee placement at point of checkout

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #10 from Josef Moravec --- Created attachment 57245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57245=edit [SIGNED-OFF] Bug 17560: Add a message when a patron checking in

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Josef Moravec changed: What|Removed |Added Attachment #57233|0 |1

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #1 from Jonathan Druart --- Created attachment 57233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57233=edit Bug 17560: Add a third option to HoldFeeMode

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #2 from Jonathan Druart --- Created attachment 57234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57234=edit Bug 17560: Update current code This patch

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #4 from Jonathan Druart --- Created attachment 57236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57236=edit Bug 17560: Update the wording when a patron

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #3 from Jonathan Druart --- Created attachment 57235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57235=edit Bug 17560: Hold fee placement at point of

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 --- Comment #5 from Jonathan Druart --- Created attachment 57237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57237=edit Bug 17560: Add a message when a patron checking

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED