https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #61 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #60)
> (In reply to Julian Maurice from comment #55)
> > 'any' returns a boolean value, we're looking for the $client hashref here
> >
> > > 'first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #59 from Julian Maurice ---
(In reply to Julian Maurice from comment #55)
> Actually, we should use ->find, since access_token is a primary key (->find
> is used at other places in the code, I forgot to change this one)
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #58 from Julian Maurice ---
Created attachment 74600
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74600&action=edit
Bug 20402: Remove useless call to Koha::OAuthAccessTokens->search
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #57 from Julian Maurice ---
(In reply to Martin Renvoize from comment #54)
> Comment on attachment 74380 [details] [review]
> Bug 20402: Implement OAuth2 authentication for REST API
>
> Review of attachment 74380 [detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #56 from Julian Maurice ---
(In reply to Martin Renvoize from comment #51)
> Comment on attachment 74380 [details] [review]
> Bug 20402: Implement OAuth2 authentication for REST API
>
> Review of attachment 74380 [detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #55 from Julian Maurice ---
(In reply to Martin Renvoize from comment #50)
> Comment on attachment 74380 [details] [review]
> ::: Koha/OAuth.pm
> @@ +21,5 @@
> > +return (0, 'unauthorized_client') unless $client_id;
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #52 from Martin Renvoize ---
Comment on attachment 74380
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74380
Bug 20402: Implement OAuth2 authentication for REST API
Review of attachment 74380:
-->
(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #52 from Martin Renvoize ---
Comment on attachment 74380
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74380
Bug 20402: Implement OAuth2 authentication for REST API
Review of attachment 74380:
-->
(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #52 from Martin Renvoize ---
Comment on attachment 74380
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74380
Bug 20402: Implement OAuth2 authentication for REST API
Review of attachment 74380:
-->
(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #51 from Martin Renvoize ---
Comment on attachment 74380
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74380
Bug 20402: Implement OAuth2 authentication for REST API
Review of attachment 74380:
-->
(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #50 from Martin Renvoize ---
Comment on attachment 74380
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74380
Bug 20402: Implement OAuth2 authentication for REST API
Review of attachment 74380:
-->
(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||20624
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #49 from Jonathan Druart
---
It the key is revoked or deleted, the token is still valid, is it expected?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||20612
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Text to go in the||This development adds th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #46 from Tomás Cohen Arazi ---
Created attachment 74386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74386&action=edit
Bug 20402: Add missing POD
Signed-off-by: Tomas Cohen Arazi
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #74368|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #45 from Tomás Cohen Arazi ---
Created attachment 74385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74385&action=edit
Bug 20402: Atomic update and kohastructure.sql fixes
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #74369|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #74367|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #74366|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #74365|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #74070|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #38 from Julian Maurice ---
Created attachment 74368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74368&action=edit
Bug 20402: Remove dependency on Mojo::Plugin::OAuth2::Server
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #39 from Julian Maurice ---
Created attachment 74369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74369&action=edit
Bug 20402: Use TestBuilder->build_object in oauth.t
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #74088|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #74069|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks|20568 |
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Mike changed:
What|Removed |Added
CC||blac...@gmail.com
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #34 from Julian Maurice ---
Created attachment 74088
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74088&action=edit
Bug 20402: Don't look at cookies if OAuth2 is attempted and has failed
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #33 from Josef Moravec ---
(In reply to Julian Maurice from comment #32)
> (In reply to Josef Moravec from comment #29)
> > Tested on another devbox, now I got 401 Unauthorized.
> >
> > I have an idea of what is going on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #32 from Julian Maurice ---
(In reply to Josef Moravec from comment #29)
> Tested on another devbox, now I got 401 Unauthorized.
>
> I have an idea of what is going on:
>
> This only adds new authorization method, but t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #31 from Josef Moravec ---
Created attachment 74070
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74070&action=edit
Bug 20402: Fix oauth.t
GET /patrons now requires { "borrowers": 1 } instead of
{ "bo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Josef Moravec changed:
What|Removed |Added
Attachment #74050|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #29 from Josef Moravec ---
Tested on another devbox, now I got 401 Unauthorized.
I have an idea of what is going on:
This only adds new authorization method, but the authorization with cookies
(eg. when you are normally
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #28 from Julian Maurice ---
Created attachment 74051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74051&action=edit
Bug 20402: Fix oauth.t
GET /patrons now requires { "borrowers": 1 } instead of
{ "b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #74018|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #26 from Julian Maurice ---
(In reply to Josef Moravec from comment #24)
> Token is removed, but i got status 500
Can you check the logs? I just tested and for me it returns 401 as expected
> One test is failing for me
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||20568
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #25 from Tomás Cohen Arazi ---
(In reply to Julian Maurice from comment #21)
> A few notes about the last patch:
> - I attached it only as an easy way to see the last changes, beacause I will
> squash all patches into one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #24 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #72892|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #21 from Julian Maurice ---
A few notes about the last patch:
- I attached it only as an easy way to see the last changes, beacause I will
squash all patches into one clean patch.
- The use of Mojolicious::Plugin::OAuth2:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #20 from Julian Maurice ---
Created attachment 74009
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74009&action=edit
Bug 20402: Tie client with patron, remove scopes, use mojo plugin, ...
... and move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
--- Comment #19 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #18 from Julian Maurice ---
(In reply to Tomás Cohen Arazi from comment #17)
> I think we should tie api id and keys to patrons to take advantage of the
> current permission system. And introduce the use of scopes at a la
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #15 from Julian Maurice ---
(In reply to Tomás Cohen Arazi from comment #14)
> - I think the way scopes are defined needs more thinking, also its relation
> to permissions. The patchset adds patrons.read but I'm sure we n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #16 from Tomás Cohen Arazi ---
(In reply to Julian Maurice from comment #15)
> (In reply to Tomás Cohen Arazi from comment #14)
> > - I think the way scopes are defined needs more thinking, also its relation
> > to permis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||dependency
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #13 from Julian Maurice ---
Created attachment 73087
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73087&action=edit
Bug 20402: Add cronjob script to delete expired tokens
Test plan:
1. Generate X tok
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #12 from Julian Maurice ---
Created attachment 73086
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73086&action=edit
Bug 20402: Add unit tests
Also, avoid some Perl warnings about undefined variables,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
CC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
M. Tompsett changed:
What|Removed |Added
Attachment #72886|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
M. Tompsett changed:
What|Removed |Added
Attachment #72888|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
M. Tompsett changed:
What|Removed |Added
Attachment #72887|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #6 from Julian Maurice ---
Note: you can add as many API clients as you want by adding additional
elements.
I'm sure it would be better for API clients to be stored in database with a
nice interface to manage them in Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #4 from Julian Maurice ---
Created attachment 72887
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72887&action=edit
Bug 20402: Add Net::OAuth2::AuthorizationServer to perl deps
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #72874|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Attachment #72865|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #2 from M. Tompsett ---
Created attachment 72874
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72874&action=edit
Bug 20402: Follow-up to correct uninitialized failures
Added type => 'access' to the to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #1 from Julian Maurice ---
Created attachment 72865
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72865&action=edit
Bug 20402: Implement OAuth2 authentication for REST API
It implements only the "clie
74 matches
Mail list logo
